Skip to content

Commit 9fd64a2

Browse files
authored
Remove deprecated file type in ModelElement. (#3598)
1 parent 4317b06 commit 9fd64a2

File tree

3 files changed

+1
-57
lines changed

3 files changed

+1
-57
lines changed

lib/src/generator/templates.runtime_renderers.dart

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -10561,28 +10561,6 @@ class _Renderer_ModelElement extends RendererBase<ModelElement> {
1056110561
getters: _invisibleGetters['FileStructure']!);
1056210562
},
1056310563
),
10564-
'fileType': Property(
10565-
getValue: (CT_ c) => c.fileType,
10566-
renderVariable:
10567-
(CT_ c, Property<CT_> self, List<String> remainingNames) {
10568-
if (remainingNames.isEmpty) {
10569-
return self.getValue(c).toString();
10570-
}
10571-
var name = remainingNames.first;
10572-
var nextProperty =
10573-
_Renderer_String.propertyMap().getValue(name);
10574-
return nextProperty.renderVariable(
10575-
self.getValue(c) as String,
10576-
nextProperty,
10577-
[...remainingNames.skip(1)]);
10578-
},
10579-
isNullValue: (CT_ c) => false,
10580-
renderValue: (CT_ c, RendererBase<CT_> r,
10581-
List<MustachioNode> ast, StringSink sink) {
10582-
_render_String(c.fileType, ast, r.template, sink,
10583-
parent: r);
10584-
},
10585-
),
1058610564
'fullyQualifiedName': Property(
1058710565
getValue: (CT_ c) => c.fullyQualifiedName,
1058810566
renderVariable:
@@ -12132,28 +12110,6 @@ class _Renderer_Package extends RendererBase<Package> {
1213212110
parent: r);
1213312111
},
1213412112
),
12135-
'fileType': Property(
12136-
getValue: (CT_ c) => c.fileType,
12137-
renderVariable:
12138-
(CT_ c, Property<CT_> self, List<String> remainingNames) {
12139-
if (remainingNames.isEmpty) {
12140-
return self.getValue(c).toString();
12141-
}
12142-
var name = remainingNames.first;
12143-
var nextProperty =
12144-
_Renderer_String.propertyMap().getValue(name);
12145-
return nextProperty.renderVariable(
12146-
self.getValue(c) as String,
12147-
nextProperty,
12148-
[...remainingNames.skip(1)]);
12149-
},
12150-
isNullValue: (CT_ c) => false,
12151-
renderValue: (CT_ c, RendererBase<CT_> r,
12152-
List<MustachioNode> ast, StringSink sink) {
12153-
_render_String(c.fileType, ast, r.template, sink,
12154-
parent: r);
12155-
},
12156-
),
1215712113
'fullyQualifiedName': Property(
1215812114
getValue: (CT_ c) => c.fullyQualifiedName,
1215912115
renderVariable:

lib/src/model/model_element.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -600,10 +600,6 @@ abstract class ModelElement extends Canonicalization
600600
@Deprecated('replace with fileStructure.fileName')
601601
String get fileName => fileStructure.fileName;
602602

603-
@Deprecated('Will be removed.')
604-
// TODO(kallentu): Remove the usages of this getter to default to html.
605-
String get fileType => 'html';
606-
607603
/// The full path of the output file in which this element will be primarily
608604
/// documented.
609605
String get filePath;

lib/src/model/package.dart

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -191,15 +191,7 @@ class Package extends LibraryContainer
191191
@override
192192
String get enclosingName => packageGraph.defaultPackageName;
193193

194-
String get filePath => 'index.$fileType';
195-
196-
// TODO(jdkoren): Provide a way to determine file type of a remote package's
197-
// docs. Perhaps make this configurable through dartdoc options.
198-
// In theory, a remote package could be documented in any supported format.
199-
// In practice, devs depend on Dart, Flutter, and/or packages fetched
200-
// from pub.dev, and we know that all of those use html docs.
201-
// TODO(kallentu): Remove the usages of this getter to default to html.
202-
String get fileType => 'html';
194+
String get filePath => 'index.html';
203195

204196
@override
205197
String get fullyQualifiedName => 'package:$name';

0 commit comments

Comments
 (0)