Skip to content

Commit a2b1606

Browse files
devoncarewdevoncarew
authored
Merge pull request #1204 from dart-lang/show_full_enums
show the full value of enums
2 parents ca48954 + 9aecde7 commit a2b1606

File tree

10 files changed

+38
-26
lines changed

10 files changed

+38
-26
lines changed

‎lib/templates/_constant.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<span class="signature">&#8594; {{{ linkedReturnType }}}</span>
44
</dt>
55
<dd>
6-
<p>{{{ oneLineDoc }}}</p>
6+
{{{ documentationAsHtml }}}
77
<div>
88
<span class="signature"><code>{{{ constantValue }}}</code></span>
99
</div>

‎testing/test_package/lib/example.dart‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,17 @@ int function1(String s, bool b, lastParam) => 5;
5050

5151
typedef String processMessage<T>(String msg);
5252

53-
enum Animal { CAT, DOG, HORSE }
53+
enum Animal {
54+
/// Single line docs.
55+
CAT,
56+
57+
/// Multi line docs.
58+
///
59+
/// [Dog] needs lots of docs.
60+
DOG,
61+
62+
HORSE
63+
}
5464

5565
/**
5666
* Sample class [String]

‎testing/test_package_docs/ex/Animal-class.html‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ <h2>Constants</h2>
142142
<span class="signature">&#8594; <a href="ex/Animal-class.html">Animal</a></span>
143143
</dt>
144144
<dd>
145-
<p></p>
145+
<p>Single line docs.</p>
146146
<div>
147147
<span class="signature"><code>const Animal(0)</code></span>
148148
</div>
@@ -152,7 +152,8 @@ <h2>Constants</h2>
152152
<span class="signature">&#8594; <a href="ex/Animal-class.html">Animal</a></span>
153153
</dt>
154154
<dd>
155-
<p></p>
155+
<p>Multi line docs.</p>
156+
<p><a href="ex/Dog-class.html">Dog</a> needs lots of docs.</p>
156157
<div>
157158
<span class="signature"><code>const Animal(1)</code></span>
158159
</div>
@@ -162,7 +163,7 @@ <h2>Constants</h2>
162163
<span class="signature">&#8594; <a href="ex/Animal-class.html">Animal</a></span>
163164
</dt>
164165
<dd>
165-
<p></p>
166+
166167
<div>
167168
<span class="signature"><code>const Animal(2)</code></span>
168169
</div>

‎testing/test_package_docs/ex/Apple-class.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ <h2>Constants</h2>
163163
<span class="signature">&#8594; int</span>
164164
</dt>
165165
<dd>
166-
<p></p>
166+
167167
<div>
168168
<span class="signature"><code>5</code></span>
169169
</div>

‎testing/test_package_docs/ex/ShapeType-class.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ <h2>Constants</h2>
142142
<span class="signature">&#8594; <a href="ex/ShapeType-class.html">ShapeType</a></span>
143143
</dt>
144144
<dd>
145-
<p></p>
145+
146146
<div>
147147
<span class="signature"><code>const <a href="ex/ShapeType-class.html">ShapeType</a>._internal("Ellipse")</code></span>
148148
</div>
@@ -152,7 +152,7 @@ <h2>Constants</h2>
152152
<span class="signature">&#8594; <a href="ex/ShapeType-class.html">ShapeType</a></span>
153153
</dt>
154154
<dd>
155-
<p></p>
155+
156156
<div>
157157
<span class="signature"><code>const <a href="ex/ShapeType-class.html">ShapeType</a>._internal("Rect")</code></span>
158158
</div>

‎testing/test_package_docs/ex/ex-library.html‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ <h2>Constants</h2>
104104
<span class="signature">&#8594; String</span>
105105
</dt>
106106
<dd>
107-
<p></p>
107+
108108
<div>
109109
<span class="signature"><code>&#39;red&#39;</code></span>
110110
</div>
@@ -114,7 +114,7 @@ <h2>Constants</h2>
114114
<span class="signature">&#8594; String</span>
115115
</dt>
116116
<dd>
117-
<p></p>
117+
118118
<div>
119119
<span class="signature"><code>&#39;green&#39;</code></span>
120120
</div>
@@ -124,7 +124,7 @@ <h2>Constants</h2>
124124
<span class="signature">&#8594; String</span>
125125
</dt>
126126
<dd>
127-
<p></p>
127+
128128
<div>
129129
<span class="signature"><code>&#39;orange&#39;</code></span>
130130
</div>
@@ -134,7 +134,7 @@ <h2>Constants</h2>
134134
<span class="signature">&#8594; String</span>
135135
</dt>
136136
<dd>
137-
<p></p>
137+
138138
<div>
139139
<span class="signature"><code>&#39;red&#39; + &#39;-&#39; + &#39;green&#39; + &#39;-&#39; + &#39;blue&#39;</code></span>
140140
</div>
@@ -174,7 +174,7 @@ <h2>Constants</h2>
174174
<span class="signature">&#8594; <a href="ex/ConstantCat-class.html">ConstantCat</a></span>
175175
</dt>
176176
<dd>
177-
<p></p>
177+
178178
<div>
179179
<span class="signature"><code>const <a href="ex/ConstantCat-class.html">ConstantCat</a>(&#39;tabby&#39;)</code></span>
180180
</div>
@@ -184,7 +184,7 @@ <h2>Constants</h2>
184184
<span class="signature">&#8594; List&lt;String&gt;</span>
185185
</dt>
186186
<dd>
187-
<p></p>
187+
188188
<div>
189189
<span class="signature"><code>const &lt;String&gt; [COLOR_GREEN, COLOR_ORANGE, &#39;blue&#39;]</code></span>
190190
</div>

‎testing/test_package_docs/fake/Color-class.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ <h2>Constants</h2>
155155
<span class="signature">&#8594; <a href="fake/Color-class.html">Color</a></span>
156156
</dt>
157157
<dd>
158-
<p></p>
158+
159159
<div>
160160
<span class="signature"><code>const Color(4)</code></span>
161161
</div>
@@ -165,7 +165,7 @@ <h2>Constants</h2>
165165
<span class="signature">&#8594; <a href="fake/Color-class.html">Color</a></span>
166166
</dt>
167167
<dd>
168-
<p></p>
168+
169169
<div>
170170
<span class="signature"><code>const Color(3)</code></span>
171171
</div>
@@ -175,7 +175,7 @@ <h2>Constants</h2>
175175
<span class="signature">&#8594; <a href="fake/Color-class.html">Color</a></span>
176176
</dt>
177177
<dd>
178-
<p></p>
178+
179179
<div>
180180
<span class="signature"><code>const Color(5)</code></span>
181181
</div>
@@ -215,7 +215,7 @@ <h2>Constants</h2>
215215
<span class="signature">&#8594; <a href="fake/Color-class.html">Color</a></span>
216216
</dt>
217217
<dd>
218-
<p></p>
218+
219219
<div>
220220
<span class="signature"><code>const Color(6)</code></span>
221221
</div>
@@ -225,7 +225,7 @@ <h2>Constants</h2>
225225
<span class="signature">&#8594; <a href="fake/Color-class.html">Color</a></span>
226226
</dt>
227227
<dd>
228-
<p></p>
228+
229229
<div>
230230
<span class="signature"><code>const Color(2)</code></span>
231231
</div>

‎testing/test_package_docs/fake/Foo2-class.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ <h2>Constants</h2>
157157
<span class="signature">&#8594; <a href="fake/Foo2-class.html">Foo2</a></span>
158158
</dt>
159159
<dd>
160-
<p></p>
160+
161161
<div>
162162
<span class="signature"><code>const <a href="fake/Foo2-class.html">Foo2</a>(0)</code></span>
163163
</div>
@@ -167,7 +167,7 @@ <h2>Constants</h2>
167167
<span class="signature">&#8594; <a href="fake/Foo2-class.html">Foo2</a></span>
168168
</dt>
169169
<dd>
170-
<p></p>
170+
171171
<div>
172172
<span class="signature"><code>const <a href="fake/Foo2-class.html">Foo2</a>(1)</code></span>
173173
</div>

‎testing/test_package_docs/fake/LongFirstLine-class.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ <h2>Constants</h2>
191191
<span class="signature">&#8594; int</span>
192192
</dt>
193193
<dd>
194-
<p></p>
194+
195195
<div>
196196
<span class="signature"><code>42</code></span>
197197
</div>
@@ -201,7 +201,7 @@ <h2>Constants</h2>
201201
<span class="signature">&#8594; dynamic</span>
202202
</dt>
203203
<dd>
204-
<p></p>
204+
205205
<div>
206206
<span class="signature"><code>'yup'</code></span>
207207
</div>

‎testing/test_package_docs/fake/fake-library.html‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ <h2>Constants</h2>
122122
<span class="signature">&#8594; <a href="fake/ConstantClass-class.html">ConstantClass</a></span>
123123
</dt>
124124
<dd>
125-
<p></p>
125+
126126
<div>
127127
<span class="signature"><code>const <a href="fake/ConstantClass-class.html">ConstantClass</a>(&#39;custom&#39;)</code></span>
128128
</div>
@@ -172,7 +172,7 @@ <h2>Constants</h2>
172172
<span class="signature">&#8594; String</span>
173173
</dt>
174174
<dd>
175-
<p></p>
175+
176176
<div>
177177
<span class="signature"><code>&#39;yay bug hunting&#39;</code></span>
178178
</div>
@@ -182,7 +182,7 @@ <h2>Constants</h2>
182182
<span class="signature">&#8594; String</span>
183183
</dt>
184184
<dd>
185-
<p></p>
185+
186186
<div>
187187
<span class="signature"><code>&#39;episode seven better be good&#39;</code></span>
188188
</div>
@@ -213,6 +213,7 @@ <h2>Constants</h2>
213213
</dt>
214214
<dd>
215215
<p>Up is a direction.</p>
216+
<p>Getting up in the morning can be hard.</p>
216217
<div>
217218
<span class="signature"><code>&#39;up&#39;</code></span>
218219
</div>

0 commit comments

Comments
 (0)