Misc performance tweaks (#1430)

* performance tweaks

* cleanup and change mustache version to remote again

Author: jcollins-g

lib/dartdoc.dart

@@ -290,7 +290,7 @@ class DartDoc {
     if (!file.existsSync()) {
       return null;
     }
-    Document doc = parse(file.readAsStringSync());
+    Document doc = parse(file.readAsBytesSync());
     Element base = doc.querySelector('base');
     String baseHref;
     if (base != null) {
@@ -301,6 +301,7 @@ class DartDoc {
         .map((link) => link.attributes['href'])
         .where((href) => href != null)
         .toList();
+
     return new Tuple2(stringLinks, baseHref);
   }
 
@@ -312,6 +313,7 @@ class DartDoc {
       fullPath = path.normalize(fullPath);
     }
 
+    visited.add(fullPath);
     Tuple2 stringLinksAndHref = _getStringLinksAndHref(fullPath);
     if (stringLinksAndHref == null) {
       _warn(package, PackageWarning.brokenLink, pathToCheck,
@@ -335,7 +337,6 @@ class DartDoc {
         String newFullPath = path.joinAll([origin, newPathToCheck]);
         newFullPath = path.normalize(newFullPath);
         if (!visited.contains(newFullPath)) {
-          visited.add(newFullPath);
           _doCheck(package, origin, visited, newPathToCheck, pathToCheck,
               newFullPath);
         }

lib/src/model.dart

@@ -1573,12 +1573,15 @@ class Library extends ModelElement {
     return _modelElementsMap;
   }
 
-  Iterable<ModelElement> get allModelElements sync* {
-    for (Set<ModelElement> modelElements in modelElementsMap.values) {
-      for (ModelElement modelElement in modelElements) {
-        yield modelElement;
+  List<ModelElement> _allModelElements;
+  Iterable<ModelElement> get allModelElements {
+    if (_allModelElements == null) {
+      _allModelElements = [];
+      for (Set<ModelElement> modelElements in modelElementsMap.values) {
+        _allModelElements.addAll(modelElements);
       }
     }
+    return _allModelElements;
   }
 
   List<ModelElement> _allCanonicalModelElements;

pubspec.lock

@@ -168,7 +168,7 @@ packages:
       name: mustache4dart
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.12"
+    version: "1.1.0"
   package_config:
     description:
       name: package_config

pubspec.yaml

@@ -16,7 +16,7 @@ dependencies:
   http_parser: '>=3.0.3 <4.0.0'
   logging: '>=0.9.0 <0.12.0'
   markdown: ^0.11.2
-  mustache4dart: ^1.0.9
+  mustache4dart: ^1.1.0
   package_config: '>=0.1.5 <2.0.0'
   path: ^1.3.0
   resource: ^1.1.0