Standardize to newer APIs

Author: parlough

lib/src/model/package_graph.dart

@@ -147,7 +147,7 @@ class PackageGraph with CommentReferable, Nameable {
     allLibrariesAdded = true;
     // Go through docs of every ModelElement in package to pre-build the macros
     // index.
-    await Future.wait(_precacheLocalDocs());
+    await _precacheLocalDocs().wait;
     _localDocumentationBuilt = true;
 
     // Scan all model elements to insure that interceptor and other special
@@ -896,10 +896,7 @@ class PackageGraph with CommentReferable, Nameable {
     }
 
     assert(matches.length <= 1);
-    if (matches.isNotEmpty) {
-      return matches.first;
-    }
-    return null;
+    return matches.firstOrNull;
   }
 
   /// This is used when we might need a Library object that isn't actually

lib/src/validator.dart

@@ -195,7 +195,7 @@ class Validator {
     final links = doc.querySelectorAll('a');
     final stringLinks = links
         .map((link) => link.attributes['href'])
-        .whereType<String>()
+        .nonNulls
         .where((href) =>
             href.isNotEmpty &&
             !href.startsWith('https:') &&

tool/task.dart

@@ -298,7 +298,7 @@ Future<void> compareFlutterWarnings() async {
       '--path',
       path.join(flutterDir.absolute.path, 'dev', 'docs', 'doc'),
     ]);
-    await Future.wait([original, current]);
+    await [original, current].wait;
   }
 }
 

web/search.dart

@@ -53,13 +53,10 @@ void init() {
     final url = Uri.parse(window.location.toString());
     final searchQuery = url.queryParameters['search'];
     if (searchQuery != null) {
-      final matches = index.find(searchQuery);
-      if (matches.isNotEmpty) {
-        final href = matches.first.href;
-        if (href != null) {
-          window.location.assign('$_htmlBase$href');
-          return;
-        }
+      final href = index.find(searchQuery).firstOrNull?.href;
+      if (href != null) {
+        window.location.assign('$_htmlBase$href');
+        return;
       }
     }