Remove abstract RendererFactory and template, category, and attribute renderers. (#3612)

* Remove category and attribute renderers.

* Fix tests and update Category.

* Remove template layout renderer.

* Add comment.

Author: kallentu

lib/src/generator/template_data.dart

@@ -107,9 +107,14 @@ abstract class TemplateData<T extends Documentable> extends TemplateDataBase {
     String name, {
     String? kind,
     bool isDeprecated = false,
-  }) =>
-      _packageGraph.rendererFactory.templateRenderer
-          .composeLayoutTitle(name, kind, isDeprecated);
+  }) {
+    var kindText = kind == null ? '' : ' $kind';
+    if (isDeprecated) {
+      return '<span class="deprecated">$name</span>$kindText';
+    } else {
+      return '$name$kindText';
+    }
+  }
 }
 
 /// A [TemplateData] which contains a library, for rendering the

lib/src/model/annotation.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'dart:convert';
+
 import 'package:analyzer/dart/element/element.dart';
 import 'package:dartdoc/src/element_type.dart';
 import 'package:dartdoc/src/model/attribute.dart';
@@ -25,7 +27,7 @@ class Annotation extends Attribute with ModelBuilder {
 
   @override
   late final String linkedNameWithParameters =
-      packageGraph.rendererFactory.attributeRenderer.renderAnnotation(this);
+      '@$linkedName${HtmlEscape().convert(parameterText)}';
 
   @override
   String get linkedName => annotation.element is PropertyAccessorElement

lib/src/model/category.dart

@@ -8,7 +8,6 @@ import 'package:dartdoc/src/dartdoc_options.dart';
 import 'package:dartdoc/src/model/comment_referable.dart';
 import 'package:dartdoc/src/model/model.dart';
 import 'package:dartdoc/src/model/model_object_builder.dart';
-import 'package:dartdoc/src/render/category_renderer.dart';
 import 'package:dartdoc/src/warnings.dart';
 
 /// A subcategory of a package, containing elements tagged with `{@category}`.
@@ -118,9 +117,37 @@ class Category extends Nameable
   @override
   String? get belowSidebarPath => null;
 
-  String get categoryLabel => _categoryRenderer.renderCategoryLabel(this);
+  String get categoryLabel {
+    final buffer = StringBuffer('<span class="category ');
+    buffer.writeAll(name.toLowerCase().split(' '), '-');
+    buffer.write(' cp-');
+    buffer.write(categoryIndex);
 
-  String get linkedName => _categoryRenderer.renderLinkedName(this);
+    if (isDocumented) {
+      buffer.write(' linked');
+    }
+
+    buffer.write('"'); // Wrap up the class list and begin title
+    buffer.write(' title="This is part of the ');
+    buffer.write(name);
+    buffer.write(' ');
+    buffer.write(kind);
+    buffer.write('.">'); // Wrap up the title
+
+    buffer.write(linkedName);
+    buffer.write('</span>');
+
+    return buffer.toString();
+  }
+
+  String get linkedName {
+    final unbrokenName = name.replaceAll(' ', '&nbsp;');
+    if (isDocumented) {
+      return '<a href="$href">$unbrokenName</a>';
+    } else {
+      return unbrokenName;
+    }
+  }
 
   /// The position in the container order for this category.
   int get categoryIndex => package.categories.indexOf(this);
@@ -147,9 +174,6 @@ class Category extends Nameable
   @override
   Iterable<Class> get exceptions => _exceptions;
 
-  CategoryRenderer get _categoryRenderer =>
-      packageGraph.rendererFactory.categoryRenderer;
-
   @override
   Map<String, CommentReferable> get referenceChildren => const {};
 

lib/src/model/package_graph.dart

@@ -344,8 +344,8 @@ class PackageGraph with CommentReferable, Nameable, ModelBuilder {
   /// Dartdoc's configuration flags.
   final DartdocOptionContext config;
 
-  /// Factory for renderers
-  final RendererFactory rendererFactory;
+  /// Factory for HTML rendering.
+  final HtmlRenderFactory rendererFactory;
 
   /// PackageMeta Provider for building [PackageMeta]s.
   final PackageMetaProvider packageMetaProvider;

lib/src/render/attribute_renderer.dart

@@ -3,129 +3,61 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:dartdoc/src/element_type.dart';
-import 'package:dartdoc/src/render/attribute_renderer.dart';
-import 'package:dartdoc/src/render/category_renderer.dart';
 import 'package:dartdoc/src/render/documentation_renderer.dart';
 import 'package:dartdoc/src/render/element_type_renderer.dart';
 import 'package:dartdoc/src/render/enum_field_renderer.dart';
 import 'package:dartdoc/src/render/language_feature_renderer.dart';
 import 'package:dartdoc/src/render/model_element_renderer.dart';
 import 'package:dartdoc/src/render/parameter_renderer.dart';
 import 'package:dartdoc/src/render/source_code_renderer.dart';
-import 'package:dartdoc/src/render/template_renderer.dart';
 import 'package:dartdoc/src/render/type_parameters_renderer.dart';
 import 'package:dartdoc/src/render/typedef_renderer.dart';
 
-abstract class RendererFactory {
-  const RendererFactory();
-
-  LayoutRenderer get templateRenderer;
-
-  CategoryRenderer get categoryRenderer;
-
-  DocumentationRenderer get documentationRenderer;
-
-  AttributeRenderer get attributeRenderer;
-
-  LanguageFeatureRenderer get languageFeatureRenderer;
-
-  ElementTypeRenderer<FunctionTypeElementType>
-      get functionTypeElementTypeRenderer;
-
-  ElementTypeRenderer<ParameterizedElementType>
-      get parameterizedElementTypeRenderer;
-
-  ElementTypeRenderer<RecordElementType> get recordElementTypeRenderer;
-
-  ElementTypeRenderer<AliasedElementType> get aliasedElementTypeRenderer;
-
-  ElementTypeRenderer<AliasedUndefinedElementType>
-      get aliasedUndefinedElementTypeRenderer;
-
-  ElementTypeRenderer<CallableElementType> get callableElementTypeRenderer;
-
-  EnumFieldRenderer get enumFieldRenderer;
-
-  ModelElementRenderer get modelElementRenderer;
-
-  ParameterRenderer get parameterRenderer;
-
-  ParameterRenderer get parameterRendererDetailed;
-
-  SourceCodeRenderer get sourceCodeRenderer;
-
-  TypeParametersRenderer get typeParametersRenderer;
-
-  TypedefRenderer get typedefRenderer;
-}
-
-class HtmlRenderFactory extends RendererFactory {
+// TODO(kallentu): Inline and remove all the renderers in this renderer factory.
+// Then remove the factory itself.
+class HtmlRenderFactory {
   const HtmlRenderFactory();
 
-  @override
-  LayoutRenderer get templateRenderer => const HtmlLayoutRenderer();
-
-  @override
-  CategoryRenderer get categoryRenderer => const CategoryRendererHtml();
-
-  @override
   DocumentationRenderer get documentationRenderer =>
       const DocumentationRendererHtml();
 
-  @override
   ElementTypeRenderer<CallableElementType> get callableElementTypeRenderer =>
       const CallableElementTypeRendererHtml();
 
-  @override
   ElementTypeRenderer<FunctionTypeElementType>
       get functionTypeElementTypeRenderer =>
           const FunctionTypeElementTypeRendererHtml();
 
-  @override
   ElementTypeRenderer<ParameterizedElementType>
       get parameterizedElementTypeRenderer =>
           const ParameterizedElementTypeRendererHtml();
 
-  @override
   ElementTypeRenderer<RecordElementType> get recordElementTypeRenderer =>
       const RecordElementTypeRendererHtml();
 
-  @override
   ElementTypeRenderer<AliasedElementType> get aliasedElementTypeRenderer =>
       const AliasedElementTypeRendererHtml();
 
-  @override
   EnumFieldRenderer get enumFieldRenderer => const EnumFieldRendererHtml();
 
-  @override
   ModelElementRenderer get modelElementRenderer =>
       const ModelElementRendererHtml();
 
-  @override
   ParameterRenderer get parameterRenderer => const ParameterRendererHtml();
 
-  @override
   ParameterRenderer get parameterRendererDetailed =>
       const ParameterRendererHtmlList();
 
-  @override
   TypeParametersRenderer get typeParametersRenderer =>
       const TypeParametersRendererHtml();
 
-  @override
   TypedefRenderer get typedefRenderer => const TypedefRendererHtml();
 
-  @override
   LanguageFeatureRenderer get languageFeatureRenderer =>
       const LanguageFeatureRendererHtml();
 
-  @override
   SourceCodeRenderer get sourceCodeRenderer => const SourceCodeRendererHtml();
 
-  @override
-  AttributeRenderer get attributeRenderer => const AttributeRendererHtml();
-
-  @override
   ElementTypeRenderer<AliasedUndefinedElementType>
       get aliasedUndefinedElementTypeRenderer =>
           const AliasedUndefinedElementTypeRendererHtml();

lib/src/render/category_renderer.dart

@@ -18,7 +18,6 @@ import 'package:dartdoc/src/model/attribute.dart';
 import 'package:dartdoc/src/model/model.dart';
 import 'package:dartdoc/src/package_config_provider.dart';
 import 'package:dartdoc/src/package_meta.dart';
-import 'package:dartdoc/src/render/category_renderer.dart';
 import 'package:dartdoc/src/render/parameter_renderer.dart';
 import 'package:dartdoc/src/render/typedef_renderer.dart';
 import 'package:dartdoc/src/special_elements.dart';
@@ -772,17 +771,15 @@ void main() {
     // TODO consider moving these to a separate suite
     test('CategoryRendererHtml renders category label', () {
       var category = packageGraph.publicPackages.first.categories.first;
-      var renderer = CategoryRendererHtml();
       expect(
-          renderer.renderCategoryLabel(category),
+          category.categoryLabel,
           '<span class="category superb cp-0 linked" title="This is part of the Superb topic.">'
           '<a href="${htmlBasePlaceholder}topics/Superb-topic.html">Superb</a></span>');
     });
 
     test('CategoryRendererHtml renders linkedName', () {
       var category = packageGraph.publicPackages.first.categories.first;
-      var renderer = CategoryRendererHtml();
-      expect(renderer.renderLinkedName(category),
+      expect(category.linkedName,
           '<a href="${htmlBasePlaceholder}topics/Superb-topic.html">Superb</a>');
     });
   });