Skip to content

Commit df1c164

Browse files
committed
Add a few more explanatory comments
1 parent 813e114 commit df1c164

File tree

5 files changed

+9
-2
lines changed

5 files changed

+9
-2
lines changed

web/sig.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3664B38081E6AFC7A052C0D58672E1EA
1+
77FD7967080D3865482753638F7833E7

web/styles/_content.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
order: 2;
88
overflow-y: scroll;
99
padding: 10px 20px 0 20px;
10+
11+
// Add a min height of the rest of the view port after the header,
12+
// so that the footer isn't awkwardly in the middle of the page.
1013
min-height: calc(100vh - var(--main-header-height));
1114
}
1215

web/styles/_header.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ header {
88
flex-direction: row;
99
align-items: center;
1010

11+
// Position the header at the top of the view port, even on scrolling.
1112
position: sticky;
1213
top: 0;
1314
z-index: 10;

web/styles/_sidebar.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@
8989
}
9090

9191
.sidebar-offcanvas-left, .sidebar-offcanvas-right {
92+
// Even as the primary viewport scrolls, the sidebars should remain visible,
93+
// but below the top header which is always at the top of the viewport.
9294
position: sticky;
9395
top: var(--main-header-height);
9496
overflow-y: auto;
@@ -145,7 +147,7 @@
145147
transition: all .25s ease-out;
146148
z-index: 2000;
147149
top: 0;
148-
width: 280px; /* works all the way down to an iphone 4 */
150+
width: 280px;
149151
// Set a max width for narrow layouts that accounts for margin.
150152
max-width: calc(100% - 20px);
151153
height: 90%;

web/styles/_theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
:root {
6+
// Used by the header and sticky elements wanting to position below it.
67
--main-header-height: 50px;
78
}
89

0 commit comments

Comments
 (0)