Merge pull request #1064 from keertip/caching

add caching for file contents

Author: keertip

lib/src/model.dart

@@ -1380,7 +1380,7 @@ abstract class SourceCodeMixin {
 
   String get sourceCode {
     if (_sourceCodeCache == null) {
-      String contents = element.source.contents.data;
+      String contents = getFileContentsFor(element);
       var node = element.computeNode();
       if (node != null) {
         // Find the start of the line, so that we can line up all the indents.

lib/src/model_utils.dart

@@ -4,33 +4,24 @@
 
 library dartdoc.model_utils;
 
+import 'dart:io';
+
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 
-bool isPrivate(Element e) => e.name.startsWith('_');
+final Map<String, String> _fileContents = <String, String>{};
 
-bool isPublic(Element e) {
-  if (isPrivate(e)) return false;
-  // check to see if element is part of the public api, that is it does not
-  // have a '#nodoc' in the documentation comment
-  if (e is PropertyAccessorElement && e.isSynthetic) {
-    var accessor = (e as PropertyAccessorElement);
-    if (accessor.correspondingSetter != null &&
-        !accessor.correspondingSetter.isSynthetic) {
-      e = accessor.correspondingSetter;
-    } else if (accessor.correspondingGetter != null &&
-        !accessor.correspondingGetter.isSynthetic) {
-      e = accessor.correspondingGetter;
-    } else {
-      e = accessor.variable;
-    }
-  }
+List<InterfaceType> getAllSupertypes(ClassElement c) => c.allSupertypes;
 
-  var docComment = e.computeDocumentationComment();
-  if (docComment != null && docComment.contains('<nodoc>')) return false;
-  return true;
+String getFileContentsFor(Element e) {
+  var location = e.source.fullName;
+  if (!_fileContents.containsKey(location)) {
+    var contents = new File(location).readAsStringSync();
+    _fileContents.putIfAbsent(location, () => contents);
+  }
+  return _fileContents[location];
 }
 
 Iterable<LibraryElement> getSdkLibrariesToDocument(
@@ -48,22 +39,34 @@ Iterable<LibraryElement> getSdkLibrariesToDocument(
   }
 }
 
-List<InterfaceType> getAllSupertypes(ClassElement c) => c.allSupertypes;
-
 bool isInExportedLibraries(
     List<LibraryElement> libraries, LibraryElement library) {
   return libraries
       .any((lib) => lib == library || lib.exportedLibraries.contains(library));
 }
 
-/// Strip the common indent from the given source fragment.
-String stripIndentFromSource(String source) {
-  String remainer = source.trimLeft();
-  String indent = source.substring(0, source.length - remainer.length);
-  return source.split('\n').map((line) {
-    line = line.trimRight();
-    return line.startsWith(indent) ? line.substring(indent.length) : line;
-  }).join('\n');
+bool isPrivate(Element e) => e.name.startsWith('_');
+
+bool isPublic(Element e) {
+  if (isPrivate(e)) return false;
+  // check to see if element is part of the public api, that is it does not
+  // have a '#nodoc' in the documentation comment
+  if (e is PropertyAccessorElement && e.isSynthetic) {
+    var accessor = (e as PropertyAccessorElement);
+    if (accessor.correspondingSetter != null &&
+        !accessor.correspondingSetter.isSynthetic) {
+      e = accessor.correspondingSetter;
+    } else if (accessor.correspondingGetter != null &&
+        !accessor.correspondingGetter.isSynthetic) {
+      e = accessor.correspondingGetter;
+    } else {
+      e = accessor.variable;
+    }
+  }
+
+  var docComment = e.computeDocumentationComment();
+  if (docComment != null && docComment.contains('<nodoc>')) return false;
+  return true;
 }
 
 /// Strip leading dartdoc comments from the given source code.
@@ -89,3 +92,13 @@ String stripDartdocCommentsFromSource(String source) {
     return true;
   }).join('\n');
 }
+
+/// Strip the common indent from the given source fragment.
+String stripIndentFromSource(String source) {
+  String remainer = source.trimLeft();
+  String indent = source.substring(0, source.length - remainer.length);
+  return source.split('\n').map((line) {
+    line = line.trimRight();
+    return line.startsWith(indent) ? line.substring(indent.length) : line;
+  }).join('\n');
+}