Compare DefinedElementTypes as equivalent with their forwarded element (#2706)

* It 'works' but no tests for new functionality yet

* dartfmt

* add tests for type parameters, handle more constructor parameter edge cases

* dartfmt rebuild

* remove debugging

* correct isEquivalentTo to handle element type forwarding

* This was never correct, delete hrefs for type parameters

* Correct a problem with inherited docs

* Remember, we need both

* add a fully qualified name for DefinedElementType so that the comparison messages are more useful

* Remove commented out code block

Author: jcollins-g

lib/src/element_type.dart

@@ -297,6 +297,9 @@ abstract class DefinedElementType extends ElementType {
   @override
   String get name => type.element.name;
 
+  @override
+  String get fullyQualifiedName => modelElement.fullyQualifiedName;
+
   bool get isParameterType => (type is TypeParameterType);
 
   /// This type is a public type if the underlying, canonical element is public.

lib/src/generator/templates.runtime_renderers.dart

@@ -4157,6 +4157,26 @@ class _Renderer_DefinedElementType extends RendererBase<DefinedElementType> {
                         parent: r, getters: _invisibleGetters['Element']);
                   },
                 ),
+                'fullyQualifiedName': Property(
+                  getValue: (CT_ c) => c.fullyQualifiedName,
+                  renderVariable:
+                      (CT_ c, Property<CT_> self, List<String> remainingNames) {
+                    if (remainingNames.isEmpty) {
+                      return self.getValue(c).toString();
+                    }
+                    var name = remainingNames.first;
+                    var nextProperty =
+                        _Renderer_String.propertyMap().getValue(name);
+                    return nextProperty.renderVariable(self.getValue(c),
+                        nextProperty, [...remainingNames.skip(1)]);
+                  },
+                  isNullValue: (CT_ c) => c.fullyQualifiedName == null,
+                  renderValue: (CT_ c, RendererBase<CT_> r,
+                      List<MustachioNode> ast, StringSink sink) {
+                    _render_String(c.fullyQualifiedName, ast, r.template, sink,
+                        parent: r);
+                  },
+                ),
                 'instantiatedType': Property(
                   getValue: (CT_ c) => c.instantiatedType,
                   renderVariable: (CT_ c, Property<CT_> self,

lib/src/matching_link_result.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:dartdoc/src/element_type.dart';
 import 'package:dartdoc/src/model/comment_referable.dart';
 import 'package:dartdoc/src/model/model.dart';
 import 'package:dartdoc/src/quiver.dart';
@@ -26,6 +27,14 @@ class MatchingLinkResult {
     var compareThis = commentReferable;
     var compareOther = other.commentReferable;
 
+    if (compareThis is DefinedElementType) {
+      compareThis = (compareThis as DefinedElementType).modelElement;
+    }
+
+    if (compareOther is DefinedElementType) {
+      compareOther = (compareOther as DefinedElementType).modelElement;
+    }
+
     if (compareThis is Accessor) {
       compareThis = (compareThis as Accessor).enclosingCombo;
     }