From fea098071ff5a15a12d5fd1834e7e36a72a4c054 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Fri, 30 Aug 2024 04:46:43 -0700 Subject: [PATCH] Remove extraneous parens from function-type --- lib/src/render/element_type_renderer.dart | 2 +- test/element_type_test.dart | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/src/render/element_type_renderer.dart b/lib/src/render/element_type_renderer.dart index bb3ed84008..9c9ba746c6 100644 --- a/lib/src/render/element_type_renderer.dart +++ b/lib/src/render/element_type_renderer.dart @@ -16,7 +16,7 @@ abstract class ElementTypeRenderer { String wrapNullabilityParens(T elementType, String inner) => elementType.nullabilitySuffix.isEmpty ? inner - : '($inner${elementType.nullabilitySuffix})'; + : '$inner${elementType.nullabilitySuffix}'; } // HTML implementations. diff --git a/test/element_type_test.dart b/test/element_type_test.dart index ddf2764dda..9fccc5960e 100644 --- a/test/element_type_test.dart +++ b/test/element_type_test.dart @@ -171,12 +171,11 @@ void f(int Function(String)? p) {} expect( parameterType.linkedName, - // TODO(https://github.com/dart-lang/dartdoc/issues/2381): Fix. - '($intLink Function' + '$intLink Function' '' '(' '$stringLink' - ')?)', + ')?', ); expect(parameterType.nameWithGenerics, equals('Function')); }); @@ -190,11 +189,11 @@ void f(int Function(T)? p) {} expect( parameterType.linkedName, - '($intLink Function' + '$intLink Function' '<T>' '' '(' - 'T)?)', + 'T)?', ); expect( parameterType.nameWithGenerics,