firehose: echo any error output from dependencies task on failure (#393)

Also fix flutter install logic
Also fix a lint

Author: kevmoo

.github/workflows/health.yaml

@@ -93,7 +93,7 @@ on:
         required: false
       flutter_packages:
         description: List of packages depending on Flutter.
-        default: "\"\""
+        default: ""
         required: false
         type: string
       ignore_license:

.github/workflows/health_base.yaml

@@ -39,7 +39,7 @@ on:
         type: boolean
         required: false
       flutter_packages:
-        default: '""'
+        default: ""
         required: false
         type: string
       ignore_license:
@@ -173,7 +173,7 @@ jobs:
             ${{ fromJSON('{"true":"--coverage_web","false":""}')[inputs.coverage_web] }} \
             --fail_on ${{ inputs.fail_on }} \
             --warn_on ${{ inputs.warn_on }} \
-            --flutter_packages ${{ inputs.flutter_packages }} \
+            --flutter_packages "${{ inputs.flutter_packages }}" \
             --ignore_packages ${{ inputs.ignore_packages }} \
             --ignore_license ${{ inputs.ignore_license }} \
             --ignore_changelog ${{ inputs.ignore_changelog }} \

pkgs/corpus/lib/pub.dart

@@ -66,11 +66,7 @@ class Pub {
 
     for (;;) {
       final targetUri = uri.replace(
-        queryParameters: {
-          'q': query,
-          'page': page.toString(),
-          if (sort != null) 'sort': sort,
-        },
+        queryParameters: {'q': query, 'page': page.toString(), 'sort': ?sort},
       );
 
       final map = await _getJson(targetUri);

pkgs/firehose/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.13.2-wip
+
+- Echo any error output from dependencies task on failure 
+  (avoids silent failures).
+
 ## 0.13.1
 
 - Fix an issue with a nullable neededVersion

pkgs/firehose/lib/src/health/health.dart

@@ -204,7 +204,7 @@ class Health {
         logStdout: false,
       );
 
-      final (result, _, _) = runDashProcess(
+      final (result, out, err) = runDashProcess(
         flutterPackages,
         package,
         [
@@ -219,7 +219,8 @@ class Health {
 
       if (result.exitCode != 0) {
         hasError = true;
-        final output = (result.stderr as String).replaceAll('\n', '<br>');
+        final output = (err.trim().isNotEmpty ? err.trim() : out.trim())
+            .replaceAll('\n', '<br>');
         results.add('''
 | ${package.name} | <details><summary>:exclamation: Show Issues</summary><pre>$output</pre></details> |''');
       } else {

pkgs/firehose/pubspec.yaml

@@ -1,6 +1,6 @@
 name: firehose
 description: A tool to automate publishing of Pub packages from GitHub actions.
-version: 0.13.1
+version: 0.13.2-wip
 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
 
 environment:

pkgs/firehose/test_data/golden/comment_unused-dependencies.md

@@ -7,7 +7,7 @@
 | :--- | :--- |
 | package1 | :heavy_check_mark: All dependencies utilized correctly. |
 | package2 | :heavy_check_mark: All dependencies utilized correctly. |
-| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * lints<br></pre></details> |
+| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * lints</pre></details> |
 
 For details on how to fix these, see [dependency_validator](https://pub.dev/packages/dependency_validator).
 

pkgs/firehose/test_data/golden/comment_unused-dependencies_healthchanged.md

@@ -8,8 +8,8 @@
 | package1 | :heavy_check_mark: All dependencies utilized correctly. |
 | package2 | :heavy_check_mark: All dependencies utilized correctly. |
 | package3 | :heavy_check_mark: All dependencies utilized correctly. |
-| package4 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * http<br>  * intl<br>  * lints<br>  * path<br></pre></details> |
-| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * lints<br></pre></details> |
+| package4 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * http<br>  * intl<br>  * lints<br>  * path</pre></details> |
+| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * lints</pre></details> |
 
 For details on how to fix these, see [dependency_validator](https://pub.dev/packages/dependency_validator).
 

pkgs/firehose/test_data/golden/comment_unused-dependencies_ignore_package.md

@@ -6,7 +6,7 @@
 | Package | Status |
 | :--- | :--- |
 | package2 | :heavy_check_mark: All dependencies utilized correctly. |
-| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * lints<br></pre></details> |
+| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br>  * lints</pre></details> |
 
 For details on how to fix these, see [dependency_validator](https://pub.dev/packages/dependency_validator).