Skip to content

Commit 2c9b418

Browse files
authored
Fix response request in MockClient (#657)
Use the stub returned request field from the response.
1 parent a645b93 commit 2c9b418

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
## 0.13.5-dev
22

33
* Allow async callbacks in RetryClient.
4+
* In `MockHttpClient` use the callback returned `Response.request` instead of
5+
the argument value to give more control to the callback. This may be breaking
6+
for callbacks which return incomplete Responses and relied on the default.
47

58
## 0.13.4
69

lib/src/mock_client.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class MockClient extends BaseClient {
4343
return StreamedResponse(
4444
ByteStream.fromBytes(response.bodyBytes), response.statusCode,
4545
contentLength: response.contentLength,
46-
request: baseRequest,
46+
request: response.request,
4747
headers: response.headers,
4848
isRedirect: response.isRedirect,
4949
persistentConnection: response.persistentConnection,
@@ -57,7 +57,7 @@ class MockClient extends BaseClient {
5757
final response = await fn(request, bodyStream);
5858
return StreamedResponse(response.stream, response.statusCode,
5959
contentLength: response.contentLength,
60-
request: request,
60+
request: response.request,
6161
headers: response.headers,
6262
isRedirect: response.isRedirect,
6363
persistentConnection: response.persistentConnection,

0 commit comments

Comments
 (0)