Enable and fix lint cascade_invocations (#307)

Author: natebosch

analysis_options.yaml

@@ -19,7 +19,7 @@ linter:
   - avoid_unused_constructor_parameters
   - await_only_futures
   - camel_case_types
-  # cascade_invocations
+  - cascade_invocations
   # comment_references
   - control_flow_in_finally
   - curly_braces_in_flow_control_structures

lib/src/browser_client.dart

@@ -47,8 +47,9 @@ class BrowserClient extends BaseClient {
     var xhr = HttpRequest();
     _xhrs.add(xhr);
     _openHttpRequest(xhr, request.method, request.url.toString(), asynch: true);
-    xhr.responseType = 'blob';
-    xhr.withCredentials = withCredentials;
+    xhr
+      ..responseType = 'blob'
+      ..withCredentials = withCredentials;
     request.headers.forEach(xhr.setRequestHeader);
 
     var completer = Completer<StreamedResponse>();

lib/src/io_client.dart

@@ -31,9 +31,7 @@ class IOClient extends BaseClient {
     var stream = request.finalize();
 
     try {
-      var ioRequest = await _inner.openUrl(request.method, request.url);
-
-      ioRequest
+      var ioRequest = (await _inner.openUrl(request.method, request.url))
         ..followRedirects = request.followRedirects
         ..maxRedirects = request.maxRedirects
         ..contentLength =

test/html/streamed_request_test.dart

@@ -13,10 +13,10 @@ import 'utils.dart';
 void main() {
   group('contentLength', () {
     test("works when it's set", () {
-      var request = http.StreamedRequest('POST', echoUrl);
-      request.contentLength = 10;
-      request.sink.add([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
-      request.sink.close();
+      var request = http.StreamedRequest('POST', echoUrl)
+        ..contentLength = 10
+        ..sink.add([1, 2, 3, 4, 5, 6, 7, 8, 9, 10])
+        ..sink.close();
 
       return BrowserClient().send(request).then((response) {
         expect(response.stream.toBytes(),

test/io/request_test.dart

@@ -13,9 +13,9 @@ void main() {
   test('.send', () {
     expect(
         startServer().then((_) {
-          var request = http.Request('POST', serverUrl);
-          request.body = 'hello';
-          request.headers['User-Agent'] = 'Dart';
+          var request = http.Request('POST', serverUrl)
+            ..body = 'hello'
+            ..headers['User-Agent'] = 'Dart';
 
           expect(
               request.send().then((response) {

test/io/streamed_request_test.dart

@@ -15,10 +15,10 @@ void main() {
   group('contentLength', () {
     test('controls the Content-Length header', () {
       return startServer().then((_) {
-        var request = http.StreamedRequest('POST', serverUrl);
-        request.contentLength = 10;
-        request.sink.add([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
-        request.sink.close();
+        var request = http.StreamedRequest('POST', serverUrl)
+          ..contentLength = 10
+          ..sink.add([1, 2, 3, 4, 5, 6, 7, 8, 9, 10])
+          ..sink.close();
 
         return request.send();
       }).then((response) {

test/io/utils.dart

@@ -27,35 +27,39 @@ Future startServer() {
       var response = request.response;
 
       if (path == '/error') {
-        response.statusCode = 400;
-        response.contentLength = 0;
-        response.close();
+        response
+          ..statusCode = 400
+          ..contentLength = 0
+          ..close();
         return;
       }
 
       if (path == '/loop') {
         var n = int.parse(request.uri.query);
-        response.statusCode = 302;
-        response.headers
-            .set('location', serverUrl.resolve('/loop?${n + 1}').toString());
-        response.contentLength = 0;
-        response.close();
+        response
+          ..statusCode = 302
+          ..headers
+              .set('location', serverUrl.resolve('/loop?${n + 1}').toString())
+          ..contentLength = 0
+          ..close();
         return;
       }
 
       if (path == '/redirect') {
-        response.statusCode = 302;
-        response.headers.set('location', serverUrl.resolve('/').toString());
-        response.contentLength = 0;
-        response.close();
+        response
+          ..statusCode = 302
+          ..headers.set('location', serverUrl.resolve('/').toString())
+          ..contentLength = 0
+          ..close();
         return;
       }
 
       if (path == '/no-content-length') {
-        response.statusCode = 200;
-        response.contentLength = -1;
-        response.write('body');
-        response.close();
+        response
+          ..statusCode = 200
+          ..contentLength = -1
+          ..write('body')
+          ..close();
         return;
       }
 
@@ -99,9 +103,10 @@ Future startServer() {
         });
 
         var body = json.encode(content);
-        response.contentLength = body.length;
-        response.write(body);
-        response.close();
+        response
+          ..contentLength = body.length
+          ..write(body)
+          ..close();
       });
     });
   });

test/mock_client_test.dart

@@ -31,17 +31,17 @@ void main() {
       return bodyStream.bytesToString().then((bodyString) {
         var controller = StreamController<List<int>>(sync: true);
         Future.sync(() {
-          controller.add('Request body was "$bodyString"'.codeUnits);
-          controller.close();
+          controller
+            ..add('Request body was "$bodyString"'.codeUnits)
+            ..close();
         });
 
         return http.StreamedResponse(controller.stream, 200);
       });
     });
 
     var uri = Uri.parse('http://example.com/foo');
-    var request = http.Request('POST', uri);
-    request.body = 'hello, world';
+    var request = http.Request('POST', uri)..body = 'hello, world';
     var future = client
         .send(request)
         .then(http.Response.fromStream)

test/multipart_test.dart

@@ -203,8 +203,9 @@ void main() {
         --{{boundary}}--
         '''));
 
-    controller.add([104, 101, 108, 108, 111]);
-    controller.close();
+    controller
+      ..add([104, 101, 108, 108, 111])
+      ..close();
   });
 
   test('with an empty stream file', () {