Fix a NPE that occurs when an error occurs before a response is received. (#852)

Author: brianquinlan

pkgs/cronet_http/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.2
+
+* Fix a NPE that occurs when an error occurs before a response is received.
+
 ## 0.1.1
 
 * `CronetClient` throws an exception if `send` is called after `close`.

pkgs/cronet_http/android/src/main/kotlin/io/flutter/plugins/cronet_http/CronetHttpPlugin.kt

@@ -188,7 +188,7 @@ class CronetHttpPlugin : FlutterPlugin, Messages.HttpApi {
 
                 override fun onFailed(
                     request: UrlRequest,
-                    info: UrlResponseInfo,
+                    info: UrlResponseInfo?,
                     error: CronetException
                 ) {
                     mainThreadHandler.post({ eventSink.error("CronetException", error.toString(), null) })

pkgs/cronet_http/example/integration_test/client_test.dart

@@ -9,20 +9,7 @@ import 'package:integration_test/integration_test.dart';
 import 'package:test/test.dart';
 
 void testClientConformance(CronetClient Function() clientFactory) {
-  // TODO: Use `testAll` when `testServerErrors` passes i.e.
-  // testAll(CronetClient(), canStreamRequestBody: false);
-
-  final client = clientFactory();
-  testRequestBody(client);
-  testRequestBodyStreamed(client, canStreamRequestBody: false);
-  testResponseBody(client);
-  testResponseBodyStreamed(client);
-  testRequestHeaders(client);
-  testResponseHeaders(client);
-  testRedirect(client);
-  testCompressedResponseBody(client);
-  testMultipleClients(clientFactory);
-  testClose(clientFactory);
+  testAll(clientFactory, canStreamRequestBody: false);
 }
 
 Future<void> testConformance() async {

pkgs/cronet_http/pubspec.yaml

@@ -1,7 +1,7 @@
 name: cronet_http
 description: >
   An Android Flutter plugin that provides access to the Cronet HTTP client.
-version: 0.1.1
+version: 0.1.2
 repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http
 
 environment:

pkgs/http_client_conformance_tests/lib/src/server_errors_test.dart

@@ -11,8 +11,7 @@ import 'server_errors_server_vm.dart'
     if (dart.library.html) 'server_errors_server_web.dart';
 
 /// Tests that the [Client] correctly handles server errors.
-void testServerErrors(Client client,
-    {bool redirectAlwaysAllowed = false}) async {
+void testServerErrors(Client client, {bool redirectAlwaysAllowed = false}) {
   group('server errors', () {
     late final String host;
     late final StreamChannel<Object?> httpServerChannel;