Always using package:http for APIs and image loading. (#839)

* Always using `package:http` for APIs and image loading.

* Fix changelog notes

Author: brianquinlan

pkgs/cronet_http/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 0.0.4
+
+* Fix a bug where the example would not use the configured `package:http`
+  `Client` for Books API calls in some circumstances.
+* Fix a bug where the images in the example would be loaded using `dart:io`
+  `HttpClient`.
+
 ## 0.0.3
 
 * Fix

pkgs/cronet_http/example/lib/main.dart

@@ -5,6 +5,7 @@
 import 'dart:convert';
 import 'dart:io';
 
+import 'package:cached_network_image/cached_network_image.dart';
 import 'package:cronet_http/cronet_client.dart';
 import 'package:flutter/material.dart';
 import 'package:http/http.dart';
@@ -14,7 +15,6 @@ import 'book.dart';
 void main() {
   var clientFactory = Client.new; // Constructs the default client.
   if (Platform.isAndroid) {
-    WidgetsFlutterBinding.ensureInitialized();
     clientFactory = CronetClient.new;
   }
   runWithClient(() => runApp(const BookSearchApp()), clientFactory);
@@ -122,7 +122,10 @@ class _BookListState extends State<BookList> {
         itemBuilder: (context, index) => Card(
           key: ValueKey(widget.books[index].title),
           child: ListTile(
-            leading: Image.network(widget.books[index].imageUrl),
+            leading: CachedNetworkImage(
+                placeholder: (context, url) =>
+                    const CircularProgressIndicator(),
+                imageUrl: widget.books[index].imageUrl),
             title: Text(widget.books[index].title),
             subtitle: Text(widget.books[index].description),
           ),

pkgs/cronet_http/example/pubspec.yaml

@@ -7,6 +7,7 @@ environment:
   sdk: ">=2.17.5 <3.0.0"
 
 dependencies:
+  cached_network_image: ^3.2.3
   cronet_http:
     path: ../
   cupertino_icons: ^1.0.2

pkgs/cupertino_http/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.0.11
+
+* Fix a bug where the images in the example would be loaded using `dart:io`
+  `HttpClient`.
+
 ## 0.0.10
 
 * Fix [Use of multiple CupertinoClients can result in cancelled requests](https://github.com/dart-lang/http/issues/826)

pkgs/cupertino_http/example/lib/main.dart

@@ -5,6 +5,7 @@
 import 'dart:convert';
 import 'dart:io';
 
+import 'package:cached_network_image/cached_network_image.dart';
 import 'package:cupertino_http/cupertino_client.dart';
 import 'package:flutter/material.dart';
 import 'package:http/http.dart';
@@ -121,7 +122,11 @@ class _BookListState extends State<BookList> {
         itemBuilder: (context, index) => Card(
           key: ValueKey(widget.books[index].title),
           child: ListTile(
-            leading: Image.network(widget.books[index].imageUrl),
+            leading: CachedNetworkImage(
+                placeholder: (context, url) =>
+                    const CircularProgressIndicator(),
+                imageUrl:
+                    widget.books[index].imageUrl.replaceFirst('http', 'https')),
             title: Text(widget.books[index].title),
             subtitle: Text(widget.books[index].description),
           ),

pkgs/cupertino_http/example/pubspec.yaml

@@ -9,6 +9,7 @@ environment:
   sdk: ">=2.17.3 <3.0.0"
 
 dependencies:
+  cached_network_image: ^3.2.3
   cupertino_http:
     path: ../
   cupertino_icons: ^1.0.2