Enable and fix lints, tweak SDK range and description (#272)

Author: kevmoo

.travis.yml

@@ -9,7 +9,13 @@ dart_task:
   # No parallelism on Firefox (-j 1)
   # Causes flakiness – need to investigate
   - test: --platform firefox -j 1
-  - dartanalyzer
+  - dartanalyzer: --fatal-infos --fatal-warnings .
+
+matrix:
+  include:
+  # Only validate formatting using the dev release
+  - dart: dev
+    dart_task: dartfmt
 
 # Only building master means that we don't run two builds for each pull request.
 branches:

analysis_options.yaml

@@ -1 +1,6 @@
 include: package:pedantic/analysis_options.yaml
+linter:
+  rules:
+  - prefer_generic_function_type_aliases
+  - unnecessary_const
+  - unnecessary_new

lib/http.dart

@@ -161,7 +161,7 @@ Future<Uint8List> readBytes(url, {Map<String, String> headers}) =>
     _withClient((client) => client.readBytes(url, headers: headers));
 
 Future<T> _withClient<T>(Future<T> fn(Client client)) async {
-  var client = new Client();
+  var client = Client();
   try {
     return await fn(client);
   } finally {

lib/src/base_client.dart

@@ -150,7 +150,7 @@ abstract class BaseClient implements Client {
       String method, url, Map<String, String> headers,
       [body, Encoding encoding]) async {
     if (url is String) url = Uri.parse(url);
-    var request = new Request(method, url);
+    var request = Request(method, url);
 
     if (headers != null) request.headers.addAll(headers);
     if (encoding != null) request.encoding = encoding;
@@ -162,7 +162,7 @@ abstract class BaseClient implements Client {
       } else if (body is Map) {
         request.bodyFields = body.cast<String, String>();
       } else {
-        throw new ArgumentError('Invalid request body "$body".');
+        throw ArgumentError('Invalid request body "$body".');
       }
     }
 
@@ -177,7 +177,7 @@ abstract class BaseClient implements Client {
       message = "$message: ${response.reasonPhrase}";
     }
     if (url is String) url = Uri.parse(url);
-    throw new ClientException("$message.", url);
+    throw ClientException("$message.", url);
   }
 
   /// Closes the client and cleans up any resources associated with it. It's

lib/src/base_request.dart

@@ -34,7 +34,7 @@ abstract class BaseRequest {
 
   set contentLength(int value) {
     if (value != null && value < 0) {
-      throw new ArgumentError("Invalid content length $value.");
+      throw ArgumentError("Invalid content length $value.");
     }
     _checkFinalized();
     _contentLength = value;
@@ -83,7 +83,7 @@ abstract class BaseRequest {
 
   /// Creates a new HTTP request.
   BaseRequest(this.method, this.url)
-      : headers = new LinkedHashMap(
+      : headers = LinkedHashMap(
             equals: (key1, key2) => key1.toLowerCase() == key2.toLowerCase(),
             hashCode: (key) => key.toLowerCase().hashCode);
 
@@ -98,7 +98,7 @@ abstract class BaseRequest {
   /// change after the request headers are sent.
   ByteStream finalize() {
     // TODO(nweiz): freeze headers
-    if (finalized) throw new StateError("Can't finalize a finalized Request.");
+    if (finalized) throw StateError("Can't finalize a finalized Request.");
     _finalized = true;
     return null;
   }
@@ -110,12 +110,12 @@ abstract class BaseRequest {
   /// the same server, you should use a single [Client] for all of those
   /// requests.
   Future<StreamedResponse> send() async {
-    var client = new Client();
+    var client = Client();
 
     try {
       var response = await client.send(this);
       var stream = onDone(response.stream, client.close);
-      return new StreamedResponse(new ByteStream(stream), response.statusCode,
+      return StreamedResponse(ByteStream(stream), response.statusCode,
           contentLength: response.contentLength,
           request: response.request,
           headers: response.headers,
@@ -131,7 +131,7 @@ abstract class BaseRequest {
   // Throws an error if this request has been finalized.
   void _checkFinalized() {
     if (!finalized) return;
-    throw new StateError("Can't modify a finalized Request.");
+    throw StateError("Can't modify a finalized Request.");
   }
 
   String toString() => "$method $url";

lib/src/base_response.dart

@@ -44,9 +44,9 @@ abstract class BaseResponse {
       this.persistentConnection = true,
       this.reasonPhrase}) {
     if (statusCode < 100) {
-      throw new ArgumentError("Invalid status code $statusCode.");
+      throw ArgumentError("Invalid status code $statusCode.");
     } else if (contentLength != null && contentLength < 0) {
-      throw new ArgumentError("Invalid content length $contentLength.");
+      throw ArgumentError("Invalid content length $contentLength.");
     }
   }
 }

lib/src/boundary_characters.dart

@@ -9,7 +9,7 @@
 ///
 /// [RFC 2046]: http://tools.ietf.org/html/rfc2046#section-5.1.1.
 /// [RFC 1521]: https://tools.ietf.org/html/rfc1521#section-4
-const List<int> BOUNDARY_CHARACTERS = const <int>[
+const List<int> BOUNDARY_CHARACTERS = <int>[
   43,
   95,
   45,

lib/src/browser_client.dart

@@ -29,7 +29,7 @@ class BrowserClient extends BaseClient {
   /// The currently active XHRs.
   ///
   /// These are aborted if the client is closed.
-  final _xhrs = new Set<HttpRequest>();
+  final _xhrs = Set<HttpRequest>();
 
   /// Creates a new HTTP client.
   BrowserClient();
@@ -43,24 +43,24 @@ class BrowserClient extends BaseClient {
   /// Sends an HTTP request and asynchronously returns the response.
   Future<StreamedResponse> send(BaseRequest request) async {
     var bytes = await request.finalize().toBytes();
-    var xhr = new HttpRequest();
+    var xhr = HttpRequest();
     _xhrs.add(xhr);
     _openHttpRequest(xhr, request.method, request.url.toString(), asynch: true);
     xhr.responseType = 'blob';
     xhr.withCredentials = withCredentials;
     request.headers.forEach(xhr.setRequestHeader);
 
-    var completer = new Completer<StreamedResponse>();
+    var completer = Completer<StreamedResponse>();
     unawaited(xhr.onLoad.first.then((_) {
       // TODO(nweiz): Set the response type to "arraybuffer" when issue 18542
       // is fixed.
-      var blob = xhr.response == null ? new Blob([]) : xhr.response;
-      var reader = new FileReader();
+      var blob = xhr.response == null ? Blob([]) : xhr.response;
+      var reader = FileReader();
 
       reader.onLoad.first.then((_) {
         var body = reader.result as Uint8List;
-        completer.complete(new StreamedResponse(
-            new ByteStream.fromBytes(body), xhr.status,
+        completer.complete(StreamedResponse(
+            ByteStream.fromBytes(body), xhr.status,
             contentLength: body.length,
             request: request,
             headers: xhr.responseHeaders,
@@ -69,8 +69,7 @@ class BrowserClient extends BaseClient {
 
       reader.onError.first.then((error) {
         completer.completeError(
-            new ClientException(error.toString(), request.url),
-            StackTrace.current);
+            ClientException(error.toString(), request.url), StackTrace.current);
       });
 
       reader.readAsArrayBuffer(blob);
@@ -80,7 +79,7 @@ class BrowserClient extends BaseClient {
       // Unfortunately, the underlying XMLHttpRequest API doesn't expose any
       // specific information about the error itself.
       completer.completeError(
-          new ClientException("XMLHttpRequest error.", request.url),
+          ClientException("XMLHttpRequest error.", request.url),
           StackTrace.current);
     }));
 

lib/src/byte_stream.dart

@@ -13,13 +13,13 @@ class ByteStream extends StreamView<List<int>> {
   /// Returns a single-subscription byte stream that will emit the given bytes
   /// in a single chunk.
   factory ByteStream.fromBytes(List<int> bytes) =>
-      new ByteStream(new Stream.fromIterable([bytes]));
+      ByteStream(Stream.fromIterable([bytes]));
 
   /// Collects the data of this stream in a [Uint8List].
   Future<Uint8List> toBytes() {
-    var completer = new Completer<Uint8List>();
-    var sink = new ByteConversionSink.withCallback(
-        (bytes) => completer.complete(new Uint8List.fromList(bytes)));
+    var completer = Completer<Uint8List>();
+    var sink = ByteConversionSink.withCallback(
+        (bytes) => completer.complete(Uint8List.fromList(bytes)));
     listen(sink.add,
         onError: completer.completeError,
         onDone: sink.close,

lib/src/io_client.dart

@@ -23,7 +23,7 @@ class IOClient extends BaseClient {
   HttpClient _inner;
 
   /// Creates a new HTTP client.
-  IOClient([HttpClient inner]) : _inner = inner ?? new HttpClient();
+  IOClient([HttpClient inner]) : _inner = inner ?? HttpClient();
 
   /// Sends an HTTP request and asynchronously returns the response.
   Future<StreamedResponse> send(BaseRequest request) async {
@@ -49,9 +49,9 @@ class IOClient extends BaseClient {
         headers[key] = values.join(',');
       });
 
-      return new StreamedResponse(
+      return StreamedResponse(
           DelegatingStream.typed<List<int>>(response).handleError(
-              (error) => throw new ClientException(error.message, error.uri),
+              (error) => throw ClientException(error.message, error.uri),
               test: (error) => error is HttpException),
           response.statusCode,
           contentLength:
@@ -62,7 +62,7 @@ class IOClient extends BaseClient {
           persistentConnection: response.persistentConnection,
           reasonPhrase: response.reasonPhrase);
     } on HttpException catch (error) {
-      throw new ClientException(error.message, error.uri);
+      throw ClientException(error.message, error.uri);
     }
   }