Enable and fix lint annotate_overrides (#305)

Author: natebosch

analysis_options.yaml

@@ -1,6 +1,7 @@
 include: package:pedantic/analysis_options.yaml
 linter:
   rules:
+  - annotate_overrides
   - prefer_generic_function_type_aliases
   - unnecessary_const
   - unnecessary_new

lib/src/base_client.dart

@@ -21,13 +21,15 @@ abstract class BaseClient implements Client {
   /// can be a [Uri] or a [String].
   ///
   /// For more fine-grained control over the request, use [send] instead.
+  @override
   Future<Response> head(url, {Map<String, String> headers}) =>
       _sendUnstreamed("HEAD", url, headers);
 
   /// Sends an HTTP GET request with the given headers to the given URL, which
   /// can be a [Uri] or a [String].
   ///
   /// For more fine-grained control over the request, use [send] instead.
+  @override
   Future<Response> get(url, {Map<String, String> headers}) =>
       _sendUnstreamed("GET", url, headers);
 
@@ -49,6 +51,7 @@ abstract class BaseClient implements Client {
   /// [encoding] defaults to UTF-8.
   ///
   /// For more fine-grained control over the request, use [send] instead.
+  @override
   Future<Response> post(url,
           {Map<String, String> headers, body, Encoding encoding}) =>
       _sendUnstreamed("POST", url, headers, body, encoding);
@@ -71,6 +74,7 @@ abstract class BaseClient implements Client {
   /// [encoding] defaults to UTF-8.
   ///
   /// For more fine-grained control over the request, use [send] instead.
+  @override
   Future<Response> put(url,
           {Map<String, String> headers, body, Encoding encoding}) =>
       _sendUnstreamed("PUT", url, headers, body, encoding);
@@ -93,6 +97,7 @@ abstract class BaseClient implements Client {
   /// [encoding] defaults to UTF-8.
   ///
   /// For more fine-grained control over the request, use [send] instead.
+  @override
   Future<Response> patch(url,
           {Map<String, String> headers, body, Encoding encoding}) =>
       _sendUnstreamed("PATCH", url, headers, body, encoding);
@@ -101,6 +106,7 @@ abstract class BaseClient implements Client {
   /// which can be a [Uri] or a [String].
   ///
   /// For more fine-grained control over the request, use [send] instead.
+  @override
   Future<Response> delete(url, {Map<String, String> headers}) =>
       _sendUnstreamed("DELETE", url, headers);
 
@@ -113,6 +119,7 @@ abstract class BaseClient implements Client {
   ///
   /// For more fine-grained control over the request and response, use [send] or
   /// [get] instead.
+  @override
   Future<String> read(url, {Map<String, String> headers}) {
     return get(url, headers: headers).then((response) {
       _checkResponseSuccess(url, response);
@@ -129,6 +136,7 @@ abstract class BaseClient implements Client {
   ///
   /// For more fine-grained control over the request and response, use [send] or
   /// [get] instead.
+  @override
   Future<Uint8List> readBytes(url, {Map<String, String> headers}) {
     return get(url, headers: headers).then((response) {
       _checkResponseSuccess(url, response);
@@ -143,6 +151,7 @@ abstract class BaseClient implements Client {
   /// state of the stream; it could have data written to it asynchronously at a
   /// later point, or it could already be closed when it's returned. Any
   /// internal HTTP errors should be wrapped as [ClientException]s.
+  @override
   Future<StreamedResponse> send(BaseRequest request);
 
   /// Sends a non-streaming [Request] and returns a non-streaming [Response].
@@ -183,5 +192,6 @@ abstract class BaseClient implements Client {
   /// Closes the client and cleans up any resources associated with it. It's
   /// important to close each client when it's done being used; failing to do so
   /// can cause the Dart process to hang.
+  @override
   void close() {}
 }

lib/src/base_request.dart

@@ -134,5 +134,6 @@ abstract class BaseRequest {
     throw StateError("Can't modify a finalized Request.");
   }
 
-  String toString() => "$method $url";
+  @override
+  String toString() => '$method $url';
 }

lib/src/browser_client.dart

@@ -41,6 +41,7 @@ class BrowserClient extends BaseClient {
   bool withCredentials = false;
 
   /// Sends an HTTP request and asynchronously returns the response.
+  @override
   Future<StreamedResponse> send(BaseRequest request) async {
     var bytes = await request.finalize().toBytes();
     var xhr = HttpRequest();
@@ -101,6 +102,7 @@ class BrowserClient extends BaseClient {
   /// Closes the client.
   ///
   /// This terminates all active requests.
+  @override
   void close() {
     for (var xhr in _xhrs) {
       xhr.abort();

lib/src/exception.dart

@@ -11,5 +11,6 @@ class ClientException implements Exception {
 
   ClientException(this.message, [this.uri]);
 
+  @override
   String toString() => message;
 }

lib/src/io_client.dart

@@ -26,6 +26,7 @@ class IOClient extends BaseClient {
   IOClient([HttpClient inner]) : _inner = inner ?? HttpClient();
 
   /// Sends an HTTP request and asynchronously returns the response.
+  @override
   Future<StreamedResponse> send(BaseRequest request) async {
     var stream = request.finalize();
 
@@ -68,6 +69,7 @@ class IOClient extends BaseClient {
 
   /// Closes the client. This terminates all active connections. If a client
   /// remains unclosed, the Dart process may not terminate.
+  @override
   void close() {
     if (_inner != null) _inner.close(force: true);
     _inner = null;

lib/src/mock_client.dart

@@ -67,6 +67,7 @@ class MockClient extends BaseClient {
         });
 
   /// Sends a request.
+  @override
   Future<StreamedResponse> send(BaseRequest request) async {
     var bodyStream = request.finalize();
     return await _handler(request, bodyStream);

lib/src/multipart_request.dart

@@ -53,6 +53,7 @@ class MultipartRequest extends BaseRequest {
   /// The total length of the request body, in bytes.
   ///
   /// This is calculated from [fields] and [files] and cannot be set manually.
+  @override
   int get contentLength {
     var length = 0;
 
@@ -77,13 +78,15 @@ class MultipartRequest extends BaseRequest {
     return length + "--".length + _boundaryLength + "--\r\n".length;
   }
 
+  @override
   set contentLength(int value) {
     throw UnsupportedError("Cannot set the contentLength property of "
         "multipart requests.");
   }
 
   /// Freezes all mutable fields and returns a single-subscription [ByteStream]
   /// that will emit the request body.
+  @override
   ByteStream finalize() {
     // TODO(nweiz): freeze fields and files
     var boundary = _boundaryString();

lib/src/request.dart

@@ -18,8 +18,10 @@ class Request extends BaseRequest {
   ///
   /// The content length cannot be set for [Request], since it's automatically
   /// calculated from [bodyBytes].
+  @override
   int get contentLength => bodyBytes.length;
 
+  @override
   set contentLength(int value) {
     throw UnsupportedError("Cannot set the contentLength property of "
         "non-streaming Request objects.");
@@ -136,6 +138,7 @@ class Request extends BaseRequest {
 
   /// Freezes all mutable fields and returns a single-subscription [ByteStream]
   /// containing the request body.
+  @override
   ByteStream finalize() {
     super.finalize();
     return ByteStream.fromBytes(bodyBytes);

lib/src/streamed_request.dart

@@ -34,6 +34,7 @@ class StreamedRequest extends BaseRequest {
   /// Freezes all mutable fields other than [stream] and returns a
   /// single-subscription [ByteStream] that emits the data being written to
   /// [sink].
+  @override
   ByteStream finalize() {
     super.finalize();
     return ByteStream(_controller.stream);