Enabled and fix a number of lints (#478)

Author: kevmoo

analysis_options.yaml

@@ -10,11 +10,14 @@ linter:
   rules:
   - annotate_overrides
   - avoid_bool_literals_in_conditional_expressions
+  - avoid_catching_errors
   - avoid_classes_with_only_static_members
   - avoid_empty_else
   - avoid_function_literals_in_foreach_calls
   - avoid_init_to_null
   - avoid_null_checks_in_equality_operators
+  - avoid_private_typedef_functions
+  - avoid_redundant_argument_values
   - avoid_relative_lib_imports
   - avoid_renaming_method_parameters
   - avoid_return_types_on_setters
@@ -28,6 +31,7 @@ linter:
   - camel_case_types
   - cascade_invocations
   # comment_references
+  - constant_identifier_names
   - control_flow_in_finally
   - curly_braces_in_flow_control_structures
   - directives_ordering
@@ -36,13 +40,18 @@ linter:
   - empty_statements
   - file_names
   - hash_and_equals
+  - implementation_imports
   - invariant_booleans
   - iterable_contains_unrelated_type
+  - join_return_with_assignment
   - library_names
   - library_prefixes
+  - lines_longer_than_80_chars
   - list_remove_unrelated_type
+  - missing_whitespace_between_adjacent_strings
   - no_adjacent_strings_in_list
   - no_duplicate_case_values
+  - no_runtimeType_toString
   - non_constant_identifier_names
   - null_closures
   - omit_local_variable_types
@@ -51,22 +60,36 @@ linter:
   - package_names
   - package_prefixed_library_names
   - prefer_adjacent_string_concatenation
+  - prefer_asserts_in_initializer_lists
+  - prefer_collection_literals
   - prefer_conditional_assignment
+  - prefer_const_constructors
+  - prefer_const_declarations
   - prefer_contains
   - prefer_equal_for_default_values
+  - prefer_expression_function_bodies
   - prefer_final_fields
-  - prefer_collection_literals
+  #- prefer_final_locals
+  - prefer_function_declarations_over_variables
   - prefer_generic_function_type_aliases
   - prefer_initializing_formals
+  - prefer_inlined_adds
+  - prefer_interpolation_to_compose_strings
   - prefer_is_empty
   - prefer_is_not_empty
+  - prefer_is_not_operator
   - prefer_null_aware_operators
+  - prefer_relative_imports
   - prefer_single_quotes
   - prefer_typing_uninitialized_variables
+  - prefer_void_to_null
+  - provide_deprecation_message
   - recursive_getters
   - slash_for_doc_comments
+  - sort_pub_dependencies
   - test_types_in_equals
   - throw_in_finally
+  - type_annotate_public_apis
   - type_init_formals
   - unawaited_futures
   - unnecessary_brace_in_string_interps
@@ -79,8 +102,11 @@ linter:
   - unnecessary_overrides
   - unnecessary_parenthesis
   - unnecessary_statements
+  - unnecessary_string_interpolations
   - unnecessary_this
   - unrelated_type_equality_checks
+  - use_is_even_rather_than_modulo
   - use_rethrow_when_possible
+  - use_string_buffers
   - valid_regexps
   - void_checks

lib/src/boundary_characters.dart

@@ -10,7 +10,7 @@
 ///
 /// [RFC 2046]: http://tools.ietf.org/html/rfc2046#section-5.1.1.
 /// [RFC 1521]: https://tools.ietf.org/html/rfc1521#section-4
-const List<int> BOUNDARY_CHARACTERS = <int>[
+const List<int> boundaryCharacters = <int>[
   43,
   95,
   45,

lib/src/multipart_request.dart

@@ -141,22 +141,21 @@ class MultipartRequest extends BaseRequest {
   }
 
   /// Encode [value] in the same way browsers do.
-  String _browserEncode(String value) {
-    // http://tools.ietf.org/html/rfc2388 mandates some complex encodings for
-    // field names and file names, but in practice user agents seem not to
-    // follow this at all. Instead, they URL-encode `\r`, `\n`, and `\r\n` as
-    // `\r\n`; URL-encode `"`; and do nothing else (even for `%` or non-ASCII
-    // characters). We follow their behavior.
-    return value.replaceAll(_newlineRegExp, '%0D%0A').replaceAll('"', '%22');
-  }
+  String _browserEncode(String value) =>
+      // http://tools.ietf.org/html/rfc2388 mandates some complex encodings for
+      // field names and file names, but in practice user agents seem not to
+      // follow this at all. Instead, they URL-encode `\r`, `\n`, and `\r\n` as
+      // `\r\n`; URL-encode `"`; and do nothing else (even for `%` or non-ASCII
+      // characters). We follow their behavior.
+      value.replaceAll(_newlineRegExp, '%0D%0A').replaceAll('"', '%22');
 
   /// Returns a randomly-generated multipart boundary string
   String _boundaryString() {
     var prefix = 'dart-http-boundary-';
     var list = List<int>.generate(
         _boundaryLength - prefix.length,
         (index) =>
-            BOUNDARY_CHARACTERS[_random.nextInt(BOUNDARY_CHARACTERS.length)],
+            boundaryCharacters[_random.nextInt(boundaryCharacters.length)],
         growable: false);
     return '$prefix${String.fromCharCodes(list)}';
   }

test/io/utils.dart

@@ -115,7 +115,8 @@ void stopServer() {
 }
 
 /// A matcher for functions that throw HttpException.
-Matcher get throwsClientException => throwsA(TypeMatcher<ClientException>());
+Matcher get throwsClientException =>
+    throwsA(const TypeMatcher<ClientException>());
 
 /// A matcher for functions that throw SocketException.
 final Matcher throwsSocketException =

test/multipart_test.dart

@@ -20,7 +20,7 @@ void main() {
   });
 
   test('boundary characters', () {
-    var testBoundary = String.fromCharCodes(BOUNDARY_CHARACTERS);
+    var testBoundary = String.fromCharCodes(boundaryCharacters);
     var contentType = MediaType.parse('text/plain; boundary=$testBoundary');
     var boundary = contentType.parameters['boundary'];
     expect(boundary, testBoundary);

test/utils.dart

@@ -63,11 +63,8 @@ class _Parse extends Matcher {
   }
 
   @override
-  Description describe(Description description) {
-    return description
-        .add('parses to a value that ')
-        .addDescriptionOf(_matcher);
-  }
+  Description describe(Description description) =>
+      description.add('parses to a value that ').addDescriptionOf(_matcher);
 }
 
 /// A matcher that validates the body of a multipart request after finalization.
@@ -105,14 +102,13 @@ class _BodyMatches extends Matcher {
   }
 
   @override
-  Description describe(Description description) {
-    return description.add('has a body that matches "$_pattern"');
-  }
+  Description describe(Description description) =>
+      description.add('has a body that matches "$_pattern"');
 }
 
 /// A matcher that matches function or future that throws a
 /// [http.ClientException] with the given [message].
 ///
 /// [message] can be a String or a [Matcher].
-Matcher throwsClientException(message) => throwsA(
+Matcher throwsClientException(String message) => throwsA(
     isA<http.ClientException>().having((e) => e.message, 'message', message));