Remove implicit casts (#344)

Author: kevmoo

analysis_options.yaml

@@ -1,4 +1,7 @@
 include: package:pedantic/analysis_options.yaml
+analyzer:
+  strong-mode:
+    implicit-casts: false
 linter:
   rules:
   - annotate_overrides

lib/src/base_client.dart

@@ -157,8 +157,7 @@ abstract class BaseClient implements Client {
   Future<Response> _sendUnstreamed(
       String method, url, Map<String, String> headers,
       [body, Encoding encoding]) async {
-    if (url is String) url = Uri.parse(url);
-    var request = Request(method, url);
+    var request = Request(method, _fromUriOrString(url));
 
     if (headers != null) request.headers.addAll(headers);
     if (encoding != null) request.encoding = encoding;
@@ -184,8 +183,7 @@ abstract class BaseClient implements Client {
     if (response.reasonPhrase != null) {
       message = '$message: ${response.reasonPhrase}';
     }
-    if (url is String) url = Uri.parse(url);
-    throw ClientException('$message.', url);
+    throw ClientException('$message.', _fromUriOrString(url));
   }
 
   /// Closes the client and cleans up any resources associated with it.
@@ -195,3 +193,5 @@ abstract class BaseClient implements Client {
   @override
   void close() {}
 }
+
+Uri _fromUriOrString(uri) => uri is String ? Uri.parse(uri) : uri as Uri;

lib/src/browser_client.dart

@@ -55,7 +55,7 @@ class BrowserClient extends BaseClient {
     unawaited(xhr.onLoad.first.then((_) {
       // TODO(nweiz): Set the response type to "arraybuffer" when issue 18542
       // is fixed.
-      var blob = xhr.response ?? Blob([]);
+      var blob = xhr.response as Blob ?? Blob([]);
       var reader = FileReader();
 
       reader.onLoad.first.then((_) {

lib/src/io_client.dart

@@ -40,15 +40,18 @@ class IOClient extends BaseClient {
       });
 
       var response =
-          await stream.pipe(DelegatingStreamConsumer.typed(ioRequest));
+          await stream.pipe(DelegatingStreamConsumer.typed(ioRequest))
+              as HttpClientResponse;
+
       var headers = <String, String>{};
       response.headers.forEach((key, values) {
         headers[key] = values.join(',');
       });
 
       return StreamedResponse(
           DelegatingStream.typed<List<int>>(response).handleError(
-              (error) => throw ClientException(error.message, error.uri),
+              (HttpException error) =>
+                  throw ClientException(error.message, error.uri),
               test: (error) => error is HttpException),
           response.statusCode,
           contentLength:

test/utils.dart

@@ -40,7 +40,7 @@ String cleanUpLiteral(String text) {
 
 /// A matcher that matches JSON that parses to a value that matches the inner
 /// matcher.
-Matcher parse(matcher) => _Parse(matcher);
+Matcher parse(Matcher matcher) => _Parse(matcher);
 
 class _Parse extends Matcher {
   final Matcher _matcher;
@@ -49,16 +49,17 @@ class _Parse extends Matcher {
 
   @override
   bool matches(item, Map matchState) {
-    if (item is! String) return false;
-
-    dynamic parsed;
-    try {
-      parsed = json.decode(item);
-    } catch (e) {
-      return false;
+    if (item is String) {
+      dynamic parsed;
+      try {
+        parsed = json.decode(item);
+      } catch (e) {
+        return false;
+      }
+
+      return _matcher.matches(parsed, matchState);
     }
-
-    return _matcher.matches(parsed, matchState);
+    return false;
   }
 
   @override
@@ -83,9 +84,11 @@ class _BodyMatches extends Matcher {
 
   @override
   bool matches(item, Map matchState) {
-    if (item is! http.MultipartRequest) return false;
+    if (item is http.MultipartRequest) {
+      return completes.matches(_checks(item), matchState);
+    }
 
-    return completes.matches(_checks(item), matchState);
+    return false;
   }
 
   Future<void> _checks(http.MultipartRequest item) async {