Move conformance test invocation into package:http (#718)

Author: brianquinlan

.github/workflows/dart.yml

@@ -14,6 +14,8 @@ dependencies:
 
 dev_dependencies:
   fake_async: ^1.2.0
+  http_client_conformance_tests:
+    path: ../http_client_conformance_tests/
   lints: ^1.0.0
   shelf: ^1.1.0
   stream_channel: ^2.1.0

pkgs/http/pubspec.yaml

@@ -11,10 +11,8 @@ import 'package:test/test.dart';
 void main() {
   final client = BrowserClient();
 
-  group('testAll', () {
-    testAll(client,
-        redirectAlwaysAllowed: true,
-        canStreamRequestBody: false,
-        canStreamResponseBody: false);
-  });
+  testAll(client,
+      redirectAlwaysAllowed: true,
+      canStreamRequestBody: false,
+      canStreamResponseBody: false);
 }

pkgs/http_client_conformance_tests/test/browser_client_test.dart renamed to pkgs/http/test/html/client_conformance_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-@TestOn('!js')
+@TestOn('vm')
 
 import 'package:http/io_client.dart';
 import 'package:http_client_conformance_tests/http_client_conformance_tests.dart';
@@ -11,7 +11,5 @@ import 'package:test/test.dart';
 void main() {
   final client = IOClient();
 
-  group('testAll', () {
-    testAll(client);
-  });
+  testAll(client);
 }

pkgs/http_client_conformance_tests/test/io_client_test.dart renamed to pkgs/http/test/io/client_conformance_test.dart

@@ -34,3 +34,6 @@ void main() {
   });
 }
 ```
+
+**Note**: This package does not have it's own tests, instead it is
+exercised by the tests in `package:http`.

pkgs/http_client_conformance_tests/README.md

@@ -1,4 +1,6 @@
-import 'dart:isolate';
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
 
 import 'package:stream_channel/stream_channel.dart';
 import 'package:test/test.dart';
@@ -7,20 +9,7 @@ import 'package:test/test.dart';
 /// 'redirect_server.dart'.
 ///
 /// See [spawnHybridUri].
-Future<StreamChannel<Object?>> startServer(String fileName) async {
-  try {
-    final fileUri = await Isolate.resolvePackageUri(Uri(
+Future<StreamChannel<Object?>> startServer(String fileName) async =>
+    spawnHybridUri(Uri(
         scheme: 'package',
         path: 'http_client_conformance_tests/src/$fileName'));
-    if (fileUri == null) {
-      throw StateError('The package could not be resolved');
-    }
-    return spawnHybridUri(fileUri);
-    // ignore: avoid_catching_errors
-  } on UnsupportedError {
-    // The current runtime environment (probably browser) does not support
-    // `Isolate.resolvePackageUri` so try to use a relative path. This will
-    // *not* work if `http_client_conformance_tests` is used as a package.
-    return spawnHybridUri('../lib/src/$fileName');
-  }
-}

pkgs/http_client_conformance_tests/lib/src/utils.dart

@@ -8,10 +8,3 @@ stages:
   - format:
     sdk:
     - dev
-- unit_test:
-  - test: --platform vm
-    os:
-    - linux
-  - test: --platform chrome
-    os:
-    - linux

pkgs/http_client_conformance_tests/mono_pkg.yaml

@@ -11,7 +11,7 @@ environment:
 dependencies:
   async: ^2.8.2
   http: ^0.13.4
-  test: ^1.21.1
+  test: ^1.21.2
 
 dev_dependencies:
   lints: ^1.0.0