Set StreamedResponse.reasonPhrase and StreamedResponse.request (#784)

Author: brianquinlan

pkgs/cronet_http/.gitattributes

@@ -1,3 +1,4 @@
 # pigeon generated code
 lib/src/messages.dart linguist-generated
-android/src/main/java/io/flutter/plugins/cronet_http/Messages.java
+android/src/main/java/io/flutter/plugins/cronet_http/Messages.java linguist-generated
+

pkgs/cronet_http/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.0.2
+
+* Set `StreamedResponse.reasonPhrase` and `StreamedResponse.request`. 
+
 ## 0.0.1
 
 * Initial development release.

pkgs/cronet_http/android/src/main/java/io/flutter/plugins/cronet_http/Messages.java

@@ -115,6 +115,7 @@ class CronetHttpPlugin : FlutterPlugin, Messages.HttpApi {
                                     .setResponseStarted(
                                         Messages.ResponseStarted.Builder()
                                             .setStatusCode(info.getHttpStatusCode().toLong())
+                                            .setStatusText(info.getHttpStatusText())
                                             .setHeaders(info.getAllHeaders())
                                             .setIsRedirect(true)
                                             .build()
@@ -148,6 +149,7 @@ class CronetHttpPlugin : FlutterPlugin, Messages.HttpApi {
                                 .setResponseStarted(
                                     Messages.ResponseStarted.Builder()
                                         .setStatusCode(info.getHttpStatusCode().toLong())
+                                        .setStatusText(info.getHttpStatusText())
                                         .setHeaders(info.getAllHeaders())
                                         .setIsRedirect(false)
                                         .build()

pkgs/cronet_http/android/src/main/kotlin/io/flutter/plugins/cronet_http/CronetHttpPlugin.kt

@@ -208,6 +208,8 @@ class CronetClient extends BaseClient {
 
     return StreamedResponse(responseDataController.stream, result.statusCode,
         contentLength: responseHeaders['content-lenght'] as int?,
+        reasonPhrase: result.statusText,
+        request: request,
         isRedirect: result.isRedirect,
         headers: responseHeaders);
   }

pkgs/cronet_http/lib/cronet_client.dart

@@ -24,6 +24,7 @@ enum CacheMode {
 class ResponseStarted {
   Map<String?, List<String?>?> headers;
   int statusCode;
+  String statusText;
   bool isRedirect;
 }
 

pkgs/cronet_http/lib/src/messages.dart

@@ -2,6 +2,9 @@
 
 * Add the ability to set network service type.
 * Add the ability to control multipath TCP connections.
+* Set `StreamedResponse.reasonPhrase` and `StreamedResponse.request`. 
+  Fixes
+  [cupertino_http: BaseResponse.request is null](https://github.com/dart-lang/http/issues/782).
 
 ## 0.0.4
 

pkgs/cronet_http/pigeons/messages.dart

@@ -6,6 +6,7 @@
 /// [Foundation URL Loading System](https://developer.apple.com/documentation/foundation/url_loading_system).
 
 import 'dart:async';
+import 'dart:io';
 import 'dart:typed_data';
 
 import 'package:http/http.dart';
@@ -55,6 +56,93 @@ class CupertinoClient extends BaseClient {
 
   CupertinoClient._(this._urlSession);
 
+  String? _findReasonPhrase(int statusCode) {
+    switch (statusCode) {
+      case HttpStatus.continue_:
+        return 'Continue';
+      case HttpStatus.switchingProtocols:
+        return 'Switching Protocols';
+      case HttpStatus.ok:
+        return 'OK';
+      case HttpStatus.created:
+        return 'Created';
+      case HttpStatus.accepted:
+        return 'Accepted';
+      case HttpStatus.nonAuthoritativeInformation:
+        return 'Non-Authoritative Information';
+      case HttpStatus.noContent:
+        return 'No Content';
+      case HttpStatus.resetContent:
+        return 'Reset Content';
+      case HttpStatus.partialContent:
+        return 'Partial Content';
+      case HttpStatus.multipleChoices:
+        return 'Multiple Choices';
+      case HttpStatus.movedPermanently:
+        return 'Moved Permanently';
+      case HttpStatus.found:
+        return 'Found';
+      case HttpStatus.seeOther:
+        return 'See Other';
+      case HttpStatus.notModified:
+        return 'Not Modified';
+      case HttpStatus.useProxy:
+        return 'Use Proxy';
+      case HttpStatus.temporaryRedirect:
+        return 'Temporary Redirect';
+      case HttpStatus.badRequest:
+        return 'Bad Request';
+      case HttpStatus.unauthorized:
+        return 'Unauthorized';
+      case HttpStatus.paymentRequired:
+        return 'Payment Required';
+      case HttpStatus.forbidden:
+        return 'Forbidden';
+      case HttpStatus.notFound:
+        return 'Not Found';
+      case HttpStatus.methodNotAllowed:
+        return 'Method Not Allowed';
+      case HttpStatus.notAcceptable:
+        return 'Not Acceptable';
+      case HttpStatus.proxyAuthenticationRequired:
+        return 'Proxy Authentication Required';
+      case HttpStatus.requestTimeout:
+        return 'Request Time-out';
+      case HttpStatus.conflict:
+        return 'Conflict';
+      case HttpStatus.gone:
+        return 'Gone';
+      case HttpStatus.lengthRequired:
+        return 'Length Required';
+      case HttpStatus.preconditionFailed:
+        return 'Precondition Failed';
+      case HttpStatus.requestEntityTooLarge:
+        return 'Request Entity Too Large';
+      case HttpStatus.requestUriTooLong:
+        return 'Request-URI Too Long';
+      case HttpStatus.unsupportedMediaType:
+        return 'Unsupported Media Type';
+      case HttpStatus.requestedRangeNotSatisfiable:
+        return 'Requested range not satisfiable';
+      case HttpStatus.expectationFailed:
+        return 'Expectation Failed';
+      case HttpStatus.internalServerError:
+        return 'Internal Server Error';
+      case HttpStatus.notImplemented:
+        return 'Not Implemented';
+      case HttpStatus.badGateway:
+        return 'Bad Gateway';
+      case HttpStatus.serviceUnavailable:
+        return 'Service Unavailable';
+      case HttpStatus.gatewayTimeout:
+        return 'Gateway Time-out';
+      case HttpStatus.httpVersionNotSupported:
+        return 'Http Version not supported';
+      default:
+        return null;
+    }
+  }
+
   static _TaskTracker _tracker(URLSessionTask task) =>
       _tasks[task.taskIdentifier]!;
 
@@ -164,6 +252,8 @@ class CupertinoClient extends BaseClient {
       contentLength: response.expectedContentLength == -1
           ? null
           : response.expectedContentLength,
+      reasonPhrase: _findReasonPhrase(response.statusCode),
+      request: request,
       isRedirect: !request.followRedirects && taskTracker.numRedirects > 0,
       headers: response.allHeaderFields
           .map((key, value) => MapEntry(key.toLowerCase(), value)),

pkgs/cupertino_http/CHANGELOG.md

@@ -51,6 +51,10 @@ void testResponseBodyStreamed(Client client,
       });
       expect(response.headers['content-type'], 'text/plain');
       expect(lastReceived, greaterThanOrEqualTo(1000));
+      expect(response.isRedirect, isFalse);
+      expect(response.reasonPhrase, 'OK');
+      expect(response.request!.method, 'GET');
+      expect(response.statusCode, 200);
     }, skip: canStreamResponseBody ? false : 'does not stream response bodies');
   });
 }