Skip to content

Commit e4b936c

Browse files
authored
Remove upper case constants (#4)
* Remove usage of upper-case constants. * update SDK version * remove stable from Travis config
1 parent 405395b commit e4b936c

File tree

4 files changed

+19
-17
lines changed

4 files changed

+19
-17
lines changed

.travis.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ language: dart
77

88
dart:
99
- dev
10-
- stable
11-
1210
# See https://docs.travis-ci.com/user/languages/dart/ for details.
1311
dart_task:
1412
- test: --platform vm
@@ -19,7 +17,7 @@ dart_task:
1917
# them against each Dart version.
2018
matrix:
2119
include:
22-
- dart: stable
20+
- dart: dev
2321
dart_task: dartfmt
2422
- dart: dev
2523
dart_task: dartanalyzer

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.1.1+1
2+
3+
* Updated SDK version to 2.0.0-dev.17.0
4+
15
## 0.1.1
26

37
* Add a `whenError()` parameter to allow requests to be retried when they

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
name: http_retry
2-
version: 0.1.1
2+
version: 0.1.1+1
33
description: HTTP client middleware that automatically retries requests.
44
author: Dart Team <[email protected]>
55
homepage: https://github.com/dart-lang/http_retry
66

77
environment:
8-
sdk: '>=1.24.0 <2.0.0'
8+
sdk: '>=2.0.0-dev.17.0 <2.0.0'
99

1010
dependencies:
1111
async: ">=1.2.0 <=3.0.0"

test/http_retry_test.dart

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void main() {
4444
count++;
4545
return count < 2 ? new Response("", 503) : new Response("", 200);
4646
}, count: 2)),
47-
delay: (_) => Duration.ZERO);
47+
delay: (_) => Duration.zero);
4848

4949
var response = await client.get("http://example.org");
5050
expect(response.statusCode, equals(200));
@@ -59,7 +59,7 @@ void main() {
5959
headers: {"retry": count < 2 ? "true" : "false"});
6060
}, count: 2)),
6161
when: (response) => response.headers["retry"] == "true",
62-
delay: (_) => Duration.ZERO);
62+
delay: (_) => Duration.zero);
6363

6464
var response = await client.get("http://example.org");
6565
expect(response.headers, containsPair("retry", "false"));
@@ -75,7 +75,7 @@ void main() {
7575
return new Response("", 200);
7676
}, count: 2)),
7777
whenError: (error, _) => error == "oh no",
78-
delay: (_) => Duration.ZERO);
78+
delay: (_) => Duration.zero);
7979

8080
var response = await client.get("http://example.org");
8181
expect(response.statusCode, equals(200));
@@ -86,7 +86,7 @@ void main() {
8686
var client = new RetryClient(
8787
new MockClient(expectAsync1((request) async => throw "oh no")),
8888
whenError: (error, _) => error == "oh yeah",
89-
delay: (_) => Duration.ZERO);
89+
delay: (_) => Duration.zero);
9090

9191
expect(client.get("http://example.org"), throwsA("oh no"));
9292
});
@@ -95,7 +95,7 @@ void main() {
9595
var client = new RetryClient(
9696
new MockClient(
9797
expectAsync1((_) async => new Response("", 503), count: 4)),
98-
delay: (_) => Duration.ZERO);
98+
delay: (_) => Duration.zero);
9999
var response = await client.get("http://example.org");
100100
expect(response.statusCode, equals(503));
101101
});
@@ -105,7 +105,7 @@ void main() {
105105
new MockClient(
106106
expectAsync1((_) async => new Response("", 503), count: 13)),
107107
retries: 12,
108-
delay: (_) => Duration.ZERO);
108+
delay: (_) => Duration.zero);
109109
var response = await client.get("http://example.org");
110110
expect(response.statusCode, equals(503));
111111
});
@@ -116,7 +116,7 @@ void main() {
116116
var client = new RetryClient(new MockClient(expectAsync1((_) async {
117117
count++;
118118
if (count == 1) {
119-
expect(fake.elapsed, equals(Duration.ZERO));
119+
expect(fake.elapsed, equals(Duration.zero));
120120
} else if (count == 2) {
121121
expect(fake.elapsed, equals(new Duration(milliseconds: 500)));
122122
} else if (count == 3) {
@@ -140,9 +140,9 @@ void main() {
140140
new MockClient(expectAsync1((_) async {
141141
count++;
142142
if (count == 1) {
143-
expect(fake.elapsed, equals(Duration.ZERO));
143+
expect(fake.elapsed, equals(Duration.zero));
144144
} else if (count == 2) {
145-
expect(fake.elapsed, equals(Duration.ZERO));
145+
expect(fake.elapsed, equals(Duration.zero));
146146
} else if (count == 3) {
147147
expect(fake.elapsed, equals(new Duration(seconds: 1)));
148148
} else if (count == 4) {
@@ -165,7 +165,7 @@ void main() {
165165
new MockClient(expectAsync1((_) async {
166166
count++;
167167
if (count == 1) {
168-
expect(fake.elapsed, equals(Duration.ZERO));
168+
expect(fake.elapsed, equals(Duration.zero));
169169
} else if (count == 2) {
170170
expect(fake.elapsed, equals(new Duration(seconds: 1)));
171171
} else if (count == 3) {
@@ -193,7 +193,7 @@ void main() {
193193
new MockClient(
194194
expectAsync1((_) async => new Response("", 503), count: 3)),
195195
retries: 2,
196-
delay: (_) => Duration.ZERO,
196+
delay: (_) => Duration.zero,
197197
onRetry: expectAsync3((request, response, retryCount) {
198198
expect(request.url, equals(Uri.parse("http://example.org")));
199199
expect(response.statusCode, equals(503));
@@ -217,7 +217,7 @@ void main() {
217217
expect(request.body, equals("hello"));
218218
return new Response("", 503);
219219
}, count: 2)),
220-
[Duration.ZERO]);
220+
[Duration.zero]);
221221

222222
var request = new Request("POST", Uri.parse("http://example.org"));
223223
request.body = "hello";

0 commit comments

Comments
 (0)