Skip to content

Commit 05a3b34

Browse files
authored
Merge pull request dart-archive/appengine#147 from dart-lang/mit-mit-patch-1
Update tests to prepare for old command discontinuations
2 parents 58d45c8 + fdd8f2e commit 05a3b34

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

pkgs/appengine/tool/run_tests.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ export PATH="$PATH:$DART_SDK/bin"
2020
export RETURN_VALUE=0
2121

2222
start_phase "Analyzing"
23-
analyze_files $(find $REPO_ROOT/lib -name "*.dart")
23+
dart analyze lib
2424
RETURN_VALUE=$(expr $RETURN_VALUE + $?)
2525

26-
analyze_files $(find $REPO_ROOT/test -name '*.dart')
26+
dart analyze test
2727
RETURN_VALUE=$(expr $RETURN_VALUE + $?)
2828

2929
start_phase "Starting API server"
@@ -34,7 +34,7 @@ sleep 3
3434

3535

3636
start_phase "Testing"
37-
pub run test
37+
dart pub run test
3838
RETURN_VALUE=$(expr $RETURN_VALUE + $?)
3939

4040
start_phase "Killing API server"

pkgs/appengine/tool/utils.sh

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,6 @@ function check_env_variable {
2525
fi
2626
}
2727

28-
function analyze_files {
29-
echo "Analyzing files '$1'."
30-
31-
"$DART_SDK/bin/dartanalyzer" --fatal-warnings "$@"
32-
if [ $? -ne 0 ]; then
33-
error "Analyzer failed on file '$1'."
34-
return 1
35-
fi
36-
return 0
37-
}
38-
3928
function test_file {
4029
echo "Testing file '$1'."
4130
"$DART_SDK/bin/dart" --checked "$1"

0 commit comments

Comments
 (0)