Skip to content

Commit c927de4

Browse files
authored
Drop unneeded directives and redundant type checks (dart-archive/gcloud#126)
Fixes CI
1 parent 6465656 commit c927de4

File tree

5 files changed

+1
-10
lines changed

5 files changed

+1
-10
lines changed

pkgs/gcloud/lib/db.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
library gcloud.db;
66

7-
import 'dart:async';
87
import 'dart:collection';
98
// dart:core is imported explicitly so it is available at top-level without
109
// the `core` prefix defined below.
@@ -23,9 +22,9 @@ import 'service_scope.dart' as ss;
2322
part 'src/db/annotations.dart';
2423
part 'src/db/db.dart';
2524
part 'src/db/exceptions.dart';
26-
part 'src/db/models.dart';
2725
part 'src/db/model_db.dart';
2826
part 'src/db/model_db_impl.dart';
27+
part 'src/db/models.dart';
2928

3029
const Symbol _dbKey = #gcloud.db;
3130

pkgs/gcloud/test/datastore/e2e/datastore_test_impl.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ void runTests(Datastore datastore, String? namespace) {
110110
if (key.elements.isEmpty) return false;
111111

112112
for (var element in key.elements) {
113-
if (element.kind is! String) return false;
114113
if (!ignoreIds) {
115114
if (element.id == null ||
116115
(element.id is! String && element.id is! int)) {

pkgs/gcloud/test/db/e2e/metamodel_test_impl.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ library metamodel_test;
77
import 'dart:async';
88

99
import 'package:gcloud/datastore.dart';
10-
import 'package:gcloud/datastore.dart' show Key, Partition;
1110
import 'package:gcloud/db.dart' as db;
1211
import 'package:gcloud/db/metamodel.dart';
1312
import 'package:test/test.dart';

pkgs/gcloud/test/storage/e2e_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ void main() {
6767
return storage.bucketInfo(bucketName).then(expectAsync1((info) {
6868
expect(info.bucketName, bucketName);
6969
expect(info.etag, isNotNull);
70-
expect(info.created is DateTime, isTrue);
7170
expect(info.id, isNotNull);
7271
return storage.deleteBucket(bucketName).then(expectAsync1((result) {
7372
expect(result, isNull);
@@ -233,10 +232,8 @@ void main() {
233232
return bucket.info(objectName).then(expectAsync1((info) {
234233
expect(info.name, objectName);
235234
expect(info.length, bytes.length);
236-
expect(info.updated is DateTime, isTrue);
237235
expect(info.md5Hash, isNotNull);
238236
expect(info.crc32CChecksum, isNotNull);
239-
expect(info.downloadLink is Uri, isTrue);
240237
expect(info.generation.objectGeneration, isNotNull);
241238
expect(info.generation.metaGeneration, 1);
242239
expect(info.metadata.contentType, metadata.contentType);

pkgs/gcloud/test/storage/storage_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,11 +1013,8 @@ void main() {
10131013
bucket.info(objectName).then(expectAsync1((ObjectInfo info) {
10141014
expect(info.name, objectName);
10151015
expect(info.metadata.acl!.entries.length, 3);
1016-
expect(info.metadata.acl!.entries[0] is AclEntry, isTrue);
10171016
expect(info.metadata.acl!.entries[0].scope is StorageIdScope, isTrue);
1018-
expect(info.metadata.acl!.entries[1] is AclEntry, isTrue);
10191017
expect(info.metadata.acl!.entries[1].scope is AccountScope, isTrue);
1020-
expect(info.metadata.acl!.entries[2] is AclEntry, isTrue);
10211018
expect(info.metadata.acl!.entries[2].scope is OpaqueScope, isTrue);
10221019
}));
10231020
});

0 commit comments

Comments
 (0)