Skip to content

Commit 24194ed

Browse files
authored
Fix typos in finalization registry
1 parent 6f69a38 commit 24194ed

File tree

1 file changed

+2
-2
lines changed
  • accepted/future-releases/1847 - FinalizationRegistry

1 file changed

+2
-2
lines changed

accepted/future-releases/1847 - FinalizationRegistry/proposal.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ should be able to:
9696
- rely on finalization callbacks to be invoked even if an isolate group is
9797
shutting down.
9898

99-
The first requirements is self-explanatory: we would like to avoid departures
99+
The second requirement is self-explanatory: we would like to avoid departures
100100
from run-to-completion model that Dart currently provides for synchronous code.
101101

102102
To explain the problem of premature finalization, consider the following code:
@@ -301,7 +301,7 @@ abstract class NativeFinalizer<T> {
301301
/// [externalSize] is an amount of native (non-Dart) memory owned by the
302302
/// given [value]. This information is used to drive garbage collection
303303
/// scheduling heuristics.
304-
void attach(Object value, T token, {Object? detachKey, int externalSize}});
304+
void attach(Finalizable value, T token, {Object? detachKey, int externalSize}});
305305
306306
/// Detaches the finalizer from any objects that used [detachKey] when
307307
/// attaching the finalizer to them.

0 commit comments

Comments
 (0)