Skip to content

Commit 80ff46f

Browse files
Stop pinning deps in working/macros/example/pubspec.yaml. (#3595)
Pinning the deps was creating a version skew problem in continuous integration (which is configured in `.github/workflows/dart.yml`). The continuous integration configuration uses `sdk: main` (meaning that the code will be analyzed using the latest bleeding edge build of Dart). But the macros in `working/macros/example` import macro support functionality from `package:_fe_analyzer_shared/src`, so they use whatever version of that package that is configured in the pubspec (which, prior to this change, was pinned to version `3.4.0-56.0.dev`). The reason this creates a version skew problem is that the macro support functionality in `package:_fe_analyzer_shared/src` includes deserialization logic that decodes data structures created during analysis and compilation. Which means that any time the serialization format changes, that could potentially break the continuous integration bot. Eventually we plan to move the macro support functionality into a `dart:` library that will ship as part of the SDK, so there will be no more version skew problem. Until then, an easy way to work around the version skew is simply to pin the pubspec to the `main` branch rather than a specific release, so that it matches what's configured in continuous integration. A side effect of this change is that if the API for writing macros gets changed in a way that breaks the examples in `working/macros/example`, that will cause the continuous integration bot to immediately start failing. (Previously it wouldn't cause a failure because the API was pinned to `3.4.0-56.0.dev`). Considering that the API for macros is under active development, this is probably a good thing; it will mean that if we make inadvertent API changes that break the examples, we'll be more likely to find out about it.
1 parent aad1953 commit 80ff46f

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

working/macros/example/pubspec.yaml

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,84 +17,84 @@ dependency_overrides:
1717
git:
1818
url: https://github.com/dart-lang/sdk.git
1919
path: pkg/_fe_analyzer_shared
20-
ref: 3.4.0-56.0.dev
20+
ref: main
2121
_js_interop_checks:
2222
git:
2323
url: https://github.com/dart-lang/sdk.git
2424
path: pkg/_js_interop_checks
25-
ref: 3.4.0-56.0.dev
25+
ref: main
2626
analyzer:
2727
git:
2828
url: https://github.com/dart-lang/sdk.git
2929
path: pkg/analyzer
30-
ref: 3.4.0-56.0.dev
30+
ref: main
3131
build_integration:
3232
git:
3333
url: https://github.com/dart-lang/sdk.git
3434
path: pkg/build_integration
35-
ref: 3.4.0-56.0.dev
35+
ref: main
3636
compiler:
3737
git:
3838
url: https://github.com/dart-lang/sdk.git
3939
path: pkg/compiler
40-
ref: 3.4.0-56.0.dev
40+
ref: main
4141
dart2js_info:
4242
git:
4343
url: https://github.com/dart-lang/sdk.git
4444
path: pkg/dart2js_info
45-
ref: 3.4.0-56.0.dev
45+
ref: main
4646
dart2wasm:
4747
git:
4848
url: https://github.com/dart-lang/sdk.git
4949
path: pkg/dart2wasm
50-
ref: 3.4.0-56.0.dev
50+
ref: main
5151
dev_compiler:
5252
git:
5353
url: https://github.com/dart-lang/sdk.git
5454
path: pkg/dev_compiler
55-
ref: 3.4.0-56.0.dev
55+
ref: main
5656
front_end:
5757
git:
5858
url: https://github.com/dart-lang/sdk.git
5959
path: pkg/front_end
60-
ref: 3.4.0-56.0.dev
60+
ref: main
6161
frontend_server:
6262
git:
6363
url: https://github.com/dart-lang/sdk.git
6464
path: pkg/frontend_server
65-
ref: 3.4.0-56.0.dev
65+
ref: main
6666
js_ast:
6767
git:
6868
url: https://github.com/dart-lang/sdk.git
6969
path: pkg/js_ast
70-
ref: 3.4.0-56.0.dev
70+
ref: main
7171
js_runtime:
7272
git:
7373
url: https://github.com/dart-lang/sdk.git
7474
path: pkg/js_runtime
75-
ref: 3.4.0-56.0.dev
75+
ref: main
7676
js_shared:
7777
git:
7878
url: https://github.com/dart-lang/sdk.git
7979
path: pkg/js_shared
80-
ref: 3.4.0-56.0.dev
80+
ref: main
8181
kernel:
8282
git:
8383
url: https://github.com/dart-lang/sdk.git
8484
path: pkg/kernel
85-
ref: 3.4.0-56.0.dev
85+
ref: main
8686
mmap:
8787
git:
8888
url: https://github.com/dart-lang/sdk.git
8989
path: pkg/mmap
90-
ref: 3.4.0-56.0.dev
90+
ref: main
9191
vm:
9292
git:
9393
url: https://github.com/dart-lang/sdk.git
9494
path: pkg/vm
95-
ref: 3.4.0-56.0.dev
95+
ref: main
9696
wasm_builder:
9797
git:
9898
url: https://github.com/dart-lang/sdk.git
9999
path: pkg/wasm_builder
100-
ref: 3.4.0-56.0.dev
100+
ref: main

0 commit comments

Comments
 (0)