fix analysis diagnostics by excluding some dirs and fixing up others (#2958)

Author: jakemac53

accepted/future-releases/0546-patterns/exhaustiveness_prototype/lib/space.dart

@@ -42,7 +42,9 @@ abstract class Space {
       // go through this constructor to create unions. A UnionSpace will never
       // contain UnionSpaces.
       if (space is UnionSpace) {
-        for (var arm in space.arms) addSpace(arm);
+        for (var arm in space.arms) {
+          addSpace(arm);
+        }
       } else {
         addSpace(space);
       }

accepted/future-releases/0546-patterns/exhaustiveness_prototype/lib/static_type.dart

@@ -100,7 +100,7 @@ class StaticType {
         _underlying = underlying,
         isSealed = true,
         // No fields because it may match null which doesn't have them.
-        _fields = {} {}
+        _fields = {};
 
   bool isSubtypeOf(StaticType other) {
     if (this == other) return true;

accepted/future-releases/0546-patterns/exhaustiveness_prototype/lib/subtract.dart

@@ -3,9 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 import 'intersect_empty.dart';
 import 'profile.dart' as profile;
-import 'static_type.dart';
-
 import 'space.dart';
+import 'static_type.dart';
 
 /// Returns a new [Space] that contains all of the values of [left] that are
 /// not also in [right].

accepted/future-releases/0546-patterns/exhaustiveness_prototype/test/expand_type_test.dart

@@ -203,13 +203,12 @@ void main() {
     //   (A)
     //   / \
     //  B   C
-    //     / \
-    //    D   E
+    //       \
+    //        E
     var a = StaticType('A', isSealed: true);
     var b = StaticType('B', inherits: [a]);
     var c = StaticType('C', inherits: [a]);
     var d = StaticType('D', inherits: [c]);
-    var e = StaticType('E', inherits: [c]);
 
     expectExpand(a.nullable, a, 'A|Null');
     expectExpand(a, a.nullable, 'A');

analysis_options.yaml

@@ -1,6 +1,7 @@
 analyzer:
   exclude:
     - accepted/2.3/spread-collections/examples/**
+    - archive/newsletter/20171103
     # TODO: remove these when the analyzer supports macros
     - working/macros/example/lib/auto_dispose.dart
     - working/macros/example/lib/data_class.dart