Skip to content

Commit 2f41028

Browse files
Merge pull request #719 from dart-lang:latest_lints
PiperOrigin-RevId: 583139202
2 parents dc3eb65 + 8b5036b commit 2f41028

File tree

8 files changed

+35
-38
lines changed

8 files changed

+35
-38
lines changed

.github/workflows/test-package.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
strategy:
3838
fail-fast: false
3939
matrix:
40-
sdk: [3.0.0, dev]
40+
sdk: [3.1.0, dev]
4141
steps:
4242
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
4343
- uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d
@@ -59,7 +59,7 @@ jobs:
5959
fail-fast: false
6060
matrix:
6161
os: [ubuntu-latest]
62-
sdk: [3.0.0, dev]
62+
sdk: [3.1.0, dev]
6363
steps:
6464
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
6565
- uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Require analyzer 5.12.0, allow analyzer version 6.x;
44
* Add example of writing a class to mock function objects.
55
* Add support for the `build_extensions` build.yaml option
6-
* Require Dart >= 3.0.0.
6+
* Require Dart >=3.1.0.
77
* **Potentially breaking** Changed default `String` value returned by nice
88
mocks' unstubbed method to include some useful info. This could break the
99
tests that relied on getting an empty `String` from unstubbed methods.

lib/src/builder.dart

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -488,11 +488,9 @@ class _MockTargetGatherer {
488488
case 'GenerateMocks':
489489
mockTargets
490490
.addAll(_mockTargetsFromGenerateMocks(annotation, entryLib));
491-
break;
492491
case 'GenerateNiceMocks':
493492
mockTargets.addAll(
494493
_mockTargetsFromGenerateNiceMocks(annotation, entryLib));
495-
break;
496494
}
497495
}
498496
}
@@ -2404,16 +2402,12 @@ extension on TypeSystem {
24042402
extension on int {
24052403
String get ordinal {
24062404
final remainder = this % 10;
2407-
switch (remainder) {
2408-
case 1:
2409-
return '${this}st';
2410-
case 2:
2411-
return '${this}nd';
2412-
case 3:
2413-
return '${this}rd';
2414-
default:
2415-
return '${this}th';
2416-
}
2405+
return switch (remainder) {
2406+
1 => '${this}st',
2407+
2 => '${this}nd',
2408+
3 => '${this}rd',
2409+
_ => '${this}th'
2410+
};
24172411
}
24182412
}
24192413

lib/src/dummies.dart

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -104,22 +104,22 @@ typedef DummyBuilder<T> = T Function(Object parent, Invocation invocation);
104104
Map<Type, DummyBuilder> _dummyBuilders = {};
105105

106106
Map<Type, DummyBuilder> _defaultDummyBuilders = {
107-
bool: (_, _i) => false,
108-
int: (_, _i) => _dummyInt,
109-
num: (_, _i) => _dummyInt,
110-
double: (_, _i) => _dummyDouble,
107+
bool: (_, __) => false,
108+
int: (_, __) => _dummyInt,
109+
num: (_, __) => _dummyInt,
110+
double: (_, __) => _dummyDouble,
111111
String: _dummyString,
112-
Int8List: (_, _i) => Int8List(0),
113-
Int16List: (_, _i) => Int16List(0),
114-
Int32List: (_, _i) => Int32List(0),
115-
Int64List: (_, _i) => Int64List(0),
116-
Uint8List: (_, _i) => Uint8List(0),
117-
Uint16List: (_, _i) => Uint16List(0),
118-
Uint32List: (_, _i) => Uint32List(0),
119-
Uint64List: (_, _i) => Uint64List(0),
120-
Float32List: (_, _i) => Float32List(0),
121-
Float64List: (_, _i) => Float64List(0),
122-
ByteData: (_, _i) => ByteData(0),
112+
Int8List: (_, __) => Int8List(0),
113+
Int16List: (_, __) => Int16List(0),
114+
Int32List: (_, __) => Int32List(0),
115+
Int64List: (_, __) => Int64List(0),
116+
Uint8List: (_, __) => Uint8List(0),
117+
Uint16List: (_, __) => Uint16List(0),
118+
Uint32List: (_, __) => Uint32List(0),
119+
Uint64List: (_, __) => Uint64List(0),
120+
Float32List: (_, __) => Float32List(0),
121+
Float64List: (_, __) => Float64List(0),
122+
ByteData: (_, __) => ByteData(0),
123123
...platformDummies,
124124
};
125125

lib/src/mock.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class SmartFake {
235235
// make Analyzer happy, if we fake classes that override `==` to
236236
// accept `Object?` or `dynamic` (most notably [Interceptor]).
237237
@override
238-
// ignore: non_nullable_equals_parameter
238+
// ignore: non_nullable_equals_parameter, hash_and_equals
239239
bool operator ==(Object? other) => identical(this, other);
240240

241241
@override

pubspec.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,25 @@ description: >-
66
repository: https://github.com/dart-lang/mockito
77

88
environment:
9-
sdk: '>=3.0.0 <4.0.0'
9+
sdk: ^3.1.0
1010

1111
dependencies:
1212
analyzer: '>=5.12.0 <7.0.0'
13-
build: '>=1.3.0 <3.0.0'
13+
build: ^2.0.0
1414
code_builder: ^4.5.0
1515
collection: ^1.15.0
16-
dart_style: '>=1.3.6 <3.0.0'
16+
dart_style: ^2.0.0
1717
matcher: ^0.12.15
1818
meta: ^1.3.0
1919
path: ^1.8.0
20-
source_gen: '>=0.9.6 <2.0.0'
20+
source_gen: ^1.0.0
2121
test_api: '>=0.2.1 <0.7.0'
2222

2323
dev_dependencies:
2424
build_runner: ^2.0.0
2525
build_test: ^2.0.0
2626
build_web_compilers: '>=3.0.0 <5.0.0'
27-
http: '>=0.13.0 <2.0.0'
28-
lints: ^2.0.0
29-
package_config: '>=1.9.3 <3.0.0'
27+
http: ^1.0.0
28+
lints: ^3.0.0
29+
package_config: ^2.0.0
3030
test: ^1.16.0

test/end2end/foo.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// ignore_for_file: library_private_types_in_public_api
2+
13
import 'foo_sub.dart';
24

35
class Foo<T> {

test/end2end/generated_mocks_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import 'generated_mocks_test.mocks.dart';
2424
#$hasDollarInName,
2525
},
2626
),
27+
// ignore: deprecated_member_use_from_same_package
2728
MockSpec<HasPrivate>(mixingIn: [HasPrivateMixin]),
2829
])
2930
@GenerateNiceMocks(

0 commit comments

Comments
 (0)