[ffigen] Switch to package:dart_flutter_team_lints (#1277)

Author: dcharkes

pkgs/ffigen/CHANGELOG.md

@@ -29,6 +29,7 @@
   built-in methods, or with types declared elsewhere in the generated bindings.
 - Add `include-unused-typedefs` to allow generating typedefs that are not
   referred to anywhere, the default option is `false`.
+- Use `package:dart_flutter_team_lints`.
 
 ## 12.0.0
 

pkgs/ffigen/analysis_options.yaml

@@ -2,7 +2,7 @@
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   errors:
@@ -19,15 +19,27 @@ analyzer:
   language:
     strict-casts: true
     strict-inference: true
+    strict-raw-types: false #TODO(https://github.com/dart-lang/native/issues/1281): Fix.
 
 linter:
   rules:
-    # Enabled.
     dangling_library_doc_comments: true
     directives_ordering: true
     prefer_final_locals: true
     prefer_final_in_for_each: true
     use_super_parameters: true
-
-    # Disabled.
-    constant_identifier_names: false
+    always_declare_return_types: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    avoid_dynamic_calls: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    comment_references: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    constant_identifier_names: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    library_annotations: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    lines_longer_than_80_chars: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    omit_local_variable_types: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix.
+    only_throw_errors: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    prefer_asserts_in_initializer_lists: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    prefer_const_constructors: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix.
+    prefer_relative_imports: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    prefer_single_quotes: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix.
+    type_annotate_public_apis: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    unnecessary_parenthesis: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix
+    unreachable_from_main: false # TODO(https://github.com/dart-lang/native/issues/1281): Fix

pkgs/ffigen/pubspec.yaml

@@ -32,8 +32,8 @@ dependencies:
 
 dev_dependencies:
   coverage: ^1.8.0
+  dart_flutter_team_lints: ^2.0.0
   json_schema: ^5.1.1
-  lints: ^2.0.1
   meta: ^1.11.0
   objective_c: ^1.0.0
   test: ^1.16.2

pkgs/objective_c/CHANGELOG.md

@@ -12,6 +12,7 @@
   by the ffigen bindings for a protocol.
 - Make all of the code-genned structs and enums public so they can be reused by
   user bindings.
+- Use `package:dart_flutter_team_lints`.
 
 ## 1.0.1
 

pkgs/objective_c/analysis_options.yaml

@@ -1,8 +1,22 @@
-include: package:flutter_lints/flutter.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
+  errors:
+    todo: ignore
   exclude:
     - tool/data/extra_methods.dart
   language:
     strict-casts: true
     strict-inference: true
+    strict-raw-types: true
+
+linter:
+  rules:
+    avoid_dynamic_calls: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix
+    combinators_ordering: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix.
+    comment_references: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix
+    directives_ordering: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix
+    library_annotations: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix
+    omit_local_variable_types: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix
+    prefer_single_quotes: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix
+    sort_pub_dependencies: false # TODO(https://github.com/dart-lang/native/issues/1280): Fix

pkgs/objective_c/example/pubspec.lock

@@ -219,10 +219,10 @@ packages:
     dependency: transitive
     description:
       name: vm_service
-      sha256: "360c4271613beb44db559547d02f8b0dc044741d0eeb9aa6ccdb47e8ec54c63a"
+      sha256: f652077d0bdf60abe4c1f6377448e8655008eef28f128bc023f7b5e8dfeb48fc
       url: "https://pub.dev"
     source: hosted
-    version: "14.2.3"
+    version: "14.2.4"
   yaml:
     dependency: transitive
     description:

pkgs/objective_c/pubspec.yaml

@@ -3,7 +3,7 @@
 # BSD-style license that can be found in the LICENSE file.
 
 name: objective_c
-description: "A library to access Objective C from Flutter that acts as a support library for package:ffigen."
+description: 'A library to access Objective C from Flutter that acts as a support library for package:ffigen.'
 version: 1.1.0-wip
 repository: https://github.com/dart-lang/native/tree/main/pkgs/objective_c
 
@@ -26,6 +26,7 @@ dependencies:
 
 dev_dependencies:
   coverage: ^1.8.0
+  dart_flutter_team_lints: ^2.0.0
   ffigen: ^12.0.0
   flutter_test:
     sdk: flutter

pkgs/swiftgen/CHANGELOG.md

@@ -1 +1,3 @@
 ## 0.0.1-wip
+
+- Initial version.

pkgs/swiftgen/analysis_options.yaml

@@ -0,0 +1,7 @@
+include: package:dart_flutter_team_lints/analysis_options.yaml
+
+analyzer:
+  language:
+    strict-casts: true
+    strict-inference: true
+    strict-raw-types: true

pkgs/swiftgen/pubspec.yaml

@@ -3,7 +3,7 @@
 # BSD-style license that can be found in the LICENSE file.
 
 name: swiftgen
-description: "A tool for generating bindings that allow interop between Dart and Swift code."
+description: 'A tool for generating bindings that allow interop between Dart and Swift code.'
 version: 0.0.1-wip
 repository: https://github.com/dart-lang/native/tree/main/pkgs/swiftgen
 
@@ -20,6 +20,7 @@ dependencies:
   ffi: ^2.1.0
 
 dev_dependencies:
+  dart_flutter_team_lints: ^2.0.0
   ffigen: ^11.0.0
   test: ^1.21.1