Skip to content

Commit 282b8af

Browse files
[jnigen] Added lints (#1303)
* 0 - strict cast lint commit-id:680420c9 * 1 - `avoid_catching_errors` lint commit-id:8bf40502 * 2 - `comment_references` lint commit-id:65bf2591 * 3 - `directives_ordering` lint commit-id:84e7cc4c * 4 - `library_annotations` lint commit-id:a553ef6e * 5 - `lines_longer_than_80_chars` lint commit-id:b271b60a * 6 - `omit_local_variable_types` lint commit-id:11331626 * 7 - `only_throw_errors` lint commit-id:40c7a061 * 8 - `prefer_single_quotes` lint commit-id:544866c0 * 9 - `type_annotate_public_apis` lint commit-id:45a4ceb7 * 10 - `unnecessary_lambdas` lint commit-id:df426921 * 11 - `unnecessary_parenthesis` lint commit-id:8505deca * 12 - `unreachable_from_main` lint commit-id:5ca1484e * 13 - tidy up analysis_options, remove lints that already exist commit-id:970086fa
1 parent 90a78fd commit 282b8af

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+2468
-2421
lines changed

pkgs/jnigen/analysis_options.yaml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ analyzer:
99
todo: ignore
1010
exclude: [build/**, example/**]
1111
language:
12-
strict-casts: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
12+
strict-casts: true
1313
strict-inference: true
1414
strict-raw-types: true
1515

@@ -18,18 +18,3 @@ linter:
1818
dangling_library_doc_comments: true
1919
prefer_final_locals: true
2020
prefer_const_declarations: true
21-
unawaited_futures: true
22-
prefer_const_constructors: true
23-
prefer_relative_imports: true
24-
avoid_catching_errors: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
25-
comment_references: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
26-
directives_ordering: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
27-
library_annotations: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
28-
lines_longer_than_80_chars: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
29-
omit_local_variable_types: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
30-
only_throw_errors: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
31-
prefer_single_quotes: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
32-
type_annotate_public_apis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
33-
unnecessary_lambdas: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
34-
unnecessary_parenthesis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
35-
unreachable_from_main: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.

pkgs/jnigen/bin/setup.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'package:jnigen/src/tools/tools.dart';
99
import 'package:logging/logging.dart';
1010

1111
void main(List<String> args) async {
12-
bool force = false;
12+
var force = false;
1313
setLoggingLevel(Level.INFO);
1414
if (args.isNotEmpty) {
1515
if (args.length != 1 || args[0] != '-f') {

0 commit comments

Comments
 (0)