[ffigen] Update lints (#2402)

goderbauer · web-flow · commit 348134637386 · 2025-07-14T14:01:47.000+02:00
diff --git a/pkgs/ffi/CHANGELOG.md b/pkgs/ffi/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 2.1.5-wip
+
+- Update to the latest lints.
+
 ## 2.1.4
 
 - Require Dart 3.7.0 or greater to opt in to tall style formatting.
diff --git a/pkgs/ffi/pubspec.yaml b/pkgs/ffi/pubspec.yaml
@@ -1,5 +1,5 @@
 name: ffi
-version: 2.1.4
+version: 2.1.5-wip
 description: Utilities for working with Foreign Function Interface (FFI) code.
 repository: https://github.com/dart-lang/native/tree/main/pkgs/ffi
 issue_tracker: https://github.com/dart-lang/native/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Affi
@@ -13,5 +13,5 @@ environment:
   sdk: '>=3.7.0 <4.0.0'
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   test: ^1.21.2
diff --git a/pkgs/ffigen/CHANGELOG.md b/pkgs/ffigen/CHANGELOG.md
@@ -5,6 +5,7 @@
   Dart version and formatting options.
 - Add `_` to the list of Dart keywords, since it has special meaning in newer
   Dart versions.
+- Update to the latest lints.
 
 ## 19.0.0
 
diff --git a/pkgs/ffigen/example/c_json/pubspec.yaml b/pkgs/ffigen/example/c_json/pubspec.yaml
@@ -12,7 +12,6 @@ dependencies:
   path: ^1.8.0
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   ffigen:
     path: '../../'
-  lints: ^2.0.1
diff --git a/pkgs/ffigen/example/ffinative/pubspec.yaml b/pkgs/ffigen/example/ffinative/pubspec.yaml
@@ -11,7 +11,6 @@ dependencies:
   ffi: ^2.0.1
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   ffigen:
     path: '../../'
-  lints: ^2.0.0
diff --git a/pkgs/ffigen/example/libclang-example/pubspec.yaml b/pkgs/ffigen/example/libclang-example/pubspec.yaml
@@ -11,7 +11,6 @@ dependencies:
   ffi: ^2.0.1
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   ffigen:
     path: '../../'
-  lints: ^2.0.1
diff --git a/pkgs/ffigen/example/objective_c/pubspec.yaml b/pkgs/ffigen/example/objective_c/pubspec.yaml
@@ -13,10 +13,9 @@ dependencies:
   objective_c: ^0.0.1
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   ffigen:
     path: ../../
-  lints: ^2.0.0
 
 dependency_overrides:
   objective_c:
diff --git a/pkgs/ffigen/example/shared_bindings/pubspec.yaml b/pkgs/ffigen/example/shared_bindings/pubspec.yaml
@@ -13,7 +13,6 @@ dependencies:
   path: ^1.8.0
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   ffigen:
     path: '../../'
-  lints: ^2.0.1
diff --git a/pkgs/ffigen/example/simple/pubspec.yaml b/pkgs/ffigen/example/simple/pubspec.yaml
@@ -11,7 +11,6 @@ dependencies:
   ffi: ^2.0.1
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   ffigen:
     path: '../../'
-  lints: ^2.0.1
diff --git a/pkgs/ffigen/example/swift/pubspec.yaml b/pkgs/ffigen/example/swift/pubspec.yaml
@@ -13,10 +13,9 @@ dependencies:
   objective_c: ^0.0.1
 
 dev_dependencies:
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   ffigen:
     path: ../../
-  lints: ^2.0.0
 
 dependency_overrides:
   objective_c:
diff --git a/pkgs/ffigen/lib/ffigen.dart b/pkgs/ffigen/lib/ffigen.dart
@@ -6,7 +6,7 @@
 ///
 /// For most use cases the YAML based API is simpler. See
 /// https://pub.dev/packages/ffigen for details.
-library ffigen;
+library;
 
 export 'src/code_generator/imports.dart' show ImportedType, LibraryImport;
 export 'src/config_provider.dart'
diff --git a/pkgs/ffigen/lib/src/code_generator.dart b/pkgs/ffigen/lib/src/code_generator.dart
@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Generates FFI bindings for a given Library.
-library code_generator;
+library;
 
 export 'code_generator/binding.dart';
 export 'code_generator/compound.dart';
diff --git a/pkgs/ffigen/lib/src/code_generator/func_type.dart b/pkgs/ffigen/lib/src/code_generator/func_type.dart
@@ -148,7 +148,7 @@ class FunctionType extends Type {
   }
 }
 
-/// Represents a NativeFunction<Function>.
+/// Represents a `NativeFunction<Function>`.
 class NativeFunc extends Type {
   // Either a FunctionType or a Typealias of a FunctionType.
   final Type _type;
diff --git a/pkgs/ffigen/lib/src/config_provider.dart b/pkgs/ffigen/lib/src/config_provider.dart
@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Creates config object used by other sub_modules.
-library config_provider;
+library;
 
 export 'config_provider/config.dart';
 export 'config_provider/config_types.dart';
diff --git a/pkgs/ffigen/lib/src/config_provider/config.dart b/pkgs/ffigen/lib/src/config_provider/config.dart
@@ -361,7 +361,7 @@ abstract interface class DeclarationFilters {
     shouldIncludeSymbolAddressFunc: shouldIncludeSymbolAddress ?? (_) => false,
     renameFunc: rename ?? (declaration) => declaration.originalName,
     renameMemberFunc: renameMember ?? (_, member) => member,
-    shouldIncludeMemberFunc: shouldIncludeMember ?? (_, __) => true,
+    shouldIncludeMemberFunc: shouldIncludeMember ?? (_, _) => true,
   );
 
   static final excludeAll = DeclarationFilters();
diff --git a/pkgs/ffigen/lib/src/header_parser.dart b/pkgs/ffigen/lib/src/header_parser.dart
@@ -5,6 +5,6 @@
 /// Generates a Library (code_generator)
 ///
 /// Parses the header files AST using clang_bindings.
-library header_parser;
+library;
 
 export 'header_parser/parser.dart' show parse;
diff --git a/pkgs/ffigen/lib/src/header_parser/utils.dart b/pkgs/ffigen/lib/src/header_parser/utils.dart
@@ -460,7 +460,7 @@ class Stack<T> {
 class IncrementalNamer {
   final _incrementedStringCounters = <String, int>{};
 
-  /// Appends `<int>` to base. <int> is incremented on every call.
+  /// Appends `<int>` to base. `<int>` is incremented on every call.
   String name(String base) {
     var i = _incrementedStringCounters[base] ?? 0;
     i++;
diff --git a/pkgs/ffigen/pubspec.yaml b/pkgs/ffigen/pubspec.yaml
@@ -37,7 +37,7 @@ dependencies:
 
 dev_dependencies:
   async: ^2.11.0
-  dart_flutter_team_lints: ^2.0.0
+  dart_flutter_team_lints: ^3.5.2
   json_schema: ^5.1.1
   leak_tracker: ^10.0.7
   objective_c: ^8.1.0
