Skip to content

Commit af29d98

Browse files
dcharkesdcharkes
authored
[native_assets_cli] Rename package:hook to package:hooks (#2136)
Bug: #999 A package name is either a verb, a singular noun, or a plural noun. Since this package name is a noun and there is more than one hook (build hook and link hook), rename the package to a plural noun.
1 parent 540e669 commit af29d98

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+96
-96
lines changed

‎.github/workflows/hook.yaml renamed to ‎.github/workflows/hooks.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ on:
1010
# No `branches:` to enable stacked PRs on GitHub.
1111
paths:
1212
- ".github/workflows/hook.yaml"
13-
- "pkgs/hook/**"
13+
- "pkgs/hooks/**"
1414
- "pkgs/code_assets/**"
1515
- "pkgs/data_assets/**"
1616
push:
1717
branches: [main]
1818
paths:
1919
- ".github/workflows/native.yaml"
20-
- "pkgs/hook/**"
20+
- "pkgs/hooks/**"
2121
- "pkgs/code_assets/**"
2222
- "pkgs/data_assets/**"
2323
schedule:
@@ -30,7 +30,7 @@ jobs:
3030
matrix:
3131
os: [ubuntu, windows]
3232
sdk: [dev]
33-
package: [hook, code_assets, data_assets]
33+
package: [hooks, code_assets, data_assets]
3434

3535
runs-on: ${{ matrix.os }}-latest
3636

‎pkgs/code_assets/doc/schema/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ These schemas document the protocol for build and link hooks with code assets.
1414

1515
These schemas are an extension of the base protocol:
1616

17-
* [`package:hook`/doc/schema](../../../hook/doc/schema/)
17+
* [`package:hooks`/doc/schema](../../../hooks/doc/schema/)

‎pkgs/code_assets/doc/schema/hook/shared_definitions.generated.schema.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"$ref": "#/definitions/HookInput"
1010
},
1111
{
12-
"$ref": "../../../../hook/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/BuildInput"
12+
"$ref": "../../../../hooks/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/BuildInput"
1313
},
1414
{
1515
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/BuildInput"
@@ -25,7 +25,7 @@
2525
"$ref": "#/definitions/HookOutput"
2626
},
2727
{
28-
"$ref": "../../../../hook/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/BuildOutput"
28+
"$ref": "../../../../hooks/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/BuildOutput"
2929
},
3030
{
3131
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/BuildOutput"
@@ -38,7 +38,7 @@
3838
"HookInput": {
3939
"allOf": [
4040
{
41-
"$ref": "../../../../hook/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/HookInput"
41+
"$ref": "../../../../hooks/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/HookInput"
4242
},
4343
{
4444
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/HookInput"
@@ -51,7 +51,7 @@
5151
"HookOutput": {
5252
"allOf": [
5353
{
54-
"$ref": "../../../../hook/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/HookOutput"
54+
"$ref": "../../../../hooks/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/HookOutput"
5555
},
5656
{
5757
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/HookOutput"
@@ -67,7 +67,7 @@
6767
"$ref": "#/definitions/HookInput"
6868
},
6969
{
70-
"$ref": "../../../../hook/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/LinkInput"
70+
"$ref": "../../../../hooks/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/LinkInput"
7171
},
7272
{
7373
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/LinkInput"
@@ -83,7 +83,7 @@
8383
"$ref": "#/definitions/HookOutput"
8484
},
8585
{
86-
"$ref": "../../../../hook/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/LinkOutput"
86+
"$ref": "../../../../hooks/doc/schema/hook/shared_definitions.generated.schema.json#/definitions/LinkOutput"
8787
},
8888
{
8989
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/LinkOutput"

‎pkgs/code_assets/doc/schema/sdk/shared_definitions.generated.schema.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"$ref": "#/definitions/HookInput"
1010
},
1111
{
12-
"$ref": "../../../../hook/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/BuildInput"
12+
"$ref": "../../../../hooks/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/BuildInput"
1313
},
1414
{
1515
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/BuildInput"
@@ -25,7 +25,7 @@
2525
"$ref": "#/definitions/HookOutput"
2626
},
2727
{
28-
"$ref": "../../../../hook/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/BuildOutput"
28+
"$ref": "../../../../hooks/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/BuildOutput"
2929
},
3030
{
3131
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/BuildOutput"
@@ -38,7 +38,7 @@
3838
"HookInput": {
3939
"allOf": [
4040
{
41-
"$ref": "../../../../hook/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/HookInput"
41+
"$ref": "../../../../hooks/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/HookInput"
4242
},
4343
{
4444
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/HookInput"
@@ -51,7 +51,7 @@
5151
"HookOutput": {
5252
"allOf": [
5353
{
54-
"$ref": "../../../../hook/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/HookOutput"
54+
"$ref": "../../../../hooks/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/HookOutput"
5555
},
5656
{
5757
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/HookOutput"
@@ -67,7 +67,7 @@
6767
"$ref": "#/definitions/HookInput"
6868
},
6969
{
70-
"$ref": "../../../../hook/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/LinkInput"
70+
"$ref": "../../../../hooks/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/LinkInput"
7171
},
7272
{
7373
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/LinkInput"
@@ -83,7 +83,7 @@
8383
"$ref": "#/definitions/HookOutput"
8484
},
8585
{
86-
"$ref": "../../../../hook/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/LinkOutput"
86+
"$ref": "../../../../hooks/doc/schema/sdk/shared_definitions.generated.schema.json#/definitions/LinkOutput"
8787
},
8888
{
8989
"$ref": "../shared/shared_definitions.generated.schema.json#/definitions/LinkOutput"

‎pkgs/code_assets/doc/schema/shared/shared_definitions.generated.schema.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"$ref": "#/definitions/HookInput"
1010
},
1111
{
12-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/BuildInput"
12+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/BuildInput"
1313
}
1414
]
1515
},
@@ -19,7 +19,7 @@
1919
"$ref": "#/definitions/HookOutput"
2020
},
2121
{
22-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/BuildOutput"
22+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/BuildOutput"
2323
},
2424
{
2525
"properties": {
@@ -48,7 +48,7 @@
4848
"Config": {
4949
"allOf": [
5050
{
51-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/Config"
51+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/Config"
5252
},
5353
{
5454
"$ref": "shared_definitions.schema.json#/definitions/Config"
@@ -58,7 +58,7 @@
5858
"HookInput": {
5959
"allOf": [
6060
{
61-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/HookInput"
61+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/HookInput"
6262
},
6363
{
6464
"properties": {
@@ -72,7 +72,7 @@
7272
"HookOutput": {
7373
"allOf": [
7474
{
75-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/HookOutput"
75+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/HookOutput"
7676
},
7777
{
7878
"properties": {
@@ -92,7 +92,7 @@
9292
"$ref": "#/definitions/HookInput"
9393
},
9494
{
95-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/LinkInput"
95+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/LinkInput"
9696
},
9797
{
9898
"properties": {
@@ -112,7 +112,7 @@
112112
"$ref": "#/definitions/HookOutput"
113113
},
114114
{
115-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/LinkOutput"
115+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/LinkOutput"
116116
}
117117
]
118118
}

‎pkgs/code_assets/doc/schema/shared/shared_definitions.schema.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
]
6464
},
6565
"file": {
66-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
66+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
6767
},
6868
"id": {
6969
"type": "string"
@@ -110,13 +110,13 @@
110110
"type": "object",
111111
"properties": {
112112
"ar": {
113-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
113+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
114114
},
115115
"cc": {
116-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
116+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
117117
},
118118
"env_script": {
119-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
119+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
120120
},
121121
"env_script_arguments": {
122122
"type": "array",
@@ -125,7 +125,7 @@
125125
}
126126
},
127127
"ld": {
128-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
128+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
129129
},
130130
"windows": {
131131
"type": "object",
@@ -140,7 +140,7 @@
140140
}
141141
},
142142
"script": {
143-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
143+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/absolutePath"
144144
}
145145
},
146146
"required": [
@@ -318,7 +318,7 @@
318318
"then": {
319319
"properties": {
320320
"uri": {
321-
"$ref": "../../../../hook/doc/schema/shared/shared_definitions.schema.json#/definitions/relativePath"
321+
"$ref": "../../../../hooks/doc/schema/shared/shared_definitions.schema.json#/definitions/relativePath"
322322
}
323323
},
324324
"required": [

‎pkgs/code_assets/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ environment:
88
sdk: '>=3.7.0 <4.0.0'
99

1010
dependencies:
11-
hook:
12-
path: ../hook/
11+
hooks:
12+
path: ../hooks/
1313

1414
dev_dependencies:
1515
dart_flutter_team_lints: ^2.1.1

‎pkgs/code_assets/test/schema/helpers.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
export '../../../hook/test/schema/helpers.dart';
5+
export '../../../hooks/test/schema/helpers.dart';

‎pkgs/code_assets/test/schema/schema_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import 'helpers.dart';
1212

1313
void main() {
1414
final schemasUri = packageUri.resolve('doc/schema/');
15-
final hookSchemasUri = packageUri.resolve('../hook/doc/schema/');
15+
final hookSchemasUri = packageUri.resolve('../hooks/doc/schema/');
1616
final allSchemas = loadSchemas([schemasUri, hookSchemasUri]);
1717

1818
final testDataUri = packageUri.resolve('test/data/');

‎pkgs/data_assets/doc/schema/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ These schemas document the protocol for build and link hooks with data assets.
1414

1515
These schemas are an extension of the base protocol:
1616

17-
* [`package:hook`/doc/schema](../../../hook/doc/schema/)
17+
* [`package:hooks`/doc/schema](../../../hooks/doc/schema/)

0 commit comments

Comments
 (0)