[infra] Add test_helpers package (#2385)

Author: liamappelbe

.github/workflows/native.yaml

@@ -17,6 +17,7 @@ on:
       - "pkgs/json_syntax_generator/**"
       - "pkgs/native_toolchain_c/**"
       - "pkgs/repo_lint_rules/**"
+      - "pkgs/test_helpers/**"
       - "tool/**"
   push:
     branches: [main]
@@ -29,6 +30,7 @@ on:
       - "pkgs/json_syntax_generator/**"
       - "pkgs/native_toolchain_c/**"
       - "pkgs/repo_lint_rules/**"
+      - "pkgs/test_helpers/**"
       - "tool/**"
   schedule:
     - cron: "0 0 * * 0" # weekly

.github/workflows/objective_c.yaml

@@ -8,12 +8,14 @@ on:
       - '.github/workflows/objective_c.yaml'
       - 'pkgs/ffigen/**'
       - 'pkgs/objective_c/**'
+      - 'pkgs/test_helpers/**'
   pull_request:
     branches: [main, stable]
     paths:
       - '.github/workflows/objective_c.yaml'
       - 'pkgs/ffigen/**'
       - 'pkgs/objective_c/**'
+      - 'pkgs/test_helpers/**'
   schedule:
     - cron: "0 0 * * 0"
 

.github/workflows/swift2objc.yaml

@@ -7,11 +7,13 @@ on:
     paths:
       - '.github/workflows/swift2objc.yaml'
       - 'pkgs/swift2objc/**'
+      - 'pkgs/test_helpers/**'
   pull_request:
     branches: [main, stable]
     paths:
       - '.github/workflows/swift2objc.yaml'
       - 'pkgs/swift2objc/**'
+      - 'pkgs/test_helpers/**'
   schedule:
     - cron: "0 0 * * 0"
 

.github/workflows/swiftgen.yaml

@@ -6,7 +6,11 @@ on:
     branches: [main, stable]
     paths:
       - '.github/workflows/swiftgen.yaml'
+      - 'pkgs/ffigen/**'
+      - 'pkgs/objective_c/**'
+      - 'pkgs/swift2objc/**'
       - 'pkgs/swiftgen/**'
+      - 'pkgs/test_helpers/**'
   pull_request:
     branches: [main, stable]
     paths:
@@ -15,6 +19,7 @@ on:
       - 'pkgs/objective_c/**'
       - 'pkgs/swift2objc/**'
       - 'pkgs/swiftgen/**'
+      - 'pkgs/test_helpers/**'
   schedule:
     - cron: "0 0 * * 0"
 

pkgs/code_assets/pubspec.yaml

@@ -30,3 +30,5 @@ dev_dependencies:
   repo_lint_rules:
     path: ../repo_lint_rules/
   test: ^1.25.15
+  test_helpers:
+    path: ../test_helpers/

pkgs/code_assets/test/json_schema/schema_test.dart

@@ -7,6 +7,7 @@
 import 'dart:convert';
 
 import 'package:json_schema/json_schema.dart';
+import 'package:test_helpers/test_helpers.dart';
 
 import 'helpers.dart';
 

pkgs/data_assets/pubspec.yaml

@@ -26,3 +26,5 @@ dev_dependencies:
   repo_lint_rules:
     path: ../repo_lint_rules/
   test: ^1.25.15
+  test_helpers:
+    path: ../test_helpers

pkgs/data_assets/test/json_schema/schema_test.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:json_schema/json_schema.dart';
+import 'package:test_helpers/test_helpers.dart';
 
 import 'helpers.dart';
 

pkgs/hooks/pubspec.yaml

@@ -42,3 +42,5 @@ dev_dependencies:
   repo_lint_rules:
     path: ../repo_lint_rules/
   test: ^1.25.15
+  test_helpers:
+    path: ../test_helpers/

pkgs/hooks/test/helpers.dart

@@ -9,6 +9,7 @@ import 'package:data_assets/data_assets.dart';
 import 'package:hooks/hooks.dart';
 import 'package:logging/logging.dart';
 import 'package:test/test.dart';
+import 'package:test_helpers/test_helpers.dart';
 
 const keepTempKey = 'KEEP_TEMPORARY_DIRECTORIES';
 
@@ -41,58 +42,8 @@ Future<void> inTempDir(
   }
 }
 
-/// Test files are run in a variety of ways, find this package root in all.
-///
-/// Test files can be run from source from any working directory. The Dart SDK
-/// `tools/test.py` runs them from the root of the SDK for example.
-///
-/// Test files can be run from dill from the root of package. `package:test`
-/// does this.
-///
-/// https://github.com/dart-lang/test/issues/110
-Uri findPackageRoot(String packageName) {
-  final script = Platform.script;
-  final fileName = script.name;
-  if (fileName.endsWith('.dart')) {
-    // We're likely running from source in the package somewhere.
-    var directory = script.resolve('.');
-    while (true) {
-      final dirName = directory.name;
-      if (dirName == packageName) {
-        return directory;
-      }
-      final parent = directory.resolve('..');
-      if (parent == directory) break;
-      directory = parent;
-    }
-  } else if (fileName.endsWith('.dill')) {
-    // Probably from the package root.
-    final cwd = Directory.current.uri;
-    final dirName = cwd.name;
-    if (dirName == packageName) {
-      return cwd;
-    }
-  }
-  // Or the workspace root.
-  final cwd = Directory.current.uri;
-  final candidate = cwd.resolve('pkgs/$packageName/');
-  if (Directory.fromUri(candidate).existsSync()) {
-    return candidate;
-  }
-  throw StateError(
-    "Could not find package root for package '$packageName'. "
-    'Tried finding the package root via Platform.script '
-    "'${Platform.script.toFilePath()}' and Directory.current "
-    "'${Directory.current.uri.toFilePath()}'.",
-  );
-}
-
 Uri packageUri = findPackageRoot('hooks');
 
-extension on Uri {
-  String get name => pathSegments.where((e) => e != '').last;
-}
-
 /// Archiver provided by the environment.
 ///
 /// Provided on Dart CI.