[jni] Update to latest lints (#2403)

Author: goderbauer

pkgs/jni/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.14.3-wip
+
+- Update to the latest lints.
+
 ## 0.14.2
 
 - Fixed a bug where certain method of `JList`, `JSet`, and `JMap` did not work

pkgs/jni/example/lib/main.dart

@@ -150,7 +150,7 @@ class Example {
 }
 
 class MyApp extends StatefulWidget {
-  const MyApp(this.examples, {Key? key}) : super(key: key);
+  const MyApp(this.examples, {super.key});
   final List<Example> examples;
 
   @override
@@ -182,7 +182,7 @@ class _MyAppState extends State<MyApp> {
 }
 
 class ExampleCard extends StatefulWidget {
-  const ExampleCard(this.example, {Key? key}) : super(key: key);
+  const ExampleCard(this.example, {super.key});
   final Example example;
 
   @override

pkgs/jni/example/pubspec.yaml

@@ -56,7 +56,7 @@ dev_dependencies:
   # activated in the `analysis_options.yaml` file located at the root of your
   # package. See that file for information about deactivating specific lint
   # rules and activating additional ones.
-  flutter_lints: ^2.0.0
+  flutter_lints: ^6.0.0
 
 # For information on the generic Dart part of this file, see the
 # following page: https://dart.dev/tools/pub/pubspec

pkgs/jni/lib/src/util/jlist.dart

@@ -206,7 +206,7 @@ class JList<$E extends JObject?> extends JObject with ListMixin<$E> {
       _class.instanceMethodId(r'subList', r'(II)Ljava/util/List;');
   @override
   JList<$E> getRange(int start, int end) {
-    RangeError.checkValidRange(start, end, this.length);
+    RangeError.checkValidRange(start, end, length);
     return _getRangeId(
         this, JListType<$E>(E), [JValueInt(start), JValueInt(end)])!;
   }
@@ -271,9 +271,9 @@ class JList<$E extends JObject?> extends JObject with ListMixin<$E> {
   @override
   int lastIndexOf(Object? element, [int? start]) {
     if (element is! JObject?) return -1;
-    if (start == null || start >= this.length) start = this.length - 1;
+    if (start == null || start >= length) start = length - 1;
     final elementRef = element?.reference ?? jNullReference;
-    if (start == this.length - 1) {
+    if (start == length - 1) {
       return _lastIndexOfId(this, const jintType(), [elementRef.pointer]);
     }
     final range = getRange(0, start);

pkgs/jni/pubspec.yaml

@@ -4,7 +4,7 @@
 
 name: jni
 description: A library to access JNI from Dart and Flutter that acts as a support library for package:jnigen.
-version: 0.14.2
+version: 0.14.3-wip
 repository: https://github.com/dart-lang/native/tree/main/pkgs/jni
 issue_tracker: https://github.com/dart-lang/native/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Ajni
 
@@ -28,7 +28,7 @@ dependencies:
   plugin_platform_interface: ^2.1.8
 
 dev_dependencies:
-  dart_flutter_team_lints: ^3.2.0
+  dart_flutter_team_lints: ^3.5.2
   ## Pin ffigen version because we are depending on internal APIs.
   ffigen: 16.1.0
   logging: ^1.2.0

pkgs/jnigen/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 0.15.0-wip
 
 - **Breaking Change**: Removed `exclude` from config.
+- Update to the latest lints.
 
 ## 0.14.2
 

pkgs/jnigen/android_test_runner/pubspec.yaml

@@ -50,7 +50,7 @@ dev_dependencies:
   # activated in the `analysis_options.yaml` file located at the root of your
   # package. See that file for information about deactivating specific lint
   # rules and activating additional ones.
-  flutter_lints: ^3.0.2
+  flutter_lints: ^6.0.0
 
 # For information on the generic Dart part of this file, see the
 # following page: https://dart.dev/tools/pub/pubspec

pkgs/jnigen/example/in_app_java/pubspec.yaml

@@ -26,7 +26,7 @@ dev_dependencies:
   jnigen:
     path: ../../
 
-  flutter_lints: ^3.0.2
+  flutter_lints: ^6.0.0
 
 flutter:
 

pkgs/jnigen/example/kotlin_plugin/example/pubspec.yaml

@@ -22,7 +22,7 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
 
-  flutter_lints: ^3.0.2
+  flutter_lints: ^6.0.0
 
 flutter:
   uses-material-design: true

pkgs/jnigen/example/kotlin_plugin/pubspec.yaml

@@ -20,7 +20,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  flutter_lints: ^3.0.2
+  flutter_lints: ^6.0.0
   jnigen:
     path: ../../