[native_doc_dartifier] Add more end-to-end tests (#2420)

* The initialization and call to an inner Java class inside some outer class.
* The use of strings correctly using toJString() and toDartString()
* The use of identifiers that start with '_'
* The use of identifiers that have some '$'

Author: marshelino-maged

.github/workflows/native_doc_dartifier.yaml

@@ -40,9 +40,15 @@ jobs:
       - name: Analyze code
         run: dart analyze --fatal-infos
         if: always() && steps.install.outcome == 'success'
-      - name: Run pre-test tool
-        run: dart run tool/prepare_dartify_test.dart
+      - name: Compile Java code
+        run: dart run tool/compile_java.dart
         if: always() && steps.install.outcome == 'success'
       - name: Run VM tests
         run: dart test --platform vm
         if: always() && steps.install.outcome == 'success'
+      - name: Regenerate bindings and dartified snippets
+        run: dart run tool/prepare_dartify_test.dart
+        if: always() && steps.install.outcome == 'success'
+      - name: Run VM tests again
+        run: dart test --platform vm
+        if: always() && steps.install.outcome == 'success'

pkgs/native_doc_dartifier/test/dartify_simple_cases/dartified_snippets/identifiers.dart

@@ -0,0 +1,7 @@
+// AUTO GENERATED BY NATIVE_DOC_DARTIFIER. DO NOT EDIT!
+// Regenerate this file by running tool/prepare_dartify_test.dart
+
+import '../bindings.dart';
+
+bool identifiersSpecialCases() =>
+    Example.has$$dollar$$sign + Example.$_startsWithUnderscore == 3;

pkgs/native_doc_dartifier/test/dartify_simple_cases/dartified_snippets/inner_class.dart

@@ -0,0 +1,13 @@
+// AUTO GENERATED BY NATIVE_DOC_DARTIFIER. DO NOT EDIT!
+// Regenerate this file by running tool/prepare_dartify_test.dart
+
+import '../bindings.dart';
+
+bool innerClassCall() {
+  final acc1 = Accumulator$DoublingAccumulator(Accumulator());
+  acc1.add(10);
+  acc1.add$1(10, 10);
+  acc1.add$2(10, 10, 10);
+
+  return acc1.accumulator == 120;
+}

pkgs/native_doc_dartifier/test/dartify_simple_cases/dartified_snippets/strings.dart

@@ -0,0 +1,13 @@
+// AUTO GENERATED BY NATIVE_DOC_DARTIFIER. DO NOT EDIT!
+// Regenerate this file by running tool/prepare_dartify_test.dart
+
+import 'package:jni/jni.dart';
+import '../bindings.dart';
+
+bool backAndForthStrings() {
+  final name = 'World'.toJString();
+  final example = Example();
+  final greeting = example.greet(name)?.toDartString();
+  print(greeting);
+  return greeting == 'Hello World';
+}

pkgs/native_doc_dartifier/test/dartify_simple_cases/java/com/Accumulator.java

@@ -1,6 +1,27 @@
 package com;
 
 public class Accumulator {
+
+    public class DoublingAccumulator {
+        public int accumulator;
+
+        public DoublingAccumulator() {
+            this.accumulator = 0;
+        }
+
+        public void add(int value) {
+            this.accumulator += value * 2;
+        }
+
+        public void add(int value1, int value2) {
+            this.accumulator += (value1 + value2) * 2;
+        }
+
+        public void add(int value1, int value2, int value3) {
+            this.accumulator += (value1 + value2 + value3) * 2;
+        }
+    }
+
     public int accumulator;
 
     public Accumulator() {

pkgs/native_doc_dartifier/test/dartify_simple_cases/java_snippets.dart

@@ -21,6 +21,36 @@ Boolean overloadedMethods() {
   },
   {
     'code': '''
+Boolean innerClassCall() {
+    DoublingAccumulator acc1 = new DoublingAccumulator();
+    acc1.add(10);
+    acc1.add(10, 10);
+    acc1.add(10, 10, 10);
+
+    return acc1.accumulator == 120;
+}''',
+    'fileName': 'inner_class.dart',
+  },
+  {
+    'code': '''
+Boolean backAndForthStrings(){
+    String name = "World";
+    Example example = new Example();
+    String greeting = example.greet(name);
+    System.out.println(greeting);
+    return greeting == "Hello World";
+}''',
+    'fileName': 'strings.dart',
+  },
+  {
+    'code': '''
+Boolean identifiersSpecialCases(){
+    return Example.has\$dollar\$sign() + Example._startsWithUnderscore() == 3;
+}''',
+    'fileName': 'identifiers.dart',
+  },
+  {
+    'code': '''
 Boolean useEnums() {
     Example example = new Example();
     Boolean isTrueUsage = example.enumValueToString(Operation.ADD) == "Addition";

pkgs/native_doc_dartifier/test/dartify_simple_cases/runtime_test.dart

@@ -8,9 +8,12 @@ import 'package:jni/jni.dart';
 import 'package:test/test.dart';
 
 import 'dartified_snippets/enums.dart';
+import 'dartified_snippets/identifiers.dart';
 import 'dartified_snippets/implement_inline_interface.dart';
 import 'dartified_snippets/implement_normal_interface.dart';
+import 'dartified_snippets/inner_class.dart';
 import 'dartified_snippets/overloaded_methods.dart';
+import 'dartified_snippets/strings.dart';
 
 void main() {
   setUpAll(() {
@@ -32,6 +35,18 @@ void main() {
     expect(overloadedMethods(), isTrue);
   });
 
+  test('Inner Class Call', () async {
+    expect(innerClassCall(), isTrue);
+  });
+
+  test('Back and Forth Strings', () async {
+    expect(backAndForthStrings(), isTrue);
+  });
+
+  test('identifiers has \$ and starts with "_"', () async {
+    expect(identifiersSpecialCases(), isTrue);
+  });
+
   test('Implement Inline Interface', () async {
     expect(implementInlineInterface(), isTrue);
   });

pkgs/native_doc_dartifier/tool/compile_java.dart

@@ -0,0 +1,6 @@
+import 'prepare_dartify_test.dart';
+
+void main() {
+  print('Compiling Java package...');
+  compileJavaPackage();
+}

pkgs/native_doc_dartifier/tool/prepare_dartify_test.dart

@@ -68,7 +68,20 @@ void generateDartSnippets() async {
     if (!outputFile.parent.existsSync()) {
       outputFile.parent.createSync(recursive: true);
     }
-    outputFile.writeAsStringSync('import \'../bindings.dart\';\n\n$dartCode');
+    final content = '''
+// AUTO GENERATED BY NATIVE_DOC_DARTIFIER. DO NOT EDIT!
+// Regenerate this file by running tool/prepare_dartify_test.dart
+
+import 'package:jni/jni.dart';
+import '../bindings.dart';
+
+  $dartCode
+  ''';
+    outputFile.writeAsStringSync(content);
+
+    Process.runSync('dart', ['fix', '--apply', outputFile.absolute.path]);
+
+    Process.runSync('dart', ['format', outputFile.absolute.path]);
   }
 }