[pub_formats] Fix regex for executable keys (#2469)

Author: dcharkes

pkgs/pub_formats/doc/schema/pubspec.schema.json

@@ -41,7 +41,7 @@
       "type": "object",
       "additionalProperties": false,
       "patternProperties": {
-        "^[a-zA-Z_]\\w*$": {
+        "^[a-zA-Z_]\\w*(-[a-zA-Z_]\\w*)*$": {
           "oneOf": [
             {
               "description": "If null, the main file is lib/<package_name>.dart.",

pkgs/pub_formats/lib/src/pubspec_syntax.g.dart

@@ -503,7 +503,9 @@ class PubspecYamlFileSyntax extends JsonObjectSyntax {
     return environment.validate();
   }
 
-  static final _executablesKeyPattern = RegExp(r'^[a-zA-Z_]\w*$');
+  static final _executablesKeyPattern = RegExp(
+    r'^[a-zA-Z_]\w*(-[a-zA-Z_]\w*)*$',
+  );
 
   static final _executablesValuePattern = RegExp(r'^[^/\\]*$');
 

pkgs/pub_formats/test/pubspec_test.dart

@@ -59,7 +59,10 @@ void main() {
     expect(someSdkDependency2.sdk, equals('flutter'));
     expect(syntax.dependencyOverrides, isNull);
     expect(syntax.executables, isNotNull);
-    expect(syntax.executables, equals({'slidy': 'main', 'fvm': null}));
+    expect(
+      syntax.executables,
+      equals({'slidy': 'main', 'fvm': null, 'dart-apitool': 'main'}),
+    );
     expect(syntax.publishTo, equals('none'));
     expect(syntax.documentation, isNull);
     expect(syntax.issueTracker, isNull);
@@ -103,7 +106,7 @@ void main() {
     expect(
       syntaxError2.validate(),
       equals([
-        "Unexpected key 'invalid executable name' in 'executables'. Expected a key satisfying ^[a-zA-Z_]\\w*\$.",
+        "Unexpected key 'invalid executable name' in 'executables'. Expected a key satisfying ^[a-zA-Z_]\\w*(-[a-zA-Z_]\\w*)*\$.",
       ]),
     );
     expect(() => syntaxError2.executables, throwsFormatException);

pkgs/pub_formats/test_data/pubspec_1.yaml

@@ -38,6 +38,7 @@ dev_dependencies:
 executables:
   slidy: main
   fvm:
+  dart-apitool: main
 
 # Hook user-defines are specified in the pub workspace.
 hooks: