Skip to content

Commit 7be4153

Browse files
authored
Allow inspectDir method to use a custom logger. (#1410)
1 parent 4af97f7 commit 7be4153

File tree

4 files changed

+22
-9
lines changed

4 files changed

+22
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.22.14
2+
3+
- Accept `logger` in `PackageAnalyzer.inspectDir` method.
4+
15
## 0.22.13
26

37
- Pass-through for `formatter/page_width` in `analysis_options.yaml`.

lib/src/package_analyzer.dart

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,23 @@ class PackageAnalyzer {
8989
}, logger: logger);
9090
}
9191

92-
Future<Summary> inspectDir(String packageDir, {InspectOptions? options}) {
92+
Future<Summary> inspectDir(
93+
String packageDir, {
94+
InspectOptions? options,
95+
Logger? logger,
96+
}) {
9397
final sharedContext = _createSharedContext(options: options);
94-
return withTempDir((tempDir) async {
95-
final rootDir = await _detectGitRoot(packageDir) ?? packageDir;
96-
await copyDir(rootDir, tempDir);
97-
final relativeDir = path.relative(packageDir, from: rootDir);
98-
return await _inspect(sharedContext, path.join(tempDir, relativeDir));
99-
});
98+
return withLogger(
99+
logger: logger,
100+
() async {
101+
return withTempDir((tempDir) async {
102+
final rootDir = await _detectGitRoot(packageDir) ?? packageDir;
103+
await copyDir(rootDir, tempDir);
104+
final relativeDir = path.relative(packageDir, from: rootDir);
105+
return await _inspect(sharedContext, path.join(tempDir, relativeDir));
106+
});
107+
},
108+
);
100109
}
101110

102111
SharedAnalysisContext _createSharedContext({

lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: pana
22
description: PAckage aNAlyzer - produce a report summarizing the health and quality of a Dart package.
3-
version: 0.22.13
3+
version: 0.22.14-dev
44
repository: https://github.com/dart-lang/pana
55
topics:
66
- tool

0 commit comments

Comments
 (0)