Skip to content

Commit 031c368

Browse files
authored
Use pana's ApiElement to decide if something is top-level reference. (#8332)
1 parent 7729dba commit 031c368

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

app/lib/search/backend.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -574,20 +574,20 @@ SearchForm? canonicalizeSearchForm(SearchForm form) {
574574

575575
/// Creates the index-related API data structure from the extracted dartdoc data.
576576
List<ApiDocPage> apiDocPagesFromPubData(PubDartdocData pubData) {
577-
final nameToHrefMap = <String, String>{};
577+
final nameToApiElementMap = <String, ApiElement>{};
578578
pubData.apiElements!.forEach((e) {
579579
final href = e.href;
580580
if (href != null) {
581-
nameToHrefMap[e.qualifiedName] = href;
581+
nameToApiElementMap[e.qualifiedName] = e;
582582
}
583583
});
584584

585585
final pathMap = <String, String?>{};
586586
final symbolMap = <String, Set<String>>{};
587587

588-
bool isTopLevelHref(String? href) {
588+
bool isTopLevelApiElement(ApiElement? href) {
589589
if (href == null) return false;
590-
return href.endsWith('-class.html') || href.endsWith('-library.html');
590+
return href.isClass || href.isLibrary;
591591
}
592592

593593
void update(String key, String symbol, String? documentation) {
@@ -599,12 +599,12 @@ List<ApiDocPage> apiDocPagesFromPubData(PubDartdocData pubData) {
599599
}
600600

601601
pubData.apiElements!.forEach((apiElement) {
602-
if (isTopLevelHref(apiElement.href)) {
602+
if (isTopLevelApiElement(apiElement)) {
603603
pathMap[apiElement.qualifiedName] = apiElement.href;
604604
update(
605605
apiElement.qualifiedName, apiElement.name, apiElement.documentation);
606606
} else if (apiElement.parent != null &&
607-
isTopLevelHref(nameToHrefMap[apiElement.parent])) {
607+
isTopLevelApiElement(nameToApiElementMap[apiElement.parent])) {
608608
update(apiElement.parent!, apiElement.name, apiElement.documentation);
609609
}
610610
});

0 commit comments

Comments
 (0)