Skip to content

Commit 0466076

Browse files
committed
Lookup SDK versions concurrently
1 parent ba053e6 commit 0466076

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

app/lib/package/backend.dart

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1073,13 +1073,12 @@ class PackageBackend {
10731073
}) async {
10741074
final sw = Stopwatch()..start();
10751075
final newVersion = entities.packageVersion;
1076-
final currentDartSdk = await getCachedDartSdkVersion(
1077-
lastKnownStable: toolStableDartSdkVersion);
1078-
final currentFlutterSdk = await getCachedFlutterSdkVersion(
1079-
lastKnownStable: toolStableFlutterSdkVersion);
1076+
final [currentDartSdk, currentFlutterSdk] = await Future.wait([
1077+
getCachedDartSdkVersion(lastKnownStable: toolStableDartSdkVersion),
1078+
getCachedFlutterSdkVersion(lastKnownStable: toolStableFlutterSdkVersion),
1079+
]);
10801080
final existingPackage = await lookupPackage(newVersion.package);
10811081
final isNew = existingPackage == null;
1082-
10831082
// check authorizations before the transaction
10841083
await _requireUploadAuthorization(
10851084
agent, existingPackage, newVersion.version!);
@@ -1102,14 +1101,12 @@ class PackageBackend {
11021101
throw AssertionError(
11031102
'Package "${newVersion.package}" has no admin email to notify.');
11041103
}
1105-
11061104
// check rate limits before the transaction
11071105
await verifyPackageUploadRateLimit(
11081106
agent: agent,
11091107
package: newVersion.package,
11101108
isNew: isNew,
11111109
);
1112-
11131110
final email = createPackageUploadedEmail(
11141111
packageName: newVersion.package,
11151112
packageVersion: newVersion.version!,
@@ -1118,7 +1115,6 @@ class PackageBackend {
11181115
uploaderEmails.map((email) => EmailAddress(email)).toList(),
11191116
);
11201117
final outgoingEmail = emailBackend.prepareEntity(email);
1121-
11221118
Package? package;
11231119
final existingVersions = await db
11241120
.query<PackageVersion>(ancestorKey: newVersion.packageKey!)

0 commit comments

Comments
 (0)