Log date of finished download counts processing (#8074)

Author: szakarias

app/lib/service/download_counts/sync_download_counts.dart

@@ -72,6 +72,7 @@ Future<Set<String>> processDownloadCounts(DateTime date) async {
   }
 
   final processedPackages = <String>{};
+  final processedPackagesWithErrors = <String>{};
   final pool = Pool(10);
   for (final f in bucketEntries) {
     final fileName = f.name;
@@ -169,6 +170,7 @@ Future<Set<String>> processDownloadCounts(DateTime date) async {
                     '$package-$version appeared in download counts data but does'
                     ' not exist');
               }
+              processedPackagesWithErrors.add(package);
             }
           });
 
@@ -183,6 +185,7 @@ Future<Set<String>> processDownloadCounts(DateTime date) async {
                 'Package $package appeared in download counts data for file '
                 '$fileName but does not exist.\n'
                 'Error: $e');
+            processedPackagesWithErrors.add(package);
             return;
           } // else {
           // The package is either invisible, tombstoned or has no versions.
@@ -215,6 +218,12 @@ Future<Set<String>> processDownloadCounts(DateTime date) async {
     });
   }));
 
+  final filesString = bucketEntries.length == 1 ? 'file' : 'files';
+  _logger.info('Finished processing download counts for date $date:');
+  _logger.info('  - ${failedFiles.length} out of ${bucketEntries.length} '
+      '$filesString failed during processing.');
+  _logger.info('  - ${processedPackages.length} packages processed including '
+      '${processedPackagesWithErrors.length} packages with errors.');
   return failedFiles;
 }
 

app/test/service/download_counts/download_counts_test.dart

@@ -376,9 +376,8 @@ void main() {
       } finally {
         await subscription.cancel();
       }
-
       expect(
-          messages.first,
+          messages[messages.length - 2],
           contains('Failed to read any files with prefix '
               '"daily_download_counts/'
               '${formatDateForFileName(skippedDate)}'