ignore server message

Author: isoos

pkg/pub_integration/lib/src/fake_test_context_provider.dart

@@ -30,7 +30,9 @@ class TestContextProvider {
     this._testBrowser,
   );
 
-  static Future<TestContextProvider> start() async {
+  static Future<TestContextProvider> start({
+    List<IgnoreMessageFilter>? ignoreServerErrors,
+  }) async {
     final fakePubServerProcess = await FakePubServerProcess.start();
     await fakePubServerProcess.started;
     final origin = 'http://localhost:${fakePubServerProcess.port}';
@@ -42,7 +44,11 @@ class TestContextProvider {
       Isolate.current.hashCode,
     ].join('-');
 
-    final testBrowser = TestBrowser(origin: origin, testName: testName);
+    final testBrowser = TestBrowser(
+      origin: origin,
+      testName: testName,
+      ignoreServerErrors: ignoreServerErrors,
+    );
     await testBrowser.startBrowser();
     return TestContextProvider._(origin, fakePubServerProcess, testBrowser);
   }

pkg/pub_integration/lib/src/test_browser.dart

@@ -12,6 +12,9 @@ import 'package:puppeteer/puppeteer.dart';
 import 'package:puppeteer_screenshots/puppeteer_utils.dart';
 import 'package:retry/retry.dart';
 
+/// Filters server or client messages, ignoring and not reporting them as errors.
+typedef IgnoreMessageFilter = bool Function(String message);
+
 /// Creates and tracks the headless Chrome environment, its temp directories and
 /// and uncaught exceptions.
 class TestBrowser {
@@ -31,14 +34,19 @@ class TestBrowser {
   /// The coverage report of CSS files.
   final _cssCoverages = <String, _Coverage>{};
 
+  /// Filters to ignore server errors.
+  final List<IgnoreMessageFilter>? _ignoreServerErrors;
+
   TestBrowser({
     required String origin,
     String? testName,
     String? coverageDir,
     bool displayBrowser = false,
+    List<IgnoreMessageFilter>? ignoreServerErrors,
   }) : _displayBrowser = displayBrowser,
        _testName = testName,
        _origin = origin,
+       _ignoreServerErrors = ignoreServerErrors,
        _coverageDir = coverageDir ?? Platform.environment['COVERAGE_DIR'],
        _tempDir = Directory.systemTemp.createTempSync('pub-headless');
 
@@ -177,10 +185,7 @@ class TestBrowserSession {
   TestBrowserSession(this._browser, this._context);
 
   /// Creates a new page and setup overrides and tracking.
-  Future<R> withPage<R>({
-    required Future<R> Function(Page page) fn,
-    bool Function(String message)? serverErrorFilter,
-  }) async {
+  Future<R> withPage<R>({required Future<R> Function(Page page) fn}) async {
     final clientErrors = <ClientError>[];
     final serverErrors = <String>[];
     final page = await _context.newPage();
@@ -300,8 +305,10 @@ class TestBrowserSession {
       if (clientErrors.isNotEmpty) {
         throw Exception('Client errors detected: ${clientErrors.first}');
       }
-      if (serverErrorFilter != null) {
-        serverErrors.retainWhere(serverErrorFilter);
+      if (_browser._ignoreServerErrors != null) {
+        serverErrors.removeWhere(
+          (msg) => _browser._ignoreServerErrors!.any((fn) => fn(msg)),
+        );
       }
       if (serverErrors.isNotEmpty) {
         throw Exception(

pkg/pub_integration/test/search_update_test.dart

@@ -18,7 +18,16 @@ void main() {
     final httpClient = http.Client();
 
     setUpAll(() async {
-      fakeTestScenario = await TestContextProvider.start();
+      fakeTestScenario = await TestContextProvider.start(
+        ignoreServerErrors: [
+          // NOTE: This message seems to be a race condition.
+          //       Investigate if this can be safely ignored (e.g. it is retried).
+          (msg) => msg.contains(
+            '/packages?q=platform%3Aandroid&open-sections=sdks returned bad HTML: '
+            'No data found for resource with given identifier',
+          ),
+        ],
+      );
     });
 
     tearDownAll(() async {