Move asserts from initializer list to body

Author: parlough

app/lib/search/token_index.dart

@@ -40,8 +40,8 @@ class TokenIndex<K> {
     List<K> ids,
     List<String?> values, {
     bool skipDocumentWeight = false,
-  })  : _ids = ids,
-        assert(ids.length == values.length) {
+  }) : _ids = ids {
+    assert(ids.length == values.length);
     final length = values.length;
     for (var i = 0; i < length; i++) {
       final text = values[i];

app/lib/tool/neat_task/datastore_status_provider.dart

@@ -48,6 +48,7 @@ class NeatTaskStatus extends db.ExpandoModel<String> {
         runtimeVersion =
             _runtimeVersion(name, isRuntimeVersioned: isRuntimeVersioned),
         updated = clock.now().toUtc() {
+    // Not in initializer list as id is declared in a super class.
     id = _compositeId(name, isRuntimeVersioned: isRuntimeVersioned);
   }
 }

pkg/_popularity/lib/popularity.dart

@@ -70,9 +70,10 @@ class VoteData {
 
   int get score => _score(this);
 
-  VoteData(this.direct, this.dev, this.total)
-      : assert(direct >= 0 && direct <= total),
-        assert(dev >= 0 && dev <= total);
+  VoteData(this.direct, this.dev, this.total) {
+    assert(direct >= 0 && direct <= total);
+    assert(dev >= 0 && dev <= total);
+  }
 
   factory VoteData.fromJson(Map<String, dynamic> json) =>
       _$VoteDataFromJson(json);