Skip to content

Commit 4b42fbc

Browse files
committed
cleanup
1 parent 69d649f commit 4b42fbc

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

app/lib/service/download_counts/backend.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,11 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'dart:math';
6-
7-
import 'package:basics/basics.dart';
85
import 'package:gcloud/service_scope.dart' as ss;
9-
import 'package:gcloud/storage.dart';
106
import 'package:pub_dev/service/download_counts/download_counts.dart';
117
import 'package:pub_dev/service/download_counts/models.dart';
12-
import 'package:pub_dev/shared/configuration.dart';
138
import 'package:pub_dev/shared/datastore.dart';
149
import 'package:pub_dev/shared/redis_cache.dart';
15-
import 'package:pub_dev/shared/storage.dart';
16-
import 'package:pub_dev/shared/utils.dart';
1710

1811
/// Sets the download counts backend service.
1912
void registerDownloadCountsBackend(DownloadCountsBackend backend) =>

app/lib/service/download_counts/compute_30_days_total_counts.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import 'package:pub_dev/shared/utils.dart';
1414
Future<void> compute30DaysTotalTask() async {
1515
final allDownloadCounts = await downloadCountsBackend.listAllDownloadCounts();
1616
final totals = await compute30DayTotals(allDownloadCounts);
17-
await updload30DaysTotal(totals);
17+
await upload30DaysTotal(totals);
1818
}
1919

2020
Future<Map<String, int>> compute30DayTotals(
@@ -36,7 +36,7 @@ int compute30DayTotal(DownloadCounts downloadCounts) {
3636

3737
final downloadCounts30DaysTotalsFileName = 'download-counts-30-days-total.json';
3838

39-
Future<void> updload30DaysTotal(Map<String, int> counts) async {
39+
Future<void> upload30DaysTotal(Map<String, int> counts) async {
4040
final reportsBucket =
4141
storageService.bucket(activeConfiguration.reportsBucketName!);
4242
await uploadBytesWithRetry(reportsBucket, downloadCounts30DaysTotalsFileName,

app/test/service/download_counts/compute_total_download_counts_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ void main() {
8787
});
8888

8989
testWithProfile('succesful 30 day totals upload', fn: () async {
90-
await updload30DaysTotal({'foo': 70, 'bar': 105, 'baz': 140});
90+
await upload30DaysTotal({'foo': 70, 'bar': 105, 'baz': 140});
9191

9292
final data = await storageService
9393
.bucket(activeConfiguration.reportsBucketName!)

0 commit comments

Comments
 (0)