Add a few init related lints from recommended set

parlough · parlough · commit 4e505d827fe9 · 2024-12-09T17:07:25.000+05:30
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -43,6 +43,7 @@ linter:
     - prefer_final_locals
     - prefer_for_elements_to_map_fromIterable
     - prefer_if_null_operators
+    - prefer_initializing_formals
     - prefer_null_aware_operators
     - prefer_single_quotes
     - prefer_spread_collections
@@ -63,3 +64,4 @@ linter:
     - unnecessary_this
     - use_function_type_syntax_for_parameters
     - use_rethrow_when_possible
+    - use_super_parameters
diff --git a/app/lib/fake/backend/fake_pub_worker.dart b/app/lib/fake/backend/fake_pub_worker.dart
@@ -314,7 +314,7 @@ final class UploadException implements Exception {
 }
 
 final class IntermittentUploadException extends UploadException {
-  IntermittentUploadException(String message) : super(message);
+  IntermittentUploadException(super.message);
 }
 
 Summary _emptySummary(String package, String version) {
diff --git a/app/lib/package/api_export/exported_api.dart b/app/lib/package/api_export/exported_api.dart
@@ -482,10 +482,10 @@ final class ExportedJsonFile<T> extends ExportedObject {
   final Duration _maxAge;
 
   ExportedJsonFile._(
-    ExportedApi _owner,
-    String _objectName,
+    super._owner,
+    super._objectName,
     this._maxAge,
-  ) : super._(_owner, _objectName);
+  ) : super._();
 
   ObjectMetadata _metadata() {
     return ObjectMetadata(
@@ -531,12 +531,12 @@ final class ExportedBlob extends ExportedObject {
   final String _filename;
 
   ExportedBlob._(
-    ExportedApi _owner,
-    String _objectName,
+    super._owner,
+    super._objectName,
     this._filename,
     this._contentType,
     this._maxAge,
-  ) : super._(_owner, _objectName);
+  ) : super._();
 
   ObjectMetadata _metadata() {
     return ObjectMetadata(
diff --git a/app/lib/package/model_properties.dart b/app/lib/package/model_properties.dart
@@ -236,8 +236,8 @@ class MinSdkVersion {
 }
 
 class PubspecProperty extends StringProperty {
-  const PubspecProperty({String? propertyName, bool required = false})
-      : super(propertyName: propertyName, required: required, indexed: false);
+  const PubspecProperty({super.propertyName, super.required = false})
+      : super(indexed: false);
 
   @override
   bool validate(ModelDB db, Object? value) =>
diff --git a/app/lib/package/models.dart b/app/lib/package/models.dart
@@ -484,8 +484,8 @@ class AutomatedPublishing {
 /// A [db.Property] encoding [AutomatedPublishing] as JSON.
 class AutomatedPublishingProperty extends db.Property {
   const AutomatedPublishingProperty(
-      {String? propertyName, bool required = false})
-      : super(propertyName: propertyName, required: required, indexed: false);
+      {super.propertyName, super.required = false})
+      : super(indexed: false);
 
   @override
   Object? encodeValue(
diff --git a/app/lib/search/search_service.dart b/app/lib/search/search_service.dart
@@ -339,10 +339,9 @@ class PackageSearchResult {
     List<SdkLibraryHit>? sdkLibraryHits,
     List<PackageHit>? packageHits,
     this.errorMessage,
-    int? statusCode,
+    this.statusCode,
   })  : packageHits = packageHits ?? <PackageHit>[],
-        sdkLibraryHits = sdkLibraryHits ?? <SdkLibraryHit>[],
-        statusCode = statusCode;
+        sdkLibraryHits = sdkLibraryHits ?? <SdkLibraryHit>[];
 
   PackageSearchResult.error({
     required this.errorMessage,
diff --git a/app/lib/search/token_index.dart b/app/lib/search/token_index.dart
@@ -40,8 +40,8 @@ class TokenIndex<K> {
     List<K> ids,
     List<String?> values, {
     bool skipDocumentWeight = false,
-  }) : _ids = ids {
-    assert(ids.length == values.length);
+  })  : _ids = ids,
+        assert(ids.length == values.length) {
     final length = values.length;
     for (var i = 0; i < length; i++) {
       final text = values[i];
diff --git a/app/lib/service/download_counts/models.dart b/app/lib/service/download_counts/models.dart
@@ -16,8 +16,8 @@ class DownloadCounts extends db.ExpandoModel<String> {
 }
 
 class CountDataProperty extends db.Property {
-  const CountDataProperty({String? propertyName, bool required = false})
-      : super(propertyName: propertyName, required: required, indexed: false);
+  const CountDataProperty({super.propertyName, super.required = false})
+      : super(indexed: false);
 
   @override
   Object? decodePrimitiveValue(db.ModelDB db, Object? value) {
diff --git a/app/lib/service/security_advisories/models.dart b/app/lib/service/security_advisories/models.dart
@@ -49,8 +49,8 @@ class SecurityAdvisory extends db.Model<String> {
 }
 
 class OSVProperty extends db.Property {
-  const OSVProperty({String? propertyName, bool required = false})
-      : super(propertyName: propertyName, required: required, indexed: false);
+  const OSVProperty({super.propertyName, super.required = false})
+      : super(indexed: false);
 
   @override
   Object? decodePrimitiveValue(db.ModelDB db, Object? value) {
diff --git a/app/lib/shared/exceptions.dart b/app/lib/shared/exceptions.dart
@@ -24,14 +24,12 @@ abstract class ResponseException extends ApiResponseException {
     int status,
     String code,
     String message, {
-    Map<String, Object>? body,
-    Map<String, Object>? headers,
+    super.body,
+    super.headers,
   }) : super(
           status: status,
           code: code,
           message: message,
-          body: body,
-          headers: headers,
         );
 
   @override
diff --git a/app/lib/shared/model_properties.dart b/app/lib/shared/model_properties.dart
@@ -10,8 +10,8 @@ class CompatibleListProperty<T> extends Property {
   final PrimitiveProperty subProperty;
 
   const CompatibleListProperty(this.subProperty,
-      {String? propertyName, bool indexed = true})
-      : super(propertyName: propertyName, required: true, indexed: indexed);
+      {super.propertyName, super.indexed})
+      : super(required: true);
 
   @override
   bool validate(ModelDB db, Object? value) {
diff --git a/app/lib/task/models.dart b/app/lib/task/models.dart
@@ -333,8 +333,8 @@ class PackageVersionStateInfo {
 /// A [db.Property] encoding a Map from version to [PackageVersionStateInfo] as JSON.
 class PackageVersionStateMapProperty extends db.Property {
   const PackageVersionStateMapProperty(
-      {String? propertyName, bool required = false})
-      : super(propertyName: propertyName, required: required, indexed: false);
+      {super.propertyName, super.required = false})
+      : super(indexed: false);
 
   @override
   Object? encodeValue(
@@ -442,8 +442,8 @@ class AbortedTokenInfo {
 
 /// A [db.Property] encoding a List os [AbortedTokenInfo] as JSON.
 class AbortedTokenListProperty extends db.Property {
-  const AbortedTokenListProperty({String? propertyName, bool required = false})
-      : super(propertyName: propertyName, required: required, indexed: false);
+  const AbortedTokenListProperty({super.propertyName, super.required = false})
+      : super(indexed: false);
 
   @override
   Object? encodeValue(
diff --git a/app/lib/tool/neat_task/datastore_status_provider.dart b/app/lib/tool/neat_task/datastore_status_provider.dart
@@ -42,12 +42,13 @@ class NeatTaskStatus extends db.ExpandoModel<String> {
 
   NeatTaskStatus();
 
-  NeatTaskStatus.init(String name, {required bool isRuntimeVersioned}) {
-    this.name = name;
-    runtimeVersion =
-        _runtimeVersion(name, isRuntimeVersioned: isRuntimeVersioned);
+  NeatTaskStatus.init(String name, {required bool isRuntimeVersioned})
+      // ignore: prefer_initializing_formals
+      : name = name,
+        runtimeVersion =
+            _runtimeVersion(name, isRuntimeVersioned: isRuntimeVersioned),
+        updated = clock.now().toUtc() {
     id = _compositeId(name, isRuntimeVersioned: isRuntimeVersioned);
-    updated = clock.now().toUtc();
   }
 }
 
diff --git a/pkg/_popularity/lib/popularity.dart b/pkg/_popularity/lib/popularity.dart
@@ -70,10 +70,9 @@ class VoteData {
 
   int get score => _score(this);
 
-  VoteData(this.direct, this.dev, this.total) {
-    assert(direct >= 0 && direct <= total);
-    assert(dev >= 0 && dev <= total);
-  }
+  VoteData(this.direct, this.dev, this.total)
+      : assert(direct >= 0 && direct <= total),
+        assert(dev >= 0 && dev <= total);
 
   factory VoteData.fromJson(Map<String, dynamic> json) =>
       _$VoteDataFromJson(json);
diff --git a/pkg/pub_worker/lib/src/upload.dart b/pkg/pub_worker/lib/src/upload.dart
@@ -88,11 +88,11 @@ final class UploadException implements Exception {
 }
 
 final class IntermittentUploadException extends UploadException {
-  IntermittentUploadException(String message) : super(message);
+  IntermittentUploadException(super.message);
 }
 
 final class TaskAbortedException extends UploadException {
-  TaskAbortedException(String message) : super(message);
+  TaskAbortedException(super.message);
 }
 
 /// Extract `error.code` from JSON body in [res].

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ final class UploadException implements Exception {`
`314`	`314`	`}`
`315`	`315`
`316`	`316`	`final class IntermittentUploadException extends UploadException {`
`317`		`- IntermittentUploadException(String message) : super(message);`
	`317`	`+ IntermittentUploadException(super.message);`
`318`	`318`	`}`
`319`	`319`
`320`	`320`	`Summary _emptySummary(String package, String version) {`
Original file line number	Diff line number	Diff line change
`@@ -236,8 +236,8 @@ class MinSdkVersion {`
`236`	`236`	`}`
`237`	`237`
`238`	`238`	`class PubspecProperty extends StringProperty {`
`239`		`- const PubspecProperty({String? propertyName, bool required = false})`
`240`		`- : super(propertyName: propertyName, required: required, indexed: false);`
	`239`	`+ const PubspecProperty({super.propertyName, super.required = false})`
	`240`	`+ : super(indexed: false);`
`241`	`241`
`242`	`242`	`@override`
`243`	`243`	`bool validate(ModelDB db, Object? value) =>`
Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,8 @@ class DownloadCounts extends db.ExpandoModel<String> {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`class CountDataProperty extends db.Property {`
`19`		`- const CountDataProperty({String? propertyName, bool required = false})`
`20`		`- : super(propertyName: propertyName, required: required, indexed: false);`
	`19`	`+ const CountDataProperty({super.propertyName, super.required = false})`
	`20`	`+ : super(indexed: false);`
`21`	`21`
`22`	`22`	`@override`
`23`	`23`	`Object? decodePrimitiveValue(db.ModelDB db, Object? value) {`
Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,8 @@ class SecurityAdvisory extends db.Model<String> {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`class OSVProperty extends db.Property {`
`52`		`- const OSVProperty({String? propertyName, bool required = false})`
`53`		`- : super(propertyName: propertyName, required: required, indexed: false);`
	`52`	`+ const OSVProperty({super.propertyName, super.required = false})`
	`53`	`+ : super(indexed: false);`
`54`	`54`
`55`	`55`	`@override`
`56`	`56`	`Object? decodePrimitiveValue(db.ModelDB db, Object? value) {`