Skip to content

Commit 50897e2

Browse files
committed
Set '_regenerateGoldens' flag to false
1 parent 2af406d commit 50897e2

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

app/test/task/end2end_test.dart

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import '../shared/utils.dart';
1919
const String goldenDir = 'test/task/testdata/goldens';
2020

2121
// TODO: generalize golden testing, use env var for regenerating all goldens.
22-
final _regenerateGoldens = true;
22+
final _regenerateGoldens = false;
2323

2424
// We use a small test profile without flutter packages, because we have to
2525
// run pana+dartdoc for all these package versions, naturally this is slow.
@@ -55,9 +55,7 @@ void main() {
5555
expect(doc.querySelector('.self-crumb')!.text, contains('oxygen'));
5656
// Check that we don't have noindex on /latest/
5757
expect(
58-
doc
59-
.querySelectorAll('meta')
60-
.where(
58+
doc.querySelectorAll('meta').where(
6159
(m) =>
6260
m.attributes['name'] == 'robots' &&
6361
m.attributes['content'] == 'noindex',
@@ -133,8 +131,8 @@ Future<void> _traverseLinksUnderPath({
133131
final r = relativeTo.resolveUri(u);
134132
return r.path;
135133
};
136-
final isUnderRoots = (String path) =>
137-
roots.any((root) => path.startsWith(root));
134+
final isUnderRoots =
135+
(String path) => roots.any((root) => path.startsWith(root));
138136

139137
final visited = <String>{};
140138
// HTML pages to visit
@@ -152,7 +150,8 @@ Future<void> _traverseLinksUnderPath({
152150
final res = await issueGet(target.toString(), headers: _headers);
153151
if (res.statusCode == 303) {
154152
htmlQueue.addAll(
155-
[normalize(res.headers['location']!, target)].nonNulls
153+
[normalize(res.headers['location']!, target)]
154+
.nonNulls
156155
.whereNot(visited.contains)
157156
.whereNot(htmlQueue.contains)
158157
.whereNot(assetQueue.contains),

0 commit comments

Comments
 (0)