Avoid caching security advisories

Author: jonasfj

app/lib/package/api_export/api_exporter.dart

@@ -180,9 +180,9 @@ class ApiExporter {
       return;
     }
 
-    // TODO: Consider skipping the cache when fetching security advisories
     final advisories = await securityAdvisoryBackend.listAdvisoriesResponse(
       package,
+      skipCache: true, // Skipping the cache when fetching security advisories
     );
 
     final versions = await packageBackend.tarballStorage

app/lib/service/security_advisories/backend.dart

@@ -39,22 +39,34 @@ class SecurityAdvisoryBackend {
   }
 
   Future<List<SecurityAdvisoryData>> lookupSecurityAdvisories(
-    String package,
-  ) async {
-    return (await cache.securityAdvisories(package).get(() async {
+    String package, {
+    bool skipCache = false,
+  }) async {
+    final loadAdvisories = () async {
       final query = _db.query<SecurityAdvisory>()
         ..filter('affectedPackages =', package);
       return query
           .run()
           .map((SecurityAdvisory adv) => SecurityAdvisoryData.fromModel(adv))
           .toList();
-    }))!;
+    };
+    if (skipCache) {
+      return await loadAdvisories();
+    }
+
+    return (await cache.securityAdvisories(package).get(loadAdvisories))!;
   }
 
   /// Create a [ListAdvisoriesResponse] for [package] using advisories from
   /// cache.
-  Future<ListAdvisoriesResponse> listAdvisoriesResponse(String package) async {
-    final advisories = await lookupSecurityAdvisories(package);
+  Future<ListAdvisoriesResponse> listAdvisoriesResponse(
+    String package, {
+    bool skipCache = false,
+  }) async {
+    final advisories = await lookupSecurityAdvisories(
+      package,
+      skipCache: skipCache,
+    );
     return ListAdvisoriesResponse(
       advisories: advisories.map((a) => a.advisory).toList(),
       advisoriesUpdated: advisories.map((a) => a.syncTime).maxOrNull,

app/test/service/security_advisory/security_advisory_test.dart

@@ -200,7 +200,10 @@ void main() {
     expect(advisory.syncTime!, ingestTime);
     expect(advisory.syncTime!.isBefore(afterIngestTime), isTrue);
 
-    final list = await securityAdvisoryBackend.lookupSecurityAdvisories('a');
+    final list = await securityAdvisoryBackend.lookupSecurityAdvisories(
+      'a',
+      skipCache: true,
+    );
     expect(list, isNotNull);
     expect(list.length, 1);
     expect(list.first.advisory.id, id);
@@ -229,10 +232,16 @@ void main() {
     expect(updatedAdvisory.affectedPackages!.first, affectedA.package.name);
     expect(updatedAdvisory.affectedPackages!.last, affectedC.package.name);
 
-    final list2 = await securityAdvisoryBackend.lookupSecurityAdvisories('b');
+    final list2 = await securityAdvisoryBackend.lookupSecurityAdvisories(
+      'b',
+      skipCache: true,
+    );
     expect(list2, isEmpty);
 
-    final list3 = await securityAdvisoryBackend.lookupSecurityAdvisories('c');
+    final list3 = await securityAdvisoryBackend.lookupSecurityAdvisories(
+      'c',
+      skipCache: true,
+    );
     expect(list3, isNotNull);
     expect(list3.length, 1);
     expect(list3.first.advisory.id, id);
@@ -269,12 +278,18 @@ void main() {
     expect(advisory.affectedPackages!.length, 1);
     expect(advisory.affectedPackages!.first, affectedA.package.name);
 
-    final list = await securityAdvisoryBackend.lookupSecurityAdvisories('a');
+    final list = await securityAdvisoryBackend.lookupSecurityAdvisories(
+      'a',
+      skipCache: true,
+    );
     expect(list, isNotNull);
     expect(list.length, 1);
     expect(list.first.advisory.id, id);
 
-    final list2 = await securityAdvisoryBackend.lookupSecurityAdvisories('b');
+    final list2 = await securityAdvisoryBackend.lookupSecurityAdvisories(
+      'b',
+      skipCache: true,
+    );
     expect(list2, isNotNull);
     expect(list2, isEmpty);
   });