Remove isBlocked-related admin operations. (#8357)

Author: isoos

app/lib/admin/actions/actions.dart

@@ -27,7 +27,6 @@ import 'package_reservation_delete.dart';
 import 'package_reservation_list.dart';
 import 'package_version_info.dart';
 import 'package_version_retraction.dart';
-import 'publisher_block.dart';
 import 'publisher_create.dart';
 import 'publisher_delete.dart';
 import 'publisher_info.dart';
@@ -114,7 +113,6 @@ final class AdminAction {
     packageReservationList,
     packageVersionInfo,
     packageVersionRetraction,
-    publisherBlock,
     publisherCreate,
     publisherDelete,
     publisherInfo,

app/lib/admin/actions/publisher_block.dart

@@ -35,14 +35,11 @@ import '../shared/versions.dart';
 import '../task/backend.dart';
 import 'actions/actions.dart' show AdminAction;
 import 'tools/delete_all_staging.dart';
-import 'tools/list_package_blocked.dart';
 import 'tools/list_tools.dart';
 import 'tools/notify_service.dart';
 import 'tools/package_publisher.dart';
 import 'tools/publisher_member.dart';
 import 'tools/recent_uploaders.dart';
-import 'tools/set_package_blocked.dart';
-import 'tools/set_user_blocked.dart';
 import 'tools/user_merger.dart';
 
 final _logger = Logger('pub.admin.backend');
@@ -59,14 +56,11 @@ typedef Tool = Future<String> Function(List<String> args);
 
 final Map<String, Tool> availableTools = {
   'delete-all-staging': executeDeleteAllStaging,
-  'list-package-blocked': executeListPackageBlocked,
   'notify-service': executeNotifyService,
   'package-publisher': executeSetPackagePublisher,
   'recent-uploaders': executeRecentUploaders,
   'publisher-member': executePublisherMember,
   'publisher-invite-member': executePublisherInviteMember,
-  'set-package-blocked': executeSetPackageBlocked,
-  'set-user-blocked': executeSetUserBlocked,
   'user-merger': executeUserMergerTool,
   'list-tools': executeListTools,
 };

app/lib/admin/backend.dart

@@ -413,16 +413,6 @@ class Package extends db.ExpandoModel<String> {
     );
   }
 
-  void updateIsBlocked({
-    required bool isBlocked,
-    String? reason,
-  }) {
-    this.isBlocked = isBlocked;
-    blockedReason = reason;
-    blocked = isBlocked ? clock.now().toUtc() : null;
-    updated = clock.now().toUtc();
-  }
-
   void updateIsModerated({
     required bool isModerated,
   }) {

app/lib/admin/tools/list_package_blocked.dart

@@ -91,15 +91,6 @@ class Publisher extends db.ExpandoModel<String> {
     isModerated = false;
   }
 
-  /// Clears most properties on the entity and sets the [isBlocked] flag.
-  void markForBlocked() {
-    isBlocked = true;
-    isAbandoned = true;
-    contactEmail = null;
-    description = '';
-    updated = clock.now().toUtc();
-  }
-
   /// Whether the publisher has a displayable description.
   bool get hasDescription => description != null && description!.isNotEmpty;
 

app/lib/admin/tools/set_package_blocked.dart

@@ -712,26 +712,6 @@ void main() {
         expect(rs3.isRetracted, v4.isRetracted);
       });
     });
-
-    group('block user', () {
-      setupTestsWithAdminTokenIssues(
-        (client) => client.adminExecuteTool(
-          'set-user-blocked',
-          '[email protected]/true',
-        ),
-      );
-
-      testWithProfile('block and unblock user', fn: () async {
-        final client = createPubApiClient(authToken: siteAdminToken);
-        await client.adminExecuteTool('set-user-blocked', '[email protected]/true');
-        final user = await accountBackend.lookupUserByEmail('[email protected]');
-        expect(user.isBlocked, true);
-        await client.adminExecuteTool(
-            'set-user-blocked', '${user.userId}/false');
-        final user2 = await accountBackend.lookupUserByEmail('[email protected]');
-        expect(user2.isBlocked, false);
-      });
-    });
   });
 }
 

app/lib/admin/tools/set_user_blocked.dart

@@ -147,7 +147,7 @@ void main() {
         },
       );
       final p = await packageBackend.lookupPackage('neon');
-      p!.updateIsBlocked(isBlocked: true, reason: 'spam');
+      p!.updateIsModerated(isModerated: true);
       expect(p.isVisible, isFalse);
       await dbService.commit(inserts: [p]);
       await nameTracker.reloadFromDatastore();
@@ -163,7 +163,7 @@ void main() {
       );
 
       // reverting to make sure integrity check is passing
-      p.updateIsBlocked(isBlocked: false);
+      p.updateIsModerated(isModerated: false);
       await dbService.commit(inserts: [p]);
     });
   });