Skip to content

Commit 6075d86

Browse files
committed
Fix automatic status on resolving an appeal.
1 parent 36f5179 commit 6075d86

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

app/lib/admin/actions/moderation_case_resolve.dart

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,20 @@ Closes the moderation case and updates the status based on the actions logged on
7272
final appealedCase = await tx.lookupValue<ModerationCase>(dbService
7373
.emptyKey
7474
.append(ModerationCase, id: mc.appealedCaseId!));
75-
final appealHadModeratedAction =
75+
final appealedCaseHadModeratedAction =
7676
appealedCase.getActionLog().hasModeratedAction();
77-
if (appealHadModeratedAction) {
78-
status = hasModeratedAction
79-
? ModerationStatus.moderationReverted
80-
: ModerationStatus.moderationUpheld;
77+
final compositeActionLog = ModerationActionLog(entries: [
78+
...appealedCase.getActionLog().entries,
79+
...mc.getActionLog().entries,
80+
]);
81+
final compositeHasModeratedAction =
82+
compositeActionLog.hasModeratedAction();
83+
if (appealedCaseHadModeratedAction) {
84+
status = compositeHasModeratedAction
85+
? ModerationStatus.moderationUpheld
86+
: ModerationStatus.moderationReverted;
8187
} else {
82-
status = hasModeratedAction
88+
status = compositeHasModeratedAction
8389
? ModerationStatus.noActionReverted
8490
: ModerationStatus.noActionUpheld;
8591
}

app/test/admin/moderation_case_resolve_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ void main() {
115115
reason: 'The package violated our policy.',
116116
);
117117

118-
final mc = await _prepare(apply: true, appealCaseId: mc1.caseId);
118+
final mc = await _prepare(apply: false, appealCaseId: mc1.caseId);
119119
expect(await _close(mc.caseId), 'moderation-reverted');
120120
});
121121

0 commit comments

Comments
 (0)