Skip to content

Commit 6103f56

Browse files
isoosisoos
committed
Remove null-safety badge.
1 parent afcbc43 commit 6103f56

File tree

13 files changed

+34
-127
lines changed

13 files changed

+34
-127
lines changed

‎app/lib/frontend/templates/package_misc.dart‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,6 @@ final nameMatchBadgeNode = packageBadgeNode(
3535
color: 'name-match',
3636
);
3737

38-
/// Renders the null-safe badge used by package listing and package page.
39-
d.Node nullSafeBadgeNode({String? title}) {
40-
return packageBadgeNode(
41-
label: 'Null safety',
42-
title: title ?? 'Supports the null safety language feature.',
43-
);
44-
}
45-
4638
/// Renders the Dart 3 compatible badge.
4739
final dart3CompatibleNode = packageBadgeNode(
4840
label: 'Dart 3 compatible',

‎app/lib/frontend/templates/views/pkg/header.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ d.Node packageHeaderNode({
2222
d.span(child: d.xAgoTimestamp(published)),
2323
d.text(' '),
2424
if (publisherId != null) ..._publisher(publisherId),
25-
if (isNullSafe && !isDart3Compatible) nullSafeBadgeNode(),
2625
if (isDart3Compatible) dart3CompatibleNode,
2726
if (isDart3Incompatible) dart3IncompatibleNode,
2827
if (releases != null) ..._releases(packageName, releases),

‎app/lib/frontend/templates/views/pkg/package_list.dart‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ d.Node _sdkLibraryItem(SdkLibraryHit hit) {
7373
text: sdkDict.libraryTypeLabel,
7474
),
7575
coreLibraryBadgeNode,
76-
nullSafeBadgeNode(),
7776
]),
7877
tagsNode: null,
7978
replacedBy: null,
@@ -94,7 +93,6 @@ d.Node _packageItem(
9493
required bool isLiked,
9594
}) {
9695
final isFlutterFavorite = view.tags.contains(PackageTags.isFlutterFavorite);
97-
final isNullSafe = view.tags.contains(PackageVersionTags.isNullSafe);
9896
final isDart3Compatible = view.tags.contains(
9997
PackageVersionTags.isDart3Compatible,
10098
);
@@ -157,7 +155,6 @@ d.Node _packageItem(
157155
if (licenseNode != null)
158156
d.span(classes: ['packages-metadata-block'], child: licenseNode),
159157
if (isFlutterFavorite) flutterFavoriteBadgeNode,
160-
if (isNullSafe && !isDart3Compatible) nullSafeBadgeNode(),
161158
if (isDart3Compatible) dart3CompatibleNode,
162159
if (isDart3Incompatible) dart3IncompatibleNode,
163160
]);

‎app/lib/frontend/templates/views/pkg/versions/version_row.dart‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import '../../../../../package/model_properties.dart';
99
import '../../../../../shared/urls.dart' as urls;
1010
import '../../../../dom/dom.dart' as d;
1111
import '../../../../static_files.dart';
12-
import '../../../package_misc.dart';
1312

1413
d.Node versionRowNode(
1514
String package,
@@ -31,11 +30,7 @@ d.Node versionRowNode(
3130
),
3231
d.td(
3332
classes: ['badge'],
34-
child: pubspec.hasOptedIntoNullSafety
35-
? nullSafeBadgeNode(
36-
title: 'Package version is opted into null safety.',
37-
)
38-
: null,
33+
child: null,
3934
),
4035
d.td(
4136
classes: ['sdk'],

‎app/test/frontend/golden/pkg_index_page.html‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,6 @@ <h3 class="packages-title pub-monochrome-icon-hoverable">
446446
<p class="packages-metadata">
447447
<span class="packages-metadata-block">Dart SDK library</span>
448448
<span class="package-badge">Core library</span>
449-
<span class="package-badge" title="Supports the null safety language feature.">Null safety</span>
450449
</p>
451450
</div>
452451
</div>

‎app/test/frontend/golden/pkg_versions_page.html‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,7 @@ <h2 id="stable">Stable versions of oxygen</h2>
249249
<td class="version">
250250
<a href="/packages/oxygen/versions/1.2.0" title="Visit oxygen 1.2.0 page">1.2.0</a>
251251
</td>
252-
<td class="badge">
253-
<span class="package-badge" title="Package version is opted into null safety.">Null safety</span>
254-
</td>
252+
<td class="badge"></td>
255253
<td class="sdk">3.0</td>
256254
<td class="uploaded">
257255
<a class="-x-ago" href="" title="%%version-created-date%%" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
@@ -271,9 +269,7 @@ <h2 id="stable">Stable versions of oxygen</h2>
271269
<td class="version">
272270
<a href="/packages/oxygen/versions/1.0.0" title="Visit oxygen 1.0.0 page">1.0.0</a>
273271
</td>
274-
<td class="badge">
275-
<span class="package-badge" title="Package version is opted into null safety.">Null safety</span>
276-
</td>
272+
<td class="badge"></td>
277273
<td class="sdk">3.0</td>
278274
<td class="uploaded">
279275
<a class="-x-ago" href="" title="%%version-created-date%%" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
@@ -316,9 +312,7 @@ <h2 id="prerelease">Prerelease versions of oxygen</h2>
316312
<td class="version">
317313
<a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
318314
</td>
319-
<td class="badge">
320-
<span class="package-badge" title="Package version is opted into null safety.">Null safety</span>
321-
</td>
315+
<td class="badge"></td>
322316
<td class="sdk">3.0</td>
323317
<td class="uploaded">
324318
<a class="-x-ago" href="" title="%%version-created-date%%" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>

‎app/test/task/testdata/goldens/packages/oxygen/versions.html‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,7 @@ <h2 id="stable">Stable versions of oxygen</h2>
235235
<td class="version">
236236
<a href="/packages/oxygen/versions/2.0.0" title="Visit oxygen 2.0.0 page">2.0.0</a>
237237
</td>
238-
<td class="badge">
239-
<span class="package-badge" title="Package version is opted into null safety.">Null safety</span>
240-
</td>
238+
<td class="badge"></td>
241239
<td class="sdk">3.0</td>
242240
<td class="uploaded">
243241
<a class="-x-ago" href="" title="%%short-dateformat%%" role="button" data-timestamp="%%time-ago-millis%%">%%time-ago%%</a>
@@ -257,16 +255,14 @@ <h2 id="stable">Stable versions of oxygen</h2>
257255
<td class="version">
258256
<a href="/packages/oxygen/versions/1.0.0" title="Visit oxygen 1.0.0 page">1.0.0</a>
259257
</td>
260-
<td class="badge">
261-
<span class="package-badge" title="Package version is opted into null safety.">Null safety</span>
262-
</td>
258+
<td class="badge"></td>
263259
<td class="sdk">3.0</td>
264260
<td class="uploaded">
265261
<a class="-x-ago" href="" title="%%short-dateformat%%" role="button" data-timestamp="%%time-ago-millis%%">%%time-ago%%</a>
266262
</td>
267263
<td class="documentation">
268-
<a href="/documentation/oxygen/1.0.0/" rel="nofollow" title="Go to the documentation of oxygen 1.0.0">
269-
<img class="pub-monochrome-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/description-24px.svg" alt="Go to the documentation of oxygen 1.0.0" width="24" height="24"/>
264+
<a href="/packages/oxygen/versions/1.0.0/score/log.txt" rel="nofollow" title="Check the analysis logs for oxygen 1.0.0">
265+
<img class="pub-monochrome-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/documentation-failed-icon.svg" alt="Check the analysis logs for oxygen 1.0.0" width="24" height="24"/>
270266
</a>
271267
</td>
272268
<td class="archive">

‎app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ <h1 id="oxygen" class="hash-header">
229229
</div>
230230
<div class="packages-score packages-score-health">
231231
<div class="packages-score-value -has-value">
232-
<span class="packages-score-value-number">140</span>
232+
<span class="packages-score-value-number">130</span>
233233
<span class="packages-score-value-sign"></span>
234234
</div>
235235
<div class="packages-score-label">points</div>
@@ -264,11 +264,6 @@ <h3 class="title">Topics</h3>
264264
<p>
265265
<a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
266266
</p>
267-
<h3 class="title">Documentation</h3>
268-
<p>
269-
<a class="link" href="/documentation/oxygen/1.0.0/">API reference</a>
270-
<br/>
271-
</p>
272267
<h3 class="title">Funding</h3>
273268
<p>
274269
Consider supporting this project:
@@ -308,7 +303,7 @@ <h3 class="detail-metadata-title">
308303
</div>
309304
<div class="packages-score packages-score-health">
310305
<div class="packages-score-value -has-value">
311-
<span class="packages-score-value-number">140</span>
306+
<span class="packages-score-value-number">130</span>
312307
<span class="packages-score-value-sign"></span>
313308
</div>
314309
<div class="packages-score-label">points</div>
@@ -343,11 +338,6 @@ <h3 class="title">Topics</h3>
343338
<p>
344339
<a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
345340
</p>
346-
<h3 class="title">Documentation</h3>
347-
<p>
348-
<a class="link" href="/documentation/oxygen/1.0.0/">API reference</a>
349-
<br/>
350-
</p>
351341
<h3 class="title">Funding</h3>
352342
<p>
353343
Consider supporting this project:

‎app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ <h2 class="changelog-version hash-header" id="100">
235235
</div>
236236
<div class="packages-score packages-score-health">
237237
<div class="packages-score-value -has-value">
238-
<span class="packages-score-value-number">140</span>
238+
<span class="packages-score-value-number">130</span>
239239
<span class="packages-score-value-sign"></span>
240240
</div>
241241
<div class="packages-score-label">points</div>
@@ -270,11 +270,6 @@ <h3 class="title">Topics</h3>
270270
<p>
271271
<a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
272272
</p>
273-
<h3 class="title">Documentation</h3>
274-
<p>
275-
<a class="link" href="/documentation/oxygen/1.0.0/">API reference</a>
276-
<br/>
277-
</p>
278273
<h3 class="title">Funding</h3>
279274
<p>
280275
Consider supporting this project:
@@ -314,7 +309,7 @@ <h3 class="detail-metadata-title">
314309
</div>
315310
<div class="packages-score packages-score-health">
316311
<div class="packages-score-value -has-value">
317-
<span class="packages-score-value-number">140</span>
312+
<span class="packages-score-value-number">130</span>
318313
<span class="packages-score-value-sign"></span>
319314
</div>
320315
<div class="packages-score-label">points</div>
@@ -349,11 +344,6 @@ <h3 class="title">Topics</h3>
349344
<p>
350345
<a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
351346
</p>
352-
<h3 class="title">Documentation</h3>
353-
<p>
354-
<a class="link" href="/documentation/oxygen/1.0.0/">API reference</a>
355-
<br/>
356-
</p>
357347
<h3 class="title">Funding</h3>
358348
<p>
359349
Consider supporting this project:

‎app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ <h3 class="detail-lead-title">Metadata</h3>
230230
</div>
231231
<div class="packages-score packages-score-health">
232232
<div class="packages-score-value -has-value">
233-
<span class="packages-score-value-number">140</span>
233+
<span class="packages-score-value-number">130</span>
234234
<span class="packages-score-value-sign"></span>
235235
</div>
236236
<div class="packages-score-label">points</div>
@@ -265,11 +265,6 @@ <h3 class="title">Topics</h3>
265265
<p>
266266
<a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
267267
</p>
268-
<h3 class="title">Documentation</h3>
269-
<p>
270-
<a class="link" href="/documentation/oxygen/1.0.0/">API reference</a>
271-
<br/>
272-
</p>
273268
<h3 class="title">Funding</h3>
274269
<p>
275270
Consider supporting this project:
@@ -309,7 +304,7 @@ <h3 class="detail-metadata-title">
309304
</div>
310305
<div class="packages-score packages-score-health">
311306
<div class="packages-score-value -has-value">
312-
<span class="packages-score-value-number">140</span>
307+
<span class="packages-score-value-number">130</span>
313308
<span class="packages-score-value-sign"></span>
314309
</div>
315310
<div class="packages-score-label">points</div>
@@ -344,11 +339,6 @@ <h3 class="title">Topics</h3>
344339
<p>
345340
<a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
346341
</p>
347-
<h3 class="title">Documentation</h3>
348-
<p>
349-
<a class="link" href="/documentation/oxygen/1.0.0/">API reference</a>
350-
<br/>
351-
</p>
352342
<h3 class="title">Funding</h3>
353343
<p>
354344
Consider supporting this project:

0 commit comments

Comments
 (0)