Skip to content

Commit 653d35b

Browse files
authored
Rename to versions-downloads-chart to downloads-chart (#8364)
1 parent 92ab61b commit 653d35b

File tree

11 files changed

+37
-40
lines changed

11 files changed

+37
-40
lines changed

app/lib/frontend/templates/views/pkg/score_tab.dart

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ d.Node scoreTabNode({
7979
],
8080
),
8181
_reportNode(report),
82-
if (card.weeklyVersionsDownloads != null)
83-
_versionDownloadsChart(card.weeklyVersionsDownloads!),
82+
if (card.weeklyVersionDownloads != null)
83+
_downloadsChart(card.weeklyVersionDownloads!),
8484
if (toolEnvInfo != null) toolEnvInfo,
8585
]),
8686
if (!showPending)
@@ -177,20 +177,18 @@ d.Node _section(ReportSection section) {
177177
]);
178178
}
179179

180-
d.Node _versionDownloadsChart(
181-
WeeklyVersionsDownloadCounts weeklyVersionsDownloads) {
180+
d.Node _downloadsChart(WeeklyVersionDownloadCounts weeklyVersionDownloads) {
182181
return d.div(
183-
classes: ['versions-downloads-chart'],
184-
id: '-versions-downloads-chart',
182+
classes: ['downloads-chart'],
183+
id: '-downloads-chart',
185184
attributes: {
186-
'data-widget': 'versions-downloads-chart',
187-
'data-versions-downloads-chart':
188-
_encodeForVersionsChart(weeklyVersionsDownloads)
185+
'data-widget': 'downloads-chart',
186+
'data-downloads-chart': _encodeForDownloadsChart(weeklyVersionDownloads)
189187
},
190188
);
191189
}
192190

193-
String _encodeForVersionsChart(WeeklyVersionsDownloadCounts wvcd) {
191+
String _encodeForDownloadsChart(WeeklyVersionDownloadCounts wvcd) {
194192
final date = wvcd.newestDate.toUtc().millisecondsSinceEpoch ~/ 1000;
195193

196194
final allCounts = <int>[];

app/lib/scorecard/backend.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,7 @@ class ScoreCardBackend {
163163
taskStatus = PackageVersionStatus.pending;
164164
}
165165

166-
final weeklyVersionsDownloads =
167-
await getWeeklyVersionsDownloads(packageName);
166+
final weeklyVersionDownloads = await getWeeklyVersionDownloads(packageName);
168167

169168
final data = ScoreCardData(
170169
packageName: packageName,
@@ -177,7 +176,7 @@ class ScoreCardBackend {
177176
),
178177
panaReport: PanaReport.fromSummary(summary, packageStatus: status),
179178
taskStatus: taskStatus,
180-
weeklyVersionsDownloads: weeklyVersionsDownloads,
179+
weeklyVersionDownloads: weeklyVersionDownloads,
181180
);
182181
await cacheEntry.set(data);
183182
return data;

app/lib/scorecard/models.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class ScoreCardData {
3434
final DartdocReport? dartdocReport;
3535
final PanaReport? panaReport;
3636
final PackageVersionStatus? taskStatus;
37-
final WeeklyVersionsDownloadCounts? weeklyVersionsDownloads;
37+
final WeeklyVersionDownloadCounts? weeklyVersionDownloads;
3838

3939
ScoreCardData({
4040
this.packageName,
@@ -44,7 +44,7 @@ class ScoreCardData {
4444
this.dartdocReport,
4545
this.panaReport,
4646
this.taskStatus,
47-
this.weeklyVersionsDownloads,
47+
this.weeklyVersionDownloads,
4848
});
4949

5050
factory ScoreCardData.fromJson(Map<String, dynamic> json) =>

app/lib/scorecard/models.g.dart

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/lib/service/download_counts/computations.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ Future<WeeklyDownloadCounts?> getWeeklyTotalDownloads(String package) async {
5252
}));
5353
}
5454

55-
Future<WeeklyVersionsDownloadCounts?> getWeeklyVersionsDownloads(
55+
Future<WeeklyVersionDownloadCounts?> getWeeklyVersionDownloads(
5656
String package) async {
57-
return (await cache.weeklyVersionsDownloadCounts(package).get(() async {
58-
return computeWeeklyVersionsDownloads(package);
57+
return (await cache.weeklyVersionDownloadCounts(package).get(() async {
58+
return computeWeeklyVersionDownloads(package);
5959
}));
6060
}
6161

@@ -81,7 +81,7 @@ Future<WeeklyDownloadCounts?> computeWeeklyTotalDownloads(
8181
/// Computes weekly downloads starting from `newestDate` for [package] and 52
8282
/// weeks back for all stored major, minor, and patch version ranges and total
8383
/// downloads.
84-
Future<WeeklyVersionsDownloadCounts?> computeWeeklyVersionsDownloads(
84+
Future<WeeklyVersionDownloadCounts?> computeWeeklyVersionDownloads(
8585
String package) async {
8686
final countData =
8787
await downloadCountsBackend.lookupDownloadCountData(package);
@@ -111,7 +111,7 @@ Future<WeeklyVersionsDownloadCounts?> computeWeeklyVersionsDownloads(
111111

112112
final weeklyTotalCounts = _computeWeeklyCounts(countData.totalCounts);
113113

114-
return WeeklyVersionsDownloadCounts(
114+
return WeeklyVersionDownloadCounts(
115115
newestDate: countData.newestDate!,
116116
majorRangeWeeklyDownloads: majorRangeWeeklyCounts,
117117
minorRangeWeeklyDownloads: minorRangeWeeklyCounts,

app/lib/service/download_counts/download_counts.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ class WeeklyDownloadCounts {
244244
}
245245

246246
@JsonSerializable(includeIfNull: false)
247-
class WeeklyVersionsDownloadCounts {
247+
class WeeklyVersionDownloadCounts {
248248
/// An integer list where each number is the total number of downloads for a
249249
/// given 7 day period starting from [newestDate].
250250
final List<int> totalWeeklyDownloads;
@@ -273,15 +273,15 @@ class WeeklyVersionsDownloadCounts {
273273
/// The newest date with download counts data available.
274274
final DateTime newestDate;
275275

276-
WeeklyVersionsDownloadCounts({
276+
WeeklyVersionDownloadCounts({
277277
required this.newestDate,
278278
required this.majorRangeWeeklyDownloads,
279279
required this.minorRangeWeeklyDownloads,
280280
required this.patchRangeWeeklyDownloads,
281281
required this.totalWeeklyDownloads,
282282
});
283283

284-
factory WeeklyVersionsDownloadCounts.fromJson(Map<String, dynamic> json) =>
285-
_$WeeklyVersionsDownloadCountsFromJson(json);
286-
Map<String, dynamic> toJson() => _$WeeklyVersionsDownloadCountsToJson(this);
284+
factory WeeklyVersionDownloadCounts.fromJson(Map<String, dynamic> json) =>
285+
_$WeeklyVersionDownloadCountsFromJson(json);
286+
Map<String, dynamic> toJson() => _$WeeklyVersionDownloadCountsToJson(this);
287287
}

app/lib/service/download_counts/download_counts.g.dart

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/lib/shared/redis_cache.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,17 +257,17 @@ class CachePatterns {
257257
decode: (d) => WeeklyDownloadCounts.fromJson(d as Map<String, dynamic>),
258258
))[package];
259259

260-
Entry<WeeklyVersionsDownloadCounts> weeklyVersionsDownloadCounts(
260+
Entry<WeeklyVersionDownloadCounts> weeklyVersionDownloadCounts(
261261
String package) =>
262262
_cache
263263
.withPrefix('weekly-versions-download-counts/')
264264
.withTTL(Duration(hours: 6))
265265
.withCodec(utf8)
266266
.withCodec(json)
267267
.withCodec(wrapAsCodec(
268-
encode: (WeeklyVersionsDownloadCounts wdc) => wdc.toJson(),
269-
decode: (d) => WeeklyVersionsDownloadCounts.fromJson(
270-
d as Map<String, dynamic>),
268+
encode: (WeeklyVersionDownloadCounts wdc) => wdc.toJson(),
269+
decode: (d) =>
270+
WeeklyVersionDownloadCounts.fromJson(d as Map<String, dynamic>),
271271
))[package];
272272

273273
Entry<List<LikeData>> userPackageLikes(String userId) => _cache

app/test/frontend/golden/pkg_score_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ <h3>
293293
</div>
294294
</div>
295295
</div>
296-
<div id="-versions-downloads-chart" class="versions-downloads-chart" data-widget="versions-downloads-chart" data-versions-downloads-chart="AO1QZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=,[>=1.0.0-0 &lt;2.0.0, >=1.2.0-0 &lt;1.3.0, >=1.2.0-0 &lt;1.2.1]"></div>
296+
<div id="-downloads-chart" class="downloads-chart" data-widget="downloads-chart" data-downloads-chart="AO1QZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=,[>=1.0.0-0 &lt;2.0.0, >=1.2.0-0 &lt;1.3.0, >=1.2.0-0 &lt;1.2.1]"></div>
297297
<p class="tool-env-info">
298298
Analyzed with Pana
299299
<code>%%pana-version%%</code>

app/test/frontend/golden/pkg_score_page_with_downloads_chart.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ <h3>
293293
</div>
294294
</div>
295295
</div>
296-
<div id="-versions-downloads-chart" class="versions-downloads-chart" data-widget="versions-downloads-chart" data-versions-downloads-chart="AO1QZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=,[>=1.0.0-0 &lt;2.0.0, >=1.2.0-0 &lt;1.3.0, >=1.2.0-0 &lt;1.2.1]"></div>
296+
<div id="-downloads-chart" class="downloads-chart" data-widget="downloads-chart" data-downloads-chart="AO1QZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=,[>=1.0.0-0 &lt;2.0.0, >=1.2.0-0 &lt;1.3.0, >=1.2.0-0 &lt;1.2.1]"></div>
297297
<p class="tool-env-info">
298298
Analyzed with Pana
299299
<code>%%pana-version%%</code>

0 commit comments

Comments
 (0)