updates

Author: szakarias

app/test/service/download_counts/fake_download_counts.dart renamed to app/lib/fake/backend/fake_download_counts.dart

@@ -21,45 +21,46 @@ d.Node labeledScoresNode({
     children: [
       d.div(
         classes: ['packages-score', 'packages-score-like'],
-        child: _labeledScore('likes', likeCount, sign: ''),
+        child: _labeledScore('likes', likeCount.toString(), sign: ''),
       ),
       d.div(
         classes: ['packages-score', 'packages-score-health'],
-        child: _labeledScore('pub points', grantedPubPoints, sign: ''),
+        child:
+            _labeledScore('pub points', grantedPubPoints?.toString(), sign: ''),
       ),
       requestContext.experimentalFlags.showDownloadCounts
           ? d.div(
               classes: ['packages-score', 'packages-score-downloads'],
               child: _labeledScore(
                 'downloads',
                 thirtyDaysDownloads != null
-                    ? computeValueWithSuffix(thirtyDaysDownloads).value
+                    ? formatWith3SignificantDigits(thirtyDaysDownloads).value
                     : null,
                 sign: thirtyDaysDownloads != null
-                    ? computeValueWithSuffix(thirtyDaysDownloads).suffix
+                    ? formatWith3SignificantDigits(thirtyDaysDownloads).suffix
                     : '',
               ),
             )
           : d.div(
               classes: ['packages-score', 'packages-score-popularity'],
               child: _labeledScore(
                 'popularity',
-                popularityStorage.isInvalid ? null : popularity,
+                popularityStorage.isInvalid ? null : popularity.toString(),
                 sign: popularityStorage.isInvalid ? '' : '%',
               ),
             ),
     ],
   );
 }
 
-d.Node _labeledScore(String label, num? value, {required String sign}) {
+d.Node _labeledScore(String label, String? value, {required String sign}) {
   return d.fragment([
     d.div(
       classes: ['packages-score-value', if (value != null) '-has-value'],
       children: [
         d.span(
           classes: ['packages-score-value-number'],
-          text: value?.toString() ?? '--',
+          text: value ?? '--',
         ),
         d.span(classes: ['packages-score-value-sign'], text: sign),
       ],

app/lib/frontend/templates/views/pkg/labeled_scores.dart

@@ -11,7 +11,7 @@ import 'package:pub_dev/shared/configuration.dart';
 import 'package:test/test.dart';
 
 import '../../shared/test_services.dart';
-import 'fake_download_counts.dart';
+import '../../../lib/fake/backend/fake_download_counts.dart';
 
 void main() {
   group('', () {

app/test/service/download_counts/compute_total_download_counts_test.dart

@@ -12,7 +12,7 @@ import 'package:pub_dev/service/download_counts/sync_download_counts.dart';
 import 'package:test/test.dart';
 
 import '../../shared/test_services.dart';
-import 'fake_download_counts.dart';
+import '../../../lib/fake/backend/fake_download_counts.dart';
 
 void main() {
   group('', () {

app/test/service/download_counts/download_counts_test.dart

@@ -6,26 +6,17 @@
 /// The chunk will have a single digit precision, and will be
 /// rounded down, in order to prevent exaggerated counts.
 String formatWithSuffix(int value) {
-  final f = computeValueWithSuffix(value);
-  return '${_toFixed(f.value)}${f.suffix}';
-}
-
-({num value, String suffix}) computeValueWithSuffix(int value) {
   if (value >= 1000000) {
-    return (value: _singleDigitDivision(value, 1000000), suffix: 'm');
+    return '${_toFixed(value, 1000000)}m';
   } else if (value >= 1000) {
-    return (value: _singleDigitDivision(value, 1000), suffix: 'k');
+    return '${_toFixed(value, 1000)}k';
   } else {
-    return (value: value, suffix: '');
+    return value.toString();
   }
 }
 
-num _singleDigitDivision(int value, int d) {
-  return (((value * 10) ~/ d) / 10);
-}
-
-String _toFixed(num value) {
-  return value < 1000 ? '$value' : value.toStringAsFixed(1);
+String _toFixed(int value, int d) {
+  return (((value * 10) ~/ d) / 10).toStringAsFixed(1);
 }
 
 /// Formats an int [value] to human readable chunk and suffix with at most 3